Re: rbtree in ngx_http_upstream_fair_module.c

2015-01-29 Thread squonk
I think i underatand a bit better now. The tree is storing metadata for potentially multiple upstream groups per generation. It seems like a reasonable implementation given the expected short duration of threads referencing data from older generations (hence a shallow tree) and the fact there is o

rbtree in ngx_http_upstream_fair_module.c

2015-01-29 Thread squonk
hi.. Just wanted to ensure my understanding of rbtree usage in Grzegorz Nosek's upstream fair load balancer is correct. I believe the rbtree is necessary because when nginx.conf is reloaded workers may continue to reference upstream server metadata from earlier versions aka generations of the ngin