Re: Whitelist certain query string results in infinite redirect loop

2016-08-04 Thread Francis Daly
On Thu, Aug 04, 2016 at 12:58:39AM -0400, jwxie wrote: Hi there, > location /login { > if ($args ~* "client_id=bad-client-id") { > rewrite ^(.*)$ $1? redirect; > } That says: if I ask for /login/something?key=value&client_id=bad-client-id, I get a http redirect to

Whitelist certain query string results in infinite redirect loop

2016-08-03 Thread jwxie
Hi. Our login page accepts a query parameter called client_id. Suppose we have three applications and their respective client_ids are: client_id=external-app client_id=internal-app1 client_id=internal-app2 You may guess... behind the scene we do an oauth login that's why "client_id" is in the ur