Re: Valgrind reporting issue in connection->addr_text

2019-05-07 Thread bhagavathula
Hi, Thanks for the response. We fixed the issue related to casting and still didnt see any change in behavior where intermittently garbage values are being appended. However, when we tried to get the ip address using alternate means, as follows the issue is not happening and Valgrind is also not r

Re: Valgrind reporting issue in connection->addr_text

2019-05-06 Thread Robert Paprocki
Hi, addr_text is of type 'ngx_str_t': http://lxr.nginx.org/source/src/core/ngx_connection.h#0148, which provides both the char pointer and the length. It's not correct to cast that value to a char pointer directly. On Mon, May 6, 2019 at 11:09 AM bhagavathula wrote: > Hi, > > When running Valgr

Valgrind reporting issue in connection->addr_text

2019-05-06 Thread bhagavathula
Hi, When running Valgrind on our NGINX module for errors, found the following errors: ==49784== Conditional jump or move depends on uninitialised value(s) ==49784==at 0x4C32D08: strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==49784==by 0x6C3A328: apr_pstrdup (in /usr/lib/