Re: 1.9.13 and non_idempotent

2016-04-04 Thread Maxim Dounin
Hello! On Fri, Apr 01, 2016 at 10:33:22PM -0700, Frank Liu wrote: > Will this work? > > --- ngx_http_upstream.c.orig 2016-03-29 15:09:31.0 + > +++ ngx_http_upstream.c 2016-04-02 05:28:17.877466756 + > @@ -3990,6 +3990,7 @@ > timeout = u->conf->next_upstream_timeout; > >

Re: 1.9.13 and non_idempotent

2016-04-01 Thread Frank Liu
Will this work? --- ngx_http_upstream.c.orig 2016-03-29 15:09:31.0 + +++ ngx_http_upstream.c 2016-04-02 05:28:17.877466756 + @@ -3990,6 +3990,7 @@ timeout = u->conf->next_upstream_timeout; if (u->request_sent +&& (ft_type != NGX_HTTP_UPSTREAM_FT_HTTP_404)

Re: 1.9.13 and non_idempotent

2016-04-01 Thread Frank Liu
Can you post a quick patch on how to exclude http_404? Thanks! Frank On Tue, Mar 29, 2016 at 8:26 PM, Maxim Dounin wrote: > Hello! > > On Tue, Mar 29, 2016 at 08:04:33PM -0700, Frank Liu wrote: > > > It's a custom error code, think of it as if http_404, so if the first > > upstream can't handle

Re: 1.9.13 and non_idempotent

2016-03-31 Thread Maxim Dounin
Hello! On Thu, Mar 31, 2016 at 07:46:40PM -0700, Frank Liu wrote: > Does that mean by default if one upstream server is down (connect error or > connect timeout), nginx won't try the next server and POST request will > just fail? No. Quoting CHANGES (http://nginx.org/en/CHANGES): *) Change

Re: 1.9.13 and non_idempotent

2016-03-31 Thread Frank Liu
Does that mean by default if one upstream server is down (connect error or connect timeout), nginx won't try the next server and POST request will just fail? Thanks! Frank On Tue, Mar 29, 2016 at 7:48 PM, Maxim Dounin wrote: > Hello! > > On Tue, Mar 29, 2016 at 06:34:59PM -0700, Frank Liu wrot

Re: 1.9.13 and non_idempotent

2016-03-29 Thread Maxim Dounin
Hello! On Tue, Mar 29, 2016 at 08:04:33PM -0700, Frank Liu wrote: > It's a custom error code, think of it as if http_404, so if the first > upstream can't handle this request , it will send "404" saying it is not > for me, please try next, nginx should then send the same request to next > upstrea

Re: 1.9.13 and non_idempotent

2016-03-29 Thread Frank Liu
It's a custom error code, think of it as if http_404, so if the first upstream can't handle this request , it will send "404" saying it is not for me, please try next, nginx should then send the same request to next upstream. On Tuesday, March 29, 2016, Maxim Dounin wrote: > Hello! > > On Tue,

Re: 1.9.13 and non_idempotent

2016-03-29 Thread Maxim Dounin
Hello! On Tue, Mar 29, 2016 at 06:34:59PM -0700, Frank Liu wrote: > If I explicitly configured to retry next upstream based on a > certain http_xxx, will that stop working if a request is a POST with > 1.9.13? Yes. There is no real difference between a network error and an HTTP error returned

1.9.13 and non_idempotent

2016-03-29 Thread Frank Liu
If I explicitly configured to retry next upstream based on a certain http_xxx, will that stop working if a request is a POST with 1.9.13? For other http code, I like the idea of not retry if it is non idempotent but for one http_xxx, I want retry no matter what type of request. Thanks Frank __