Re: Possible memory leak?

2019-03-27 Thread wkbrad
Hey Maxim, I want to thank you again for all of your time and effort looking into this. It's been extremely helpful. Really... thank you! According to the man page, changing the junk setting is for debugging and would have negative impacts on performance. https://www.freebsd.org/cgi/man.cgi?que

Re: Possible memory leak?

2019-03-21 Thread wkbrad
Hey Maxim, Thanks again! I was a little confused at first because your tests in freebsd were so much different than mine but then I found what you did wrong. You were testing the 2nd reload but the issue can only be seen on the first reload. Here is my test to show what I mean.

Re: Possible memory leak?

2019-03-21 Thread wkbrad
Thanks again Maxim! You're really providing some valuable insights for me. > This is because mmap()-based individual allocations imply additional > overhead. Using mmapAnd this is are costly. That's what I figured might be going on. I assume there are also some negative impacts on performance w

Re: Possible memory leak?

2019-03-20 Thread wkbrad
Hey Maxim, Thanks so much for the very thoughtful and detailed response! Sorry for the delay in getting back to you. I wanted to test all of this and then I got busy at work and haven't been able to get back to it. I've run a lot of tests on this and I'm seeing some success. :) The first test

Re: Possible memory leak?

2019-03-12 Thread wkbrad
Hey Maxim, First of all, thanks so much for your insights into this and being patient with me. :) I'm just trying to understand the issue and what can be done about it. Can you explain to me what you mean by this? > you can configure system allocator to use mmap() I'm not a C programmer so cor

Re: Possible memory leak?

2019-03-11 Thread wkbrad
Hi All, I think I haven't been clear in what I'm seeing so let's start over. :) I set up a very simple test on Centos 7 with a default install of Nginx 1.12.2. Below is exactly what I did to produce the result and it's clear to me that Nginx is using 2x the ram than it should be using after the

Re: Possible memory leak?

2019-03-08 Thread wkbrad
Thanks for that info. It's definitely harder to notice the issue on small servers like that. But you are still seeing about a 50% increase in ram usage there by your own tests. The smallest server I've tested this on uses about 20M during the first start and about 50M after a reload is completel

Re: Possible memory leak?

2019-03-08 Thread wkbrad
Hi Anoop! I thought you might have been the nDeploy guy and I've been planning on bringing this up with you too. We actually have several servers licensed with you. :) And they do have the same issue but you're still misunderstanding what the problem is. I completely understand that when the r

Re: Possible memory leak?

2019-03-07 Thread wkbrad
Thanks, Anoop! But I don't think you understood the point I was trying to get across. I was definitely not trying to compare nginx and apache memory usage. Let's just ignore that part was ever said. :) I'm trying to understand why Nginx is using 2x the memory usage when the HUP signal is sent,

Re: Possible memory leak?

2019-03-07 Thread wkbrad
Hi all, I just wanted to share the details of what I've found about this issue. Also thanks to Maxim Dounin and Reinis Rozitis who gave some really great answers! The more I look into this the more I'm convinced this is an issue with Nginx itself. I've tested this with 3 different builds now an

Re: RE: Possible memory leak?

2019-02-28 Thread wkbrad
Thanks Reinis! That's some really great info and from the short tests that I've run so far I think this is going to be the solution. I used this command as the test: pid="$(cat /run/nginx.pid)"; kill -USR2 $pid; sleep 10; kill -QUIT $pid And here is what happened with the reload: 37.0 MiB + 1

Re: Possible memory leak?

2019-02-28 Thread wkbrad
Thanks Maxim! I really appreciate your time! As for what I was referring to a memory leak, I guess I'm just referring to the effects I'm seeing across a number of systems with highly different configurations. I'm not an expert so I'll defer to you on that. :) My question still stands though, i

Re: Possible memory leak?

2019-02-28 Thread wkbrad
Maxim Dounin Wrote: --- > so allocator will not be able to release no-longer-needed > memory (previously used by the original configuration) to the > system. Thanks Maxim! That sounds like the very definition of a memory leak to me. :) But I

Possible memory leak?

2019-02-28 Thread wkbrad
We're running Nginx version 1.15.8 but we've been seeing similar issues with other versions too and on all of our servers that have a high number of vhosts. The issue is that when you do an nginx reload it ends up using almost 2x the ram as it was previously. Here is a test I ran. ---