Re:Re: Re: Re: fix accidental corrdump

2022-09-29 Thread zjd
If disturb everyone, I'm sorry. l->alloc itself address(&l->alloc) in the pool can be reused rather than l->alloc pointer to wild address, &l->alloc return to pool. And I try only use large memory with Maxim's way, but it's not coredump. Because coredump is accident, not coredump maybe be reaso

Re: Re: Re: fix accidental corrdump

2022-09-29 Thread Maxim Dounin
Hello! On Thu, Sep 29, 2022 at 04:37:24PM -0400, Frank Swasey wrote: > This is getting quite tiresome. You are both stuck in your point of view > and refusing to hear what the other one is saying. > > Maxim - you keep repeating " l->alloc is not used after free(). " Clearly, > that is not true

Re: Re: Re: fix accidental corrdump

2022-09-29 Thread Frank Swasey
This is getting quite tiresome. You are both stuck in your point of view and refusing to hear what the other one is saying. Maxim - you keep repeating " l->alloc is not used after free(). " Clearly, that is not true if setting it to NULL prevents the segfault. What is true is that NGINX core co

Re: Re: Re: fix accidental corrdump

2022-09-29 Thread Maxim Dounin
Hello! On Thu, Sep 29, 2022 at 04:30:45PM +0800, zjd wrote: > Actually, I'm not sure where is coredump; So I think > l->alloc=NULL after free(l-alloc) is reasonable, because > l->alloc's address can be reused in the pool. Of course, > memzero after get mem from the pool can be solved abo

Re: Running nginx-quic in a real environment

2022-09-29 Thread Maxim Dounin
Hello! On Thu, Sep 29, 2022 at 05:53:52PM +0400, Sergey Kandaurov wrote: > > > On 28 Sep 2022, at 01:04, Maxim Dounin wrote: > > > > Hello! > > > > On Tue, Sep 27, 2022 at 04:05:54PM +0400, Sergey Kandaurov wrote: > > > >>> On 27 Sep 2022, at 14:11, João Sousa Andrade > >>> wrote: > >>> >

Re: Running nginx-quic in a real environment

2022-09-29 Thread Sergey Kandaurov
> On 28 Sep 2022, at 01:04, Maxim Dounin wrote: > > Hello! > > On Tue, Sep 27, 2022 at 04:05:54PM +0400, Sergey Kandaurov wrote: > >>> On 27 Sep 2022, at 14:11, João Sousa Andrade >>> wrote: >>> >>> Thank you for the clarification Sergey. >>> >>> We have been running http3 in production f

Re:Re: Re: fix accidental corrdump

2022-09-29 Thread zjd
Actually, I'm not sure where is coredump; So I think l->alloc=NULL after free(l-alloc) is reasonable, because l->alloc's address can be reused in the pool. Of course, memzero after get mem from the pool can be solved about this question.But for example, ngx_array_push maybe reuse l->alloc'