On 5/5/15, 10:34 AM, [email protected] wrote:
From: Scott Feldman
New attr-based bridge_setlink can recurse lower devs and recover on err, so
remove old wrapper. Also, restore br_setlink back to original and don't
call into SELF port driver. rtnetlink.c:bridge_setlink already does a call
into
On 5/18/15, 1:19 PM, David Miller wrote:
From: Roopa Prabhu
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems where you can offload routes to hardware,
doing routing in software is not an option (the cpu limitations
make routing impossible in software).
You absolutely do not get to
On 5/20/15, 10:46 PM, Scott Feldman wrote:
On Tue, May 19, 2015 at 1:28 PM, David Miller wrote:
From: Andy Gospodarek
Date: Tue, 19 May 2015 15:47:32 -0400
Are you actually saying that if users complain loudly enough about
the current behavior (not the change Roopa has proposed) that you
x and multicast_router attributes can be
changed even if the according bridge (port) is down, just like other
other bridge (port) attributes allow too.
Signed-off-by: Linus Lüssing
---
Changelog:
* [RFC PATCH net-next] -> [PATCH net-next]
Acked-by: Roopa Prabhu
we have a similar patch
On 5/26/15, 2:48 PM, Eric W. Biederman wrote:
Roopa Prabhu writes:
From: Roopa Prabhu
This patch fixes incorrect -EINVAL error due to invalid
scope and type for mpls route deletes.
Well this is embarrassing apparently I did not exercise this code path
in iproute.
Looking through my tests
On 5/27/15, 12:59 PM, Robert Shearman wrote:
On 27/05/15 19:37, Roopa Prabhu wrote:
From: Roopa Prabhu
Kernel expects type RTN_UNICAST for mpls route/dels
Signed-off-by: Vivek Venkataraman
Signed-off-by: Roopa Prabhu
---
ip/iproute.c |5 +
1 file changed, 5 insertions(+)
diff
On 5/27/15, 1:08 PM, roopa wrote:
On 5/27/15, 12:59 PM, Robert Shearman wrote:
On 27/05/15 19:37, Roopa Prabhu wrote:
From: Roopa Prabhu
Kernel expects type RTN_UNICAST for mpls route/dels
Signed-off-by: Vivek Venkataraman
Signed-off-by: Roopa Prabhu
---
ip/iproute.c |5 +
1
On 5/28/15, 2:42 AM, Jiri Pirko wrote:
Mon, May 18, 2015 at 10:19:16PM CEST, [email protected] wrote:
From: Roopa Prabhu
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems where you can offload routes to hardware,
doing routing in software is not an option (the cpu limitations
make
On 5/28/15, 9:10 AM, John Fastabend wrote:
On 05/28/2015 08:40 AM, Scott Feldman wrote:
On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko wrote:
Mon, May 18, 2015 at 10:19:16PM CEST, [email protected] wrote:
From: Roopa Prabhu
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems where you
On 5/28/15, 3:35 PM, Andy Gospodarek wrote:
On Thu, May 28, 2015 at 08:40:11AM -0700, Scott Feldman wrote:
On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko wrote:
Mon, May 18, 2015 at 10:19:16PM CEST, [email protected] wrote:
From: Roopa Prabhu
Date: Sun, 17 May 2015 16:42:05 -0700
On most
On 6/1/15, 9:46 AM, Robert Shearman wrote:
In order to be able to function as a Label Edge Router in an MPLS
network, it is necessary to be able to take IP packets and impose an
MPLS encap and forward them out. The traditional approach of setting
up an interface for each "tunnel" endpoint doesn't
On 6/1/15, 3:58 PM, David Miller wrote:
From: Roopa Prabhu
Date: Wed, 27 May 2015 11:37:05 -0700
- if (rtm->rtm_scope != RT_SCOPE_UNIVERSE)
- goto errout;
+ if (nlh->nlmsg_type != RTM_DELROUTE &&
+ rtm->rtm_scope !=
On 6/1/15, 9:46 AM, Robert Shearman wrote:
Parse RTA_ENCAP attribute for one path and multipath routes. The encap
length is stored in a newly added field to fib_nh, nh_encap_len,
although this is added to a padding hole in the structure so that it
doesn't increase the size at all. The encap data
On 6/1/15, 9:46 AM, Robert Shearman wrote:
Allow creating an mpls device for the purposes of encapsulating IP
packets with:
ip link add type ipmpls
This device defines its per-nexthop encapsulation data as a stack of
labels, in the same format as for RTA_NEWST. It uses the encap data
which w
On 6/2/15, 7:30 AM, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote:
On 06/02/15 03:10, Scott Feldman wrote:
Actually, we're now consistent with bridge man page which says master
is the default.
Want we want, I believe, is to adjust what the man page says (and th
On 5/27/15, 9:01 AM, Scott Feldman wrote:
On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov
wrote:
On Wed, May 27, 2015 at 9:59 AM, Scott Feldman wrote:
On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov
wrote:
On Tue, May 26, 2015 at 7:28 PM, Stephen Hemminger
wrote:
On Thu, 21 May
On 6/2/15, 11:30 AM, Eric W. Biederman wrote:
roopa writes:
On 6/1/15, 9:46 AM, Robert Shearman wrote:
In order to be able to function as a Label Edge Router in an MPLS
network, it is necessary to be able to take IP packets and impose an
MPLS encap and forward them out. The traditional
On 6/2/15, 9:33 AM, Robert Shearman wrote:
On 02/06/15 17:15, roopa wrote:
On 6/1/15, 9:46 AM, Robert Shearman wrote:
Allow creating an mpls device for the purposes of encapsulating IP
packets with:
ip link add type ipmpls
This device defines its per-nexthop encapsulation data as a stack
On 10/15/15, 7:38 PM, David Ahern wrote:
> Hi Roopa:
>
> On 10/15/15 4:23 PM, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> replace exit with return -2 on rtnl_talk failure
>>
>> Signed-off-by: Roopa Prabhu
>> ---
>> ip/iproute.c | 2
On 10/16/15, 4:12 PM, Stephen Hemminger wrote:
> Add missing rule to export mpls iptunnel header needed by iproute2
>
> Signed-off-by: Stephen Hemminger
Acked-by: Roopa Prabhu
Thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
On 10/21/15, 7:00 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> From: Roopa Prabhu
>>
>> This patch adds support for MPLS multipath routes.
>>
>> Includes following changes to support multipath:
>> - splits struct mpls_route into 'stru
On 10/22/15, 3:24 AM, Robert Shearman wrote:
> On 19/10/15 02:20, Roopa Prabhu wrote:
>> @@ -159,6 +137,7 @@ static int mpls_forward(struct sk_buff *skb, struct
>> net_device *dev,
>> struct net *net = dev_net(dev);
>> struct mpls_shim_hdr *hdr;
>
On 10/21/15, 9:04 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> From: Roopa Prabhu
>>
>> This patch adds support for MPLS multipath routes.
>>
>> Includes following changes to support multipath:
>> - splits struct mpls_route into 'stru
On 10/22/15, 5:16 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This patch adds support for MPLS multipath routes.
>
> Includes following changes to support multipath:
> - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'.
>
> - struct mpls_
On 10/26/15, 9:16 PM, kbuild test robot wrote:
> Hi Roopa,
>
> [auto build test ERROR on net-next/master -- if it's inappropriate base,
> please suggest rules for selecting the more suitable base]
>
> url:
> https://github.com/0day-ci/linux/commits/Roopa-Prab
On 10/27/15, 7:02 AM, David Miller wrote:
> From: Nikolay Aleksandrov
> Date: Tue, 27 Oct 2015 14:31:48 +0100
>
>> On 10/27/2015 01:12 PM, Roopa Prabhu wrote:
>>> From: Roopa Prabhu
>>>
>>> Problem Description:
>>> We can add fdbs pointing t
payload_type = MPT_IPV6;
> rt2->rt_nh->nh_via_table = NEIGH_LINK_TABLE;
> + rt2->rt_nh->nh_via_alen = lo->addr_len;
> memcpy(rt2->rt_nh->nh_via, lo->dev_addr, lo->addr_len);
> }
>
Acked-by: Roopa Prabhu
--
To u
On 10/26/15, 5:37 PM, Robert Shearman wrote:
> Nexthops for MPLS routes have a via address field sized for the
> largest via address that is expected, which is 32 bytes. This means
> that in the most common case of having ipv4 via addresses, 28 bytes of
> memory more than required are used per next
On 10/29/15, 9:53 AM, Robert Shearman wrote:
> On 29/10/15 15:49, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags.
>> This resembles ipv4 fib code. I also picked fib_rebalance from
>> ipv4. Enabled
On 11/1/15, 1:27 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
>> index c70d750..7db9678 100644
>> --- a/net/mpls/af_mpls.c
>> +++ b/net/mpls/af_mpls.c
>> @@ -27,6 +27,8 @@
>> */
>&
On 11/1/15, 9:08 PM, Eric W. Biederman wrote:
> roopa writes:
>
>> On 11/1/15, 1:27 PM, Eric W. Biederman wrote:
>>> Roopa Prabhu writes:
>>>
>>>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
>>>> index c70d750..7db9678 100644
>&
On 11/2/15, 10:09 PM, Eric W. Biederman wrote:
> Sergei Shtylyov writes:
>
>> Hello.
>>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
>>> index c70d750148b6..893cd2dc3979 100644
>>> --- a/net/mpls/af_mpls.c
>>> +++ b/net/mpls/af_mpls.c
>>> @@ -1162,6 +1162,8 @@ static int rtm_to_route_conf
Thanks fixed in v3.
On 11/2/15, 11:11 PM, Julia Lawall wrote:
> Please check on what was intended.
>
> julia
>
> On Tue, 3 Nov 2015, kbuild test robot wrote:
>
>> CC: [email protected]
>> In-Reply-To: <[email protected]&g
On 11/3/15, 7:28 AM, David Miller wrote:
> From: Roopa Prabhu
> Date: Mon, 2 Nov 2015 21:13:01 -0800
>
>> From: Roopa Prabhu
>>
>> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls
>> routes due to link events. Also adds code to ignore dead
On 11/3/15, 7:08 AM, Robert Shearman wrote:
> On 03/11/15 05:13, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls
>> routes due to link events. Also adds code to ignore dead
>> routes during route sel
On 11/3/15, 10:54 AM, Eric W. Biederman wrote:
> roopa writes:
>
>> On 11/3/15, 7:08 AM, Robert Shearman wrote:
>>> On 03/11/15 05:13, Roopa Prabhu wrote:
>>>> From: Roopa Prabhu
>>>>
>>>> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOW
On 1/10/16, 2:28 AM, Thomas Graf wrote:
> On 01/09/16 at 10:39am, roopa wrote:
>> On 1/6/16, 5:33 AM, David Wragg wrote:
>>> Allow the MTU of vxlan devices without an underlying device to be set to
>>> larger values (up to a maximum based on IP packet li
ev
ops/api layer.
ip link set dev swp1 swport_type eth swport_desired_type
Taking this one step further, the port splitter management can be done in
user-space:
And, users/switch port management infra can use 'ip link add type swport ...'
to create required switch ports.
Thanks,
Roopa
_FILTER_SKIP_STATS). So,
extending that interface for
mpls is not the right thing to do either.
There is work being done for a separate netlink infrastructure for stats.
I would wait for that infrastructure to be ready to add mpls stats. It should
be available soon.
thanks,
Roopa
On 3/14/16, 7:51 AM, Jiri Pirko wrote:
> Sun, Mar 13, 2016 at 02:56:25AM CET, [email protected] wrote:
>> From: Roopa Prabhu
>>
>> This patch adds a new RTM_GETSTATS message to query link stats via netlink
> >from the kernel. RTM_NEWLINK also dumps stats today,
On 3/14/16, 12:04 PM, Jiri Pirko wrote:
> Mon, Mar 14, 2016 at 07:45:23PM CET, [email protected] wrote:
>> On 3/14/16, 7:51 AM, Jiri Pirko wrote:
>>> Sun, Mar 13, 2016 at 02:56:25AM CET, [email protected] wrote:
>>>> From: Roopa Prabhu
>>>&g
On 3/14/16, 8:00 AM, Nicolas Dichtel wrote:
> Le 13/03/2016 02:56, Roopa Prabhu a écrit :
>> From: Roopa Prabhu
>>
>> This patch adds a new RTM_GETSTATS message to query link stats via netlink
>> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK
>
On 3/14/16, 8:11 AM, Elad Raz wrote:
>
>> -Original Message-
>> From: [email protected] [mailto:[email protected]]
>> On Behalf Of Roopa Prabhu
>> Sent: Sunday, March 13, 2016 3:56 AM
>> To: [email protected]
>> Cc:
and it is
based on this assumption).
so, RTM_NEWSTATS seems more appropriate here.
But, if you have stronger reasons for RTM_GETSTATS, sure, pls let me know.
Thanks,
Roopa
wrote:
>>>>> Sun, Mar 13, 2016 at 02:56:25AM CET, [email protected] wrote:
>>>>>> From: Roopa Prabhu
>>>>>>
>>>>>> This patch adds a new RTM_GETSTATS message to query link stats via
>>>>>> netlink
>>
On 3/15/16, 12:52 AM, Jiri Pirko wrote:
> Tue, Mar 15, 2016 at 08:38:51AM CET, [email protected] wrote:
>>
[snip]
>> how does it matter if we have reached an agreement that the struct is
>> required ?.
>> unlike other messages, a filter_mask is an important and must attribute for
>> stats.
On 3/15/16, 1:20 AM, Nicolas Dichtel wrote:
> Le 15/03/2016 07:30, roopa a écrit :
>> On 3/14/16, 8:00 AM, Nicolas Dichtel wrote:
>>> Le 13/03/2016 02:56, Roopa Prabhu a écrit :
> [snip]
>>>> diff --git a/include/uapi/linux/rtnetlink.h
>>>> b/incl
On 4/7/16, 6:41 PM, David Miller wrote:
> While auditing something unrelated, I noticed that this function seems
> to potentially dev_put() on an error pointer.
>
> I guess the problem comes from the fact that there are two methods
> by which the device pointer is obtained.
>
> First, inet{,6}_fib_
On 4/9/16, 7:30 AM, Jamal Hadi Salim wrote:
>
> Thanks for doing the work Roopa and I apologize for late comments
> below:
>
> On 16-04-09 02:38 AM, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>
>> This patch also allows for af family stats (an example af sta
On 4/10/16, 1:16 AM, Thomas Graf wrote:
> On 04/08/16 at 11:38pm, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> This patch adds a new RTM_GETSTATS message to query link stats via netlink
>> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK
>
On 4/10/16, 6:48 AM, Jamal Hadi Salim wrote:
> On 16-04-09 02:00 PM, roopa wrote:
>
>> This EXTENDED_HW_STATS is for ethtool like extended hw stats. This is
>> keeping in
>> mind that we want to also move ethtool to netlink in the future and with
>> switchdev
>&g
On 4/10/16, 11:28 AM, roopa wrote:
> On 4/10/16, 1:16 AM, Thomas Graf wrote:
[snip]
>>
>> This currently ties everything to a net_device with a selector to
>> include certain bits of that net_device. How about we take it half a
>> step further and allow for non net_d
On 4/13/16, 9:19 PM, David Miller wrote:
> From: Roopa Prabhu
> Date: Fri, 8 Apr 2016 23:38:11 -0700
>
>> This patch adds a new RTM_GETSTATS message to query link stats via netlink
>> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK
>> returns a l
On 4/13/16, 5:11 AM, Jamal Hadi Salim wrote:
> On 16-04-12 09:21 AM, Thomas Graf wrote:
>> On 04/11/16 at 08:53pm, roopa wrote:
>>> Top level stats attributes can be netdev or global attributes: We can
>>> include string "LINK" in
>>> the names of all
On 4/16/16, 12:49 AM, Thomas Graf wrote:
> On 04/15/16 at 08:28pm, Roopa Prabhu wrote:
>> +static u16 rtnl_stats_calcit(struct sk_buff *skb, struct nlmsghdr *nlh)
>> +{
>> +struct net *net = sock_net(skb->sk);
>> +struct net_device *dev;
>> +u16 min_
On 4/18/16, 9:28 AM, David Miller wrote:
> From: Roopa Prabhu
> Date: Sun, 17 Apr 2016 22:35:35 -0700
>
>> This patch adds a new RTM_GETSTATS message to query link stats via netlink
>> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK
>> returns a l
On 4/18/16, 5:57 PM, David Miller wrote:
> From: Eric Dumazet
> Date: Mon, 18 Apr 2016 14:35:56 -0700
>
>> On Mon, 2016-04-18 at 14:10 -0700, Roopa Prabhu wrote:
>>
>>> + if (filter_mask & IFLA_STATS_FILTER_BIT(IFLA_STATS_LINK_64)) {
>>&g
etdevs
would benefit from a native 'ip link' way to configure port splitting. This
will be useful for nic drivers too.
thanks,
Roopa
On 2/23/16, 1:26 AM, Rosen, Rami wrote:
> Hi,
>
> + if (!dev)
> + return -ENODEV;
> +
> + nskb = nlmsg_new(if_nlmsg_stats_size(dev), GFP_KERNEL);
> + if (!nskb)
> + return -ENOBUFS;
> +
> + err = rtnl_fill_statsinfo(nskb, dev, RTM_NEWSTATS,
> +
On 2/24/16, 1:40 PM, David Miller wrote:
> From: Roopa Prabhu
> Date: Mon, 22 Feb 2016 22:01:33 -0800
>
>> From: Roopa Prabhu
>>
>> This patch adds a new RTM_GETSTATS message to query link stats via netlink
>> from the kernel. RTM_NEWLINK also dumps stats tod
On 2/25/16, 8:26 AM, David Miller wrote:
> From: roopa
> Date: Wed, 24 Feb 2016 21:25:50 -0800
>
>> I did go back and forth on the attribute vs mask.
>> cosmetic but, i guess i did not feel good about having to redefine every
>> attribute again
>> for the bitm
-by: David Ahern
Acked-by: Roopa Prabhu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/2/15, 10:18 AM, Roland Dreier wrote:
> On Tue, Sep 22, 2015 at 9:40 PM, Roopa Prabhu
> wrote:
>> + err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid,
>> + cb->nlh
On 10/6/15, 8:29 AM, kbuild test robot wrote:
> Hi Roopa,
>
> [auto build test WARNING on next-20151006 -- if it's inappropriate base,
> please ignore]
>
> config: sh-titan_defconfig (attached as .config)
> reproduce:
> wget
> https://git.kernel.o
On 10/6/15, 12:44 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> From: Roopa Prabhu
>>
>> This patch adds support for MPLS multipath routes.
>>
>> Includes following changes to support multipath:
>> - splits struct mpls_route into 'stru
On 10/6/15, 1:11 PM, Eric W. Biederman wrote:
> [email protected] (Eric W. Biederman) writes:
>
>> Roopa Prabhu writes:
>>
>>> From: Roopa Prabhu
>>>
>>> This patch adds support for MPLS multipath routes.
>>>
>>> Includes followi
goto nla_put_failure;
> @@ -785,7 +786,7 @@ static int fdb_add_entry(struct net_bridge_port *source,
> const __u8 *addr,
> }
> }
>
> - if (fdb_to_nud(fdb) != state) {
> + if (fdb_to_nud(br, fdb) != state) {
>
> Hi Roopa,
>
> Are
On 10/11/15, 1:41 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> From: Roopa Prabhu
>>
>> This patch adds support for MPLS multipath routes.
>>
>> Includes following changes to support multipath:
>> - splits struct mpls_route into 'stru
On 10/11/15, 12:43 PM, Eric W. Biederman wrote:
> Roopa Prabhu writes:
>
>> From: Robert Shearman
>>
>> Change the selection of a multipath route to use a flow-based
>> hash. This more suitable for traffic sensitive to reordering within a
>> flow (e.g. TCP
On 6/2/15, 2:13 PM, Eric W. Biederman wrote:
So I just stopped and looked at what is happening. When you originally
reported this you said (or at least I understood) that rtm_scope was not
being set in iproute. I assumed that meant it was not being touched
and it was taking a default value of z
On 6/2/15, 12:01 PM, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 9:58 AM, roopa wrote:
On 6/2/15, 7:30 AM, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote:
On 06/02/15 03:10, Scott Feldman wrote:
Actually, we're now consistent with bridge man page which
On 6/3/15, 8:43 AM, Toshiaki Makita wrote:
On 15/06/03 (水) 4:01, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 9:58 AM, roopa wrote:
On 6/2/15, 7:30 AM, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim
wrote:
On 06/02/15 03:10, Scott Feldman wrote:
Actually, we&#x
On 6/4/15, 8:04 AM, Toshiaki Makita wrote:
On 15/06/04 (木) 3:41, roopa wrote:
On 6/3/15, 8:43 AM, Toshiaki Makita wrote:
On 15/06/03 (水) 4:01, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 9:58 AM, roopa
wrote:
On 6/2/15, 7:30 AM, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 4:43 AM, Jamal
On 6/5/15, 2:14 AM, Thomas Graf wrote:
On 06/03/15 at 07:21am, Roopa Prabhu wrote:
From: Roopa Prabhu
This is still WIP and incomplete.
Posting it here because of the other discussions
happening around mpls ler in the context of Roberts
code and I happened to mention this implementation
need to be changed to support multipath and to make fib_info
matching work correctly.
Thanks,
Roopa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
NSPEC,
VXLAN_TUN_ID,
VXLAN_TUN_DST,
VXLAN_TUN_SRC,
VXLAN_TUN_TTL,
VXLAN_TUN_TOS,
VXLAN_TUN_SPORT,
VXLAN_TUN_DPORT,
VXLAN_TUN_FLAGS,
VXLAN_TUN_MAX,
}
Thanks,
Roopa
--
To unsubscribe from this list: send the line "unsubscribe netdev"
an set the flag on the tunnel state. And
this flag can then be used to skip the dst_output re-direction.
This change should be trivial will fix it soon.
b) make RTA_OIF optional and do a fib lookup.
keep your suggestions/feedback coming...
thanks,
Roopa
--
To unsubscribe from this list
On 6/10/15, 1:43 PM, Scott Feldman wrote:
I'm getting this dump_stack when reloading rocker driver. Did some
sysctl MPLS nodes not get cleaned up on NETDEV_UNREGISTER?
Steps to repro: load rocker (on system) with rocker device, rmmod
rocker, and then modprobe rocker. I doubt this is specific t
On 6/11/15, 5:55 AM, Robert Shearman wrote:
On 11/06/15 00:23, Scott Feldman wrote:
On Wed, Jun 10, 2015 at 2:58 PM, roopa
wrote:
On 6/10/15, 1:43 PM, Scott Feldman wrote:
I'm getting this dump_stack when reloading rocker driver. Did some
sysctl MPLS nodes not get cleaned
On 6/10/15, 12:13 AM, roopa wrote:
Robert/Thomas, All my changes are in the below repo under the 'mpls'
branch.
https://github.com/CumulusNetworks/net-next
https://github.com/CumulusNetworks/iproute2
The last iproute2 commit has a sample usage.
The commits pushed to this tree do n
iding
duplicate packets on bridged ports. There was a previous RFC from Roopa
(http://marc.info/?l=linux-netdev&m=142687073314252&w=2) to address this
problem, but didn't solve the problem of mixed ports in the bridge from
different devices; there was no way to exclude some ports f
On 6/13/15, 11:04 AM, [email protected] wrote:
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 6f5f71f..181b08f 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1444,6 +1444,8 @@ enum netdev_priv_flags {
*
*@xps_maps: XXX: need com
iding
duplicate packets on bridged ports. There was a previous RFC from Roopa
(http://marc.info/?l=linux-netdev&m=142687073314252&w=2) to address this
problem, but didn't solve the problem of mixed ports in the bridge from
different devices; there was no way to exclude some ports f
ed
key. Typically, the driver would use device switch ID for key, and maybe
additional fields in key for grouped ports such as bridge ifindex. The key
can be of arbitrary length.
The generator uses a global hash table to store fwd_marks hashed by key.
Signed-off-by: Scott Feldman
Acked-by: Roopa
On 6/16/15, 9:11 AM, Roopa Prabhu wrote:
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is already part of new
route replace notifications today)
This he
On 6/17/15, 12:50 AM, Scott Feldman wrote:
On Tue, Jun 16, 2015 at 9:11 AM, Roopa Prabhu wrote:
[snip]
@@ -1203,6 +1204,8 @@ int fib_table_insert(struct fib_table *tb, struct
fib_config *cfg)
if (!(cfg->fc_nlflags & NLM_F_APPEND))
fa = f
on't really need
the OR operator in this case.
ack,
I would prefer keeping my initial patch which was pretty non-intrusive.
thanks,
Roopa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/17/15, 10:31 AM, Alexander Duyck wrote:
I'd say go with something closer to the original patch, but flip the
logic like you have here, and lose the "|=" in favor of an "=" since
you are either sending a message with 0 or NLM_F_APPEND.
Anyway that is just my $.02.
agreed,
thanks alex,
On 6/17/15, 11:30 AM, Scott Feldman wrote:
On Wed, Jun 17, 2015 at 11:07 AM, Roopa Prabhu
wrote:
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is alre
On 6/18/15, 11:59 PM, Julian Anastasov wrote:
Hello,
On Thu, 18 Jun 2015, Roopa Prabhu wrote:
@@ -366,6 +371,7 @@ static inline size_t fib_nlmsg_size(struct fib_info *fi)
payload += nla_total_size((RTAX_MAX * nla_total_size(4)));
if (fi->fib_
information with routes (following suggestion
from Eric Biederman).
Looks promising, thanks for posting this series Roopa!
The first patch introduces an infrastructure to support light weight
tunnels
that dont have netdevices. The infrastructure allows tunnel drivers
to register handlers to
On 6/19/15, 7:43 AM, Robert Shearman wrote:
diff --git a/include/linux/lwtunnel.h b/include/linux/lwtunnel.h
new file mode 100644
+/* lw tunnel state flags */
+#define LWTUNNEL_STATE_OUTPUT_REDIRECT 0x1
+
+#define lwtunnel_output_redirect(lwtstate) (lwtstate && \
+(lwtstate->flags
On 6/19/15, 7:55 AM, Robert Shearman wrote:
On 19/06/15 15:19, roopa wrote:
On 6/18/15, 11:59 PM, Julian Anastasov wrote:
Some other places may need changes:
- nh_comp: there is logic that decides if same fib_info
is reused from many fib nodes. There should be check
if NH matches by
On 6/19/15, 8:19 AM, Robert Shearman wrote:
On 19/06/15 05:49, Roopa Prabhu wrote:
From: Roopa Prabhu
Introduces two netlink attributes RTA_ENCAP_TYPE and
RTA_ENCAP to support attaching encap information to ipv4 routes.
Surely RTA_ENCAP_TYPE should be part of RTA_ENCAP, since the type
On 6/19/15, 10:25 AM, Robert Shearman wrote:
n 19/06/15 16:14, roopa wrote:
Today lwtunnel_skb_lwstate is called from lwtunnel_output which is only
called from ipv4 code.
And my ipv6 variant code was supposed to have a 6 suffix. something like
lwtunnel_output6.
Or to be more explicit i will
On 6/19/15, 10:17 AM, Robert Shearman wrote:
No need for that - use the example of how RTA_MULTIPATH is used for
ipv4/ipv6:
+--+
| RTA_MULTIPATH|
+--+
| +--+ |
| | struct rtnexthop | |
| +--+ |
| | RTA_GATEWAY, et
On 6/19/15, 11:39 AM, Robert Shearman wrote:
On 19/06/15 19:34, roopa wrote:
On 6/19/15, 10:25 AM, Robert Shearman wrote:
n 19/06/15 16:14, roopa wrote:
In the netdevice case, this output function is not called atall. It
should just follow the existing netdevice the route is pointing to
IC just for the mpls case or if having a netdevice
makes it any easier.
Thanks,
Roopa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
On 6/19/15, 9:06 AM, Robert Shearman wrote:
+
+/* Push the new labels */
+hdr = mpls_hdr(skb);
+bos = true;
+for (i = tun_encap_info->labels - 1; i >= 0; i--) {
+hdr[i] = mpls_entry_encode(tun_encap_info->label[i],
+ dec.ttl, 0, bos);
dec is never i
On 6/20/15, 9:38 AM, Nikolay Aleksandrov wrote:
<<>>
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
new file mode 100644
index 000..29c7802
--- /dev/null
+++ b/net/core/lwtunnel.c
@@ -0,0 +1,162 @@
+/*
+ * lwtunnelInfrastructure for light weight tunnels like mpls
+ *
+ *
+ *
1 - 100 of 1003 matches
Mail list logo
