[no subject]

We currently have openings for real estate investments, project financing, early startup ventures, existing ventures, credit/loan facilities, and JV equity participation. To learn more about us and what we do, email us today for more concrete information. Joe Orte. INVESTMENT MANAGER DCE Group

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

On 2020-06-28 19:09, Pkshih wrote: On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: Use 'rtlwifi:' as subject title prefix is enough, likes   rtlwifi: Use const in swing_table declarations We disagree. I like knowing what content is changed via patch subject lines as there are

[PATCH] [3/2many] MAINTAINERS - 3C359 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 0d7f856..19d0c9e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -97,6 +97,7 @@ L:netdev@vger.kernel.org L: [EMAIL PROTECTED] W: http://www.linuxtr.

[PATCH] [3/2many] MAINTAINERS - 3C359 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 0d7f856..f74f7d5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -94,9 +94,9 @@ F: Files and directories with wildcard patterns. P: Mike Phillips M:

[PATCH] [4/2many] MAINTAINERS - 3C505 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index f74f7d5..3fbc13a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -103,6 +103,7 @@ P: Philip Blundell M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [5/2many] MAINTAINERS - 3CR990 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 3fbc13a..30f8ef5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -110,6 +110,7 @@ P: David Dillow M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [12/2many] MAINTAINERS - 8169 10/100/1000 GIGABIT ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index ac5ba41..2fc85df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -160,6 +160,7 @@ P: Francois Romieu M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [13/2many] MAINTAINERS - 8390 NETWORK DRIVERS [WD80x3/SMC-ELITE, SMC-ULTRA, NE2000, 3C503, etc.]

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 2fc85df..f365b2e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -172,6 +172,8 @@ P: Paul Gortmaker M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 90c1b81..ac2226b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -697,6 +697,7 @@ ARPD SUPPORT P: Jonathan Layes L: netdev@vger.kernel.org S: Main

[PATCH] [112/2many] MAINTAINERS - BROADCOM B44 10/100 ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index a21ccf1..9be0816 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1097,6 +1097,7 @@ P:Gary Zambrano M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [114/2many] MAINTAINERS - BROADCOM TG3 GIGABIT ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 976e6d0..0ee8069 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -,6 +,7 @@ P:Michael Chan M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [113/2many] MAINTAINERS - BROADCOM BNX2 GIGABIT ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 9be0816..976e6d0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1104,6 +1104,7 @@ P:Michael Chan M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [125/2many] MAINTAINERS - CIRRUS LOGIC EP93XX ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index e5853e8..8b28143 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1216,6 +1216,7 @@ P:Lennert Buytenhek M: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [157/2many] MAINTAINERS - DAVICOM FAST ETHERNET (DMFE) NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index bd0fa0e..60bda8d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1534,6 +1534,8 @@ P:Tobias Ringstrom M: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [164/2many] MAINTAINERS - DSCC4 DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 48a734c..3d75c15 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1600,6 +1600,7 @@ P:Francois Romieu M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [184/2many] MAINTAINERS - ETHEREXPRESS-16 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 6fe987d..27eb5be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1774,6 +1774,7 @@ P:Philip Blundell M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [193/2many] MAINTAINERS - FREESCALE SOC FS_ENET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index e06f478..2ef0ec4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1859,6 +1859,8 @@ M:[EMAIL PROTECTED] L: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [195/2many] MAINTAINERS - FREESCALE QUICC ENGINE UCC ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 944316a..35f1636 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1876,6 +1876,7 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org L: [EMAIL PRO

[PATCH] [200/2many] MAINTAINERS - FRAME RELAY DLCI/FRAD (Sangoma drivers too)

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 1e7e562..a6a9366 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1921,6 +1921,8 @@ P:Mike McLagan M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [255/2many] MAINTAINERS - INTEL IXP2000 ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index dccbaba..d5e1d3f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2423,6 +2423,7 @@ P:Lennert Buytenhek M: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [265/2many] MAINTAINERS - IPX NETWORK LAYER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index c1a9131..b97c776 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2533,6 +2533,9 @@ P:Arnaldo Carvalho de Melo M: [EMAIL PROTECTED] L:

[PATCH] [308/2many] MAINTAINERS - MACVLAN DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 07fb80f..b4d6651 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2966,6 +2966,8 @@ P:Patrick McHardy M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [310/2many] MAINTAINERS - MARVELL MV643XX ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 68b22f3..ce9418a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2990,6 +2990,8 @@ P:Manish Lachwani M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [335/2many] MAINTAINERS - NETLABEL

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index bc571b8..d05ffcd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3213,6 +3213,9 @@ M:[EMAIL PROTECTED] W: http://netlabel.sf.net L:

[PATCH] [339/2many] MAINTAINERS - NETWORKING [GENERAL]

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index b67dda3..1ddb242 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3251,6 +3251,8 @@ M:netdev@vger.kernel.org L: netdev@vger.kernel.org W: http:/

[PATCH] [338/2many] MAINTAINERS - NETWORK DEVICE DRIVERS

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d9e9813..b67dda3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3243,6 +3243,7 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org T: git kern

[PATCH] [342/2many] MAINTAINERS - NETXEN (1/10) GbE SUPPORT

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index fd59b3d..dbfdb75 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3289,6 +3289,7 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org W:

[PATCH] [343/2many] MAINTAINERS - IPVS

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index dbfdb75..a8fb231 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3300,6 +3300,8 @@ P:Julian Anastasov M: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [353/2many] MAINTAINERS - OLYMPIC NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index ab954f1..d2c6850 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3404,6 +3404,8 @@ L:netdev@vger.kernel.org L: [EMAIL PROTECTED] W:

[PATCH] [345/2many] MAINTAINERS - NI5010 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 1f81c05..35afb38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3322,6 +3322,7 @@ P:Andreas Mohr M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [361/2many] MAINTAINERS - PA SEMI ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index f374fa8..c488769 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3470,6 +3470,7 @@ P:Olof Johansson M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index f6b84d2..7f5b7c2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3599,6 +3599,7 @@ P:Don Fry M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [340/2many] MAINTAINERS - NETWORKING [IPv4/IPv6]

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 1ddb242..91cdf28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3270,6 +3270,9 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org T: git kern

[PATCH] [391/2many] MAINTAINERS - PS3 NETWORK SUPPORT

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 19f2a5f..4fe48a0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3738,6 +3738,7 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org L: [EMAIL PRO

[PATCH] [381/2many] MAINTAINERS - POWERPC 4xx EMAC DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 0d30368..f526cf5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3659,6 +3659,7 @@ W:http://kernel.ebshome.net/emac/ L: [EMAIL PROTECTED] L:

[PATCH] [350/2many] MAINTAINERS - NETERION (S2IO) Xframe 10GbE DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 6e78725..9e9775a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3373,6 +3373,8 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org W:

[PATCH] [432/2many] MAINTAINERS - SIS 190 ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 71be2f5..38f1b0d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4119,6 +4119,7 @@ P:Francois Romieu M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [445/2many] MAINTAINERS - SONIC NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index e9e7a00..6175c77 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4233,6 +4233,7 @@ P:Thomas Bogendoerfer M: [EMAIL PROTECTED] L:

[PATCH] [434/2many] MAINTAINERS - SIS 900/7016 FAST ETHERNET DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 228e077..b74e343 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4135,6 +4135,7 @@ M:[EMAIL PROTECTED] W: http://www.brownhat.org/sis900.h

[PATCH] [455/2many] MAINTAINERS - SKGE, SKY2 10/100/1000 GIGABIT ETHERNET DRIVERS

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index a40c7ed..cb9f9da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4348,6 +4348,8 @@ P:Stephen Hemminger M: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [459/2many] MAINTAINERS - SPIDERNET NETWORK DRIVER for CELL

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index b616562..fa8fb1c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4377,6 +4377,9 @@ P:Linas Vepstas M: [EMAIL PROTECTED] L: netdev@vger.kernel.

[PATCH] [478/2many] MAINTAINERS - TOKEN-RING NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index fda287c..b5dc1ac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4539,6 +4539,8 @@ L:netdev@vger.kernel.org L: [EMAIL PROTECTED] W:

[PATCH] [469/2many] MAINTAINERS - TC CLASSIFIER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index f00640b..fc0589f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4457,6 +4457,9 @@ P:Jamal Hadi Salim M: [EMAIL PROTECTED] L: netdev@vger.kern

[PATCH] [492/2many] MAINTAINERS - USB DAVICOM DM9601 DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 8f496de..b7498bf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4662,6 +4662,7 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org W: http://www

[PATCH] [504/2many] MAINTAINERS - USB PEGASUS DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d822865..fc87fa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4764,6 +4764,7 @@ L:[EMAIL PROTECTED] L: netdev@vger.kernel.org W: http://pe

[PATCH] [506/2many] MAINTAINERS - USB RTL8150 DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 02bb359..25df49f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4781,6 +4781,7 @@ L:[EMAIL PROTECTED] L: netdev@vger.kernel.org W: http://pe

[PATCH] [520/2many] MAINTAINERS - USB USBNET DRIVER FRAMEWORK

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index c670797..4dba8ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4916,6 +4916,7 @@ M:[EMAIL PROTECTED] L: netdev@vger.kernel.org W: http://www

[PATCH] [530/2many] MAINTAINERS - VIA VELOCITY NETWORK DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 392d697..be3d826 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5002,6 +5002,7 @@ P:Francois Romieu M: [EMAIL PROTECTED] L: netdev@vger.kernel.

Re: [2.6 patch] fix ipvs compilation

On 1/5/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: > I don't know which change broke it, but I'm getting the following > compile error in Linus' tree: > > <-- snip --> > > ... > CC net/ipv4/ipvs/ip_vs_sched.o > net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': > net/ipv4/ipv

Re: [net-next 01/13] iavf: Use printf instead of gnu_printf for iavf_debug_d

On Fri, 2019-05-31 at 01:15 -0700, Jeff Kirsher wrote: > From: Nathan Chancellor > We can convert from gnu_printf to printf without any side effects [] > diff --git a/drivers/net/ethernet/intel/iavf/iavf_osdep.h > b/drivers/net/ethernet/intel/iavf/iavf_osdep.h [] > @@ -46,7 +46,7 @@ struct iavf_v

Re: [PATCH] rtlwifi: remove redundant assignment to variable k

On Fri, 2019-05-31 at 12:29 -0500, Larry Finger wrote: > On 5/31/19 9:14 AM, Colin King wrote: > > From: Colin Ian King > > > > The assignment of 0 to variable k is never read once we break out of > > the loop, so the assignment is redundant and can be removed. > > > > Addresses-Coverity: ("Unus

Re: [PATCH RFC iproute2-next v4] tc: add support for action act_ctinfo

On Mon, 2019-06-03 at 14:50 +0100, Kevin Darbyshire-Bryant wrote: > ctinfo is an action restoring data stored in conntrack marks to various > fields. At present it has two independent modes of operation, > restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack > marks into packet s

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

On Thu, 2019-08-01 at 17:03 +0800, Hangbin Liu wrote: > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on a > multicast group, the following error message flushes our log file > > 8507[ 901.478251] ibmveth 3003 env3: h_multicast_ctrl rc=4 when > adding an entry

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

On Thu, 2019-08-01 at 22:10 +0800, Hangbin Liu wrote: > On Thu, Aug 01, 2019 at 03:28:43AM -0700, Joe Perches wrote: > > Perhaps add the netdev__ratelimited variants and use that instead > > > > Somthing like: > > Yes, that looks better. Do you mind if I take your cod

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

On Thu, 2019-08-01 at 12:51 -0400, David Miller wrote: > From: Hangbin Liu > Date: Thu, 1 Aug 2019 17:03:47 +0800 > > > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on > > a > > multicast group, the following error message flushes our log file > > > > 8507[ 901

Re: [PATCH net] ibmveth: Convert multicast list size for little-endian systems

On Mon, 2019-08-12 at 12:43 -0500, Thomas Falcon wrote: > The ibm,mac-address-filters property defines the maximum number of > addresses the hypervisor's multicast filter list can support. It is > encoded as a big-endian integer in the OF device tree, but the virtual > ethernet driver does not conv

Re: [Intel-wired-lan] [net-next] net: iavf: Use the ARRAY_SIZE macro for aq_to_posix

On Thu, 2021-01-14 at 09:57 +, Jankowski, Konrad0 wrote: > > -Original Message- > > From: Intel-wired-lan On Behalf Of Wei > > Xu [] > > Use the ARRAY_SIZE macro to calculate the size of an array. > > This code was detected with the help of Coccinelle. [] > > diff --git a/drivers/net/

Re: [PATCH] arcnet: fix macro name when DEBUG is defined

w this hasn't been tested or compiled in 5+ years... commit 0fec65130b9f11a73d74f47025491f97f82ba070 Author: Joe Perches Date: Tue May 5 10:06:06 2015 -0700 Acked-by: Joe Perches > Signed-off-by: Tom Rix > --- >  drivers/net/arcnet/com20020_cs.c | 2 +- >

Re: [PATCH 0/3] dwarves,libbpf: Add support to use optional extended section index table

le here: http://people.redhat.com/~jolawren/coredump.gz If it's easier to get you setup on a repro system, let me know and I can do that. Thanks, -- Joe

[PATCH] checkpatch: Add kmalloc_array_node to unnecessary OOM message check

commit 5799b255c491 ("include/linux/slab.h: add kmalloc_array_node() and kcalloc_node()") was added in 2017. Update the unnecessary OOM message test to include it. Signed-off-by: Joe Perches Reported-by: Jakub Kicinski --- Maybe not worth fixing, but no real effort to fix either.

Re: [PATCH wireless -next] cw1200: txrx: convert comma to semicolon

On Thu, 2020-12-10 at 18:50 +, Kalle Valo wrote: > Zheng Yongjun wrote: > > > Replace a comma between expression statements by a semicolon. > > > > Signed-off-by: Zheng Yongjun > > Patch applied to wireless-drivers-next.git, thanks. > > c42d492c672a cw1200: txrx: convert comma to semicolo

Re: [PATCH] net/mlx4: Use true,false for bool variable

On Fri, 2020-12-11 at 11:05 +0100, Vasyl Gomonovych wrote: > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable [] > diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c > b/drivers/net/ethernet/mellanox/mlx4/main

Re: [PATCH] netfilter: conntrack: fix -Wformat

On Sun, 2020-12-13 at 11:21 -0800, Tom Rix wrote: > On 12/2/20 2:34 PM, Nick Desaulniers wrote: > > On Tue, Nov 10, 2020 at 2:04 PM Joe Perches wrote: > > > On Tue, 2020-11-10 at 14:00 -0800, Nick Desaulniers wrote: > > > > > > > Yeah, we could go through a

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote: > > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote: > > > It is fix for semantic patch warning available in > > > scripts/coccinelle/misc/boolinit.cocci > > > Fix e

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote: > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > > I prefer revisions to single patches (as opposed to large patch series) > > in the same thread. > > It depends which side you are in that game. From

Re: [PATCH] atm: horizon: remove h from printk format specifier

On Tue, 2020-12-15 at 06:24 -0800, t...@redhat.com wrote: > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. > > Signed-off-by: Tom Rix > --- >  drivers/atm/horizon.c | 6 +++--- Chas? Madge has been out of busine

Re: [PATCH net] MAINTAINERS: remove names from mailing list maintainers

On 2020-12-19 10:55, Jakub Kicinski wrote: When searching for inactive maintainers it's useful to filter out mailing list addresses. Such "maintainers" will obviously never feature in a "From:" line of an email or a review tag. Since "L:" entries only provide the address of a mailing list withou

Re: [PATCH net] MAINTAINERS: remove names from mailing list maintainers

On Wed, 2020-12-23 at 02:50 +, patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (refs/heads/master): > > On Sat, 19 Dec 2020 10:55:38 -0800 you wrote: > > When searching for inactive maintainers it's useful to filter > > out mailing list addresse

Re: [PATCH] [v9] wireless: Initial driver submission for pureLiFi STA devices

On Thu, 2020-12-03 at 10:39 +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. The below is a trivial readability possible enhancement and should not hinder this patch being applied. > diff --git a/drivers/net/wireless/purelifi/

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Fri, 2020-12-04 at 10:49 -0500, Sasha Levin wrote: > On Fri, Dec 04, 2020 at 09:27:28AM +0100, Paolo Bonzini wrote: > > On 01/12/20 00:59, Sasha Levin wrote: > > > > > > It's quite easy to NAK a patch too, just reply saying "no" and it'll be > > > dropped (just like this patch was dropped right

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

On Fri, 2020-12-04 at 16:09 -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT c

Re: [PATCH] net/core: use xx_zalloc instead xx_alloc and memset

On Wed, 2020-11-18 at 16:15 +0800, Tian Tao wrote: > use kmem_cache_zalloc instead kmem_cache_alloc and memset. [] > diff --git a/net/core/skbuff.c b/net/core/skbuff.c [] > @@ -313,12 +313,10 @@ struct sk_buff *__build_skb(void *data, unsigned int > frag_size) >  { >   struct sk_buff *skb; >  

Re: XDP maintainer match (Was [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring)

gt; catch drivers containing XDP related bits. > > Previously Joe Perches suggested this pattern match, > which I don't fully understand... could you explain Joe? > >   (?:\b|_)xdp(?:\b|_) This regex matches only: xdp xdp_ _xdp_ _xdp > For the filen

Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries

is also > > > updated in this patch. > > > > > > Suggested-by: Jakub Kicinski > > > Signed-off-by: Jesper Dangaard Brouer > > > > Ah! Sorry, I missed that you sent this before replying to Joe. > > > > Would you mind respining with his regex? &

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

On Thu, 2020-11-19 at 21:21 -0800, Jakub Kicinski wrote: > We do have our own comment style rule in networking since the beginning > of time, and reverse xmas tree, so it's not completely crazy. reverse xmas tree is completely crazy. But I posted a patch to checkpatch to suggest it for net/ and d

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Fri, 2020-11-20 at 12:21 -0600, Gustavo A. R. Silva wrote: > Hi all, > > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto

Re: [RFC] MAINTAINERS tag for cleanup robot

D: fpga: dfl: I'm all for it. Good luck with the effort. It's not completely trivial. >From a decade ago: https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/ (and that thread started with extra semicolon patches too) > Continuing with clean

Re: [RFC] MAINTAINERS tag for cleanup robot

On Sat, 2020-11-21 at 09:18 -0800, James Bottomley wrote: > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > > A difficult part of automating commits is composing the subsystem > > preamble in the commit log. For the ongoing effort of a fixer > > producing one or two fixes a release the

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

On Sat, 2020-11-21 at 14:17 +0100, Marc Kleine-Budde wrote: > On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > >

Re: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 00:04 +0100, Marc Kleine-Budde wrote: > On 11/21/20 8:50 PM, Joe Perches wrote: > > > What about moving the default to the end if the case, which is more > > > common anyways: > > > > > > diff --git a/drivers/net/can/usb/peak_usb/pcan_

Re: [RFC] MAINTAINERS tag for cleanup robot

On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote: > On 11/21/20 9:10 AM, Joe Perches wrote: > > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > > > A difficult part of automating commits is composing the subsystem > > > preamble in the commit log. For th

Re: [RFC] MAINTAINERS tag for cleanup robot

On Sun, 2020-11-22 at 08:49 -0800, James Bottomley wrote: > We can enforce sysfs_emit going forwards > using tools like checkpatch It's not really possible for checkpatch to find or warn about sysfs uses of sprintf. checkpatch is really just a trivial line-by-line parser and it has no concept of c

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > Please tell me > our reward for all this effort isn't a single missing error print. There were quite literally dozens of logical defects found by the fallthrough additions. Very few were logging only.

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > > Please tell me our reward for all this effort isn't a single > > > missing error

Re: [RFC] MAINTAINERS tag for cleanup robot

On Mon, 2020-11-23 at 09:33 +1100, Finn Thain wrote: > On Sun, 22 Nov 2020, Joe Perches wrote: > > But provably correct conversions IMO _should_ be done and IMO churn > > considerations should generally have less importance. [] > Moreover, the patch review workload for skill

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Mon, 2020-11-23 at 07:58 -0800, James Bottomley wrote: > We're also complaining about the inability to recruit maintainers: > > https://www.theregister.com/2020/06/30/hard_to_find_linux_maintainers_says_torvalds/ > > And burn out: > > http://antirez.com/news/129 https://www.wired.com/story/o

Re: [PATCH net-next 15/17] rxrpc: Organise connection security to use a union

On Mon, 2020-11-23 at 20:11 +, David Howells wrote: > Organise the security information in the rxrpc_connection struct to use a > union to allow for different data for different security classes. Is there a known future purpose to this? > diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-in

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote: > it's not for me to prove that such patches don't affect code > generation. That's for the patch author and (unfortunately) for reviewers. Ideally, that proof would be provided by the compilation system itself and not patch authors nor reviewe

Re: Subject: [RFC] clang tooling cleanups

On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > > The clang warning -Wextra-semi-stmt produces about 10k w

Re: [PATCH] netfilter: conntrack: fix -Wformat

On Tue, 2020-11-10 at 14:00 -0800, Nick Desaulniers wrote: > Yeah, we could go through and remove %h and %hh to solve this, too, right? Yup. I think one of the checkpatch improvement mentees is adding some suggestion and I hope an automated fix mechanism for that. https://lore.kernel.org/lkml/5

Re: [PATCH] [v7] wireless: Initial driver submission for pureLiFi STA devices

mmonly this changelog would go below the --- separator line. > > Changes v6->v7: > - Magic numbers removed and used IEEE80211 macors > - usb.c is split into two files firmware.c and dbgfs.c > - Other code style and timer function fixes (mod_timer) > Changes v5->v6: > - C

Re: [PATCH][next] mwifiex: Fix fall-through warnings for Clang

On Tue, 2020-11-17 at 10:09 -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. Thanks Gustavo. I think this is better sty

Re: [PATCH] amd-xgbe: remove h from printk format specifier

On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already

Re: [PATCH] amd-xgbe: remove h from printk format specifier

On Wed, 2020-12-23 at 12:33 -0800, Tom Rix wrote: > On 12/23/20 12:14 PM, Joe Perches wrote: > > On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This change fixes the checkpatch warning described in this commit >

Re: [PATCH] nfp: remove h from printk format specifier

On Thu, 2020-12-24 at 14:14 -0800, Tom Rix wrote: > On 12/24/20 12:21 PM, Simon Horman wrote: > > On Wed, Dec 23, 2020 at 12:20:53PM -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This change fixes the checkpatch warning described in this commit > > > commit cbacb5ab0aa0 ("docs: pr

Re: [PATCH] nfp: remove h from printk format specifier

On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: > On 12/24/20 2:39 PM, Joe Perches wrote: [] > > Kernel code doesn't use a signed char or short with %hx or %hu very often > > but in case you didn't already know, any signed char/short emitted with > > anything l

Re: [PATCH] nfp: remove h from printk format specifier

On Fri, 2020-12-25 at 14:13 -0800, Tom Rix wrote: > On 12/25/20 9:06 AM, Joe Perches wrote: > > On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: > > > On 12/24/20 2:39 PM, Joe Perches wrote: > > [] > > > > Kernel code doesn't use a signed char or

[PATCH] ethernet: Remove invalid trailers after %pI4

Alphanumeric characters after vsprintf pointer extension %pI4 are not valid and are not emitted. Remove the invalid characters from the %pI4 uses. Signed-off-by: Joe Perches --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 6 +++--- drivers/net/ethernet/intel/i40e/i40e_main.c

Re: [PATCH] ethernet: Remove invalid trailers after %pI4

On Sat, 2020-12-26 at 09:10 -0800, Joe Perches wrote: > Alphanumeric characters after vsprintf pointer extension %pI4 are > not valid and are not emitted. > > Remove the invalid characters from the %pI4 uses. self-nak. I believe I misunderstood the format specifier.

Re: [PATCH net-next] net/mlx5: Use kzalloc for allocating only one thing

On Tue, 2020-12-29 at 21:53 +0800, Zheng Yongjun wrote: > Use kzalloc rather than kcalloc(1,...) [] > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c > b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c [] > @@ -1782,7 +1782,7 @@ static int dr_action_create_mo

  1   2   3   4   5   6   7   8   9   10   >