Re: "ss -p" segfaults (updated to 4.2)

Hi Willy, It seems fine to me. You may reword the commit message at will. Thx, Jose On 2015-10-06 11:09, Willy Tarreau wrote: > Hi guys, > > I've updated Jose's patch to make it slightly simpler (eg: calloc instead > of malloc+memset), and ported it to 4.2.0 which requires it as well, and > att

Re: Segmentation fault in iproute2 ss -p (versions 4.0.0, 4.1.0 and 4.1.1)

--- iproute2-4.1.1-orig/misc/ss.c 2015-07-06 22:57:34.0 +0100 +++ iproute2-4.1.1/misc/ss.c2015-07-19 12:16:25.0 +0100 @@ -428,9 +428,12 @@ while (cnt != USER_ENT_HASH_SIZE) { p = user_ent_hash[cnt]; while (p) { -

"ss -p" segfaults

Please find attached one simple patch for the code 4.1.0/4.1.1. Essentially all that is needed to get rid of this issue is the addition of: memset(u, 0, sizeof(*u)); after: if (!(u = malloc(sizeof(*u break; During the analysis of this issue I also found some other situ

Re: Segmentation fault in iproute2 ss -p (versions 4.0.0, 4.1.0 and 4.1.1)

Patch for 4.1.1. Essentially all that is needed to get rid of this issue is the addition of: memset(u, 0, sizeof(*u)); after: if (!(u = malloc(sizeof(*u break; Also patched some other situations (strcpy and sprintf uses) that potentially produce the same results. Note:

Re: "ss -p" segfaults

Patch for 4.1.1. Essentially all that is needed to get rid of this issue is the addition of: memset(u, 0, sizeof(*u)); after: if (!(u = malloc(sizeof(*u break; Also patched some other situations (strcpy and sprintf uses) that potentially produce the same results. Sign