[PATCH 1/2] sunrpc: handle ENOMEM in rpcb_getport_async

2018-05-08 Thread bfie...@fieldses.org
From: "J. Bruce Fields" If we ignore the error we'll hit a null dereference a little later. Reported-by: syzbot+4b98281f2401ab849...@syzkaller.appspotmail.com Signed-off-by: J. Bruce Fields --- net/sunrpc/rpcb_clnt.c | 8 1 file changed, 8 insertions(+) diff --git a/net/sunrpc/rpcb_c

Re: general protection fault in encode_rpcb_string

2018-05-08 Thread bfie...@fieldses.org
From: "J. Bruce Fields" Date: Tue, 8 May 2018 11:47:03 -0400 Subject: [PATCH 2/2] sunrpc: convert unnecessary GFP_ATOMIC to GFP_NOFS It's OK to sleep here, we just don't want to recurse into the filesystem as this writeout could be waiting on this. As a next step: the documentation for GFP_NOFS

Re: general protection fault in encode_rpcb_string

2018-05-08 Thread bfie...@fieldses.org
On Tue, Apr 17, 2018 at 09:54:36PM +, Trond Myklebust wrote: > Yes, and we can probably convert it, and the other GFP_ATOMIC > allocations in the rpcbind client to use GFP_NOFS in order to improve > reliability. Chuck, I think the GFP_ATOMIC is unnecessary here as well? --b. diff --git a/net

Re: [PATCH net-next] SUNRPC: drop pointless static qualifier in xdr_get_next_encode_buffer()

2018-11-08 Thread bfie...@fieldses.org
On Thu, Nov 08, 2018 at 03:13:25AM +, Trond Myklebust wrote: > On Thu, 2018-11-08 at 02:04 +, YueHaibing wrote: > > There is no need to have the '__be32 *p' variable static since new > > value > > always be assigned before use it. Applying for 4.20 and stable, thanks! > > > > Signed-off-