tice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Stephen Rothwell
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Kees Cook
-Kees
> ---
> drivers/net/ethernet/toshiba/spider_net.c | 1 +
aller.appspot.com/x/repro.c?x=164ee6c590
>
> Reported-by: syzbot+9b64b619f10f19d19...@syzkaller.appspotmail.com
> Fixes: 4b2bd5fec007 ("proc: fix timerslack_ns CAP_SYS_NICE check when
> adjusting self")
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
--
Kees Cook
; Reported-by: Sedat Dilek
> Signed-off-by: Sami Tolvanen
Reviewed-by: Kees Cook
--
Kees Cook
On Tue, Nov 17, 2020 at 02:07:43PM -0800, Sami Tolvanen wrote:
> On Tue, Nov 17, 2020 at 1:45 PM Kees Cook wrote:
> >
> > On Tue, Nov 17, 2020 at 12:59:02PM -0800, Sami Tolvanen wrote:
> > > Instead of casting callback functions to type iw_handler, which trips
> >
ngs are supposed to warn about issues that could
> be bugs. Falling through to default: break; can hardly be a bug?!
It's certainly a place where the intent is not always clear. I think
this makes all the cases unambiguous, and doesn't impact the machine
code, since the compiler will happily optimize away any behavioral
redundancy.
--
Kees Cook
On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote:
> > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote:
> > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote:
> > > > This
On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote:
> > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote:
> > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote:
> > > > This
On Mon, Nov 23, 2020 at 05:32:51PM -0800, Nick Desaulniers wrote:
> On Sun, Nov 22, 2020 at 8:17 AM Kees Cook wrote:
> >
> > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> > > If none of the 140 patches here fix a real bug, and there is no change
>
inal series may be lower, but there
are still bugs being found from it -- we need to finish this and shut
the door on it for good.)
--
Kees Cook
K flags instead of TIF
> flags for !CONFIG_GENERIC_ENTRY. Also, add safeguards to catch this at
> compilation time.
>
> Reported-by: Naresh Kamboju
> Suggested-by: Jann Horn
> Signed-off-by: Gabriel Krisman Bertazi
Thanks for getting this fixed!
3136b93c3fb2 ("entry: Expose helpers to migrate TIF to SYSCALL_WORK flags")
Reviewed-by: Kees Cook
--
Kees Cook
-through
All switch/case blocks must end in one of:
break;
fallthrough;
continue;
goto ;
return [expression];
[3] https://cwe.mitre.org/data/definitions/484.html
--
Kees Cook
| 2 +-
> net/sched/sch_api.c| 2 +-
> net/tipc/netlink_compat.c | 2 +-
> 29 files changed, 73 insertions(+), 61 deletions(-)
>
> --
> 2.20.1
>
--
Kees Cook
ot discussed in the thread, what you had here wouldn't work
in a CFI build if the function prototype of the call site and the
function don't match. (Though I can't tell if .func() is ever called?)
i.e. .func's prototype must match tp_stub_func()'s.
--
Kees Cook
wer,
> + [IW_IOCTL_IDX(SIOCSIWGENIE)]= __cfg80211_wext_siwgenie,
> + [IW_IOCTL_IDX(SIOCSIWAUTH)] = __cfg80211_wext_siwauth,
> + [IW_IOCTL_IDX(SIOCGIWAUTH)] = __cfg80211_wext_giwauth,
> + [IW_IOCTL_IDX(SIOCSIWENCODEEXT)]= __cfg80211_wext_siwencodeext,
> + [IW_IOCTL_IDX(SIOCSIWPMKSA)]= __cfg80211_wext_siwpmksa,
> };
>
> const struct iw_handler_def cfg80211_wext_handler = {
>
> base-commit: 9c87c9f41245baa3fc4716cf39141439cf405b01
> --
> 2.29.2.299.gdc1121823c-goog
>
--
Kees Cook
"foo\0" and dst is 5 bytes long, the result will be:
> 1. "fooGG" after memcpy (G means garbage).
> 2. "foo\0\0" after memset.
>
> Signed-off-by: Francis Laniel
Looks good! (If there are future versions of this series, I think you
can drop the RFC part...)
Reviewed-by: Kees Cook
--
Kees Cook
d to take into account this
> modification.
>
> Signed-off-by: Francis Laniel
This looks correct to me. Thanks for the respin!
Reviewed-by: Kees Cook
--
Kees Cook
also be: "treewide: Rename nla_strlcpy to nla_strscpy"
But otherwise, yup, easy mechanical change.
Reviewed-by: Kees Cook
> ---
> drivers/infiniband/core/nldev.c| 10 +-
> drivers/net/can/vxcan.c| 4 ++--
> drivers/net/veth.c
On Thu, Oct 22, 2020 at 11:41:31AM +0200, Francis Laniel wrote:
> Le jeudi 22 octobre 2020, 01:49:59 CEST Kees Cook a écrit :
> > On Tue, Oct 20, 2020 at 06:47:07PM +0200,
> > laniel_fran...@privacyrequired.com
> wrote:
> > > From: Francis Laniel
> > >
ht -- this is a very narrow use-case (NLA). I think this series is
fine as-is.
--
Kees Cook
> 0) {
> /* We dropped the RTNL semaphore in order to
>* perform the module load. So, even if we
>* succeeded in loading the module we have to
Oops, I think this should be >= 0 ?
--
Kees Cook
ce_aq_move_sched_elems()
> ice: make use of DEFINE_FLEX() in ice_ddp.c
> ice: make use of DEFINE_FLEX() for struct ice_aqc_add_tx_qgrp
> ice: make use of DEFINE_FLEX() for struct ice_aqc_dis_txq_item
> ice: make use of DEFINE_FLEX() in ice_switch.c
Looks good to me! Feel free to pick up via netdev.
-Kees
--
Kees Cook
tps://github.com/KSPP/linux/issues/109
> Reported-by: kernel test robot
> Build-tested-by: kernel test robot
> Link: https://lore.kernel.org/lkml/60641d9b.2enledogsdcsoav2%25...@intel.com/
> Signed-off-by: Gustavo A. R. Silva
Thanks, this makes the code much easier for the compiler to validate
at compile time. These cross-field memcpy()s are weird. I like the
solution here.
Reviewed-by: Kees Cook
--
Kees Cook
.el = {
> .id = IW_MGMT_INFO_ELEMENT_DS_PARAMETER_SET,
> .len = 1,
> @@ -599,7 +599,7 @@ static int wl3501_mgmt_join(struct wl3501_card *this, u16
> stas)
> },
> };
>
> - memcpy(&a
mp;sig.beacon_period and &this->bss_set[i].beacon_period, because the
> address of the new struct object _req_ is used as the destination,
> instead.
>
> This helps with the ongoing efforts to globally enable -Warray-bounds
> and get us closer to being able to tighten the FORTIFY_SOURCE routines
> on memcpy().
>
> Link: https://github.com/KSPP/linux/issues/109
> Reported-by: kernel test robot
> Signed-off-by: Gustavo A. R. Silva
Awesome! Thank you for this solution.
Reviewed-by: Kees Cook
--
Kees Cook
m/KSPP/linux/issues/109
> Reported-by: kernel test robot
> Signed-off-by: Gustavo A. R. Silva
Yup!
Reviewed-by: Kees Cook
--
Kees Cook
t;Clang doesn't parse comments" issue.)
This could be a tree-wide patch and not bother you, but Greg KH has
generally advised us to send these changes broken out. Anyway, this
change still needs to land, so what would be the preferred path? I think
Gustavo could just carry it for Linus to m
On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
> On 3/10/21 2:14 PM, Kees Cook wrote:
> > On Fri, Mar 05, 2021 at 03:40:33PM +0200, Kalle Valo wrote:
> >> "Gustavo A. R. Silva" writes:
> >>
> >>> In preparation to enable -Wimplicit-f
On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote:
> On 3/10/21 2:45 PM, Kees Cook wrote:
> > On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
> >> On 3/10/21 2:14 PM, Kees Cook wrote:
> >>> Hm, this conversation looks like a miscommunicatio
BUG();
BUG() should never be used[1]. This is a recoverable situation, I think, and
should be handled as such.
-Kees
[1]
https://www.kernel.org/doc/html/latest/process/deprecated.html#bug-and-bug-on
> case SECCOMP_MODE_FILTER:
> return __seccomp_filter(this_syscall, sd, false);
> default:
> --
> 2.19.1
>
--
Kees Cook
ptimizing rmb()
https://git.kernel.org/kees/c/a381b70a1cf8
--
Kees Cook
. Here's for the refactoring:
https://github.com/KSPP/linux/issues/30
and here's for the removal:
https://github.com/KSPP/linux/issues/94
if you can added details/examples of how they should be removed, that'd
help other folks too, if they wanted to jump in. :)
-Kees
--
Kees Cook
let is doing.
>
> I'd fix that up now before everything else goes in...
As I mentioned in the other thread, I think this makes things much more
readable. It's the same thing that the timer_struct conversion did
(added a container_of wrapper) to avoid the ever-repeating use of
typeof(), long lines, etc.
--
Kees Cook
On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
> On 8/17/20 12:29 PM, Kees Cook wrote:
> > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
> >> On 8/17/20 2:15 AM, Allen Pais wrote:
> >>> From: Allen Pais
> >>>
> >&
On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote:
> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
> > On 8/17/20 12:48 PM, Kees Cook wrote:
> > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
> > > > On 8/17/20 12:29 PM, Kees Cook w
ons.
[1]
http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com
Signed-off-by: Kees Cook
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote:
> Hi Kees,
>
> On 01-05-2018 22:01, Kees Cook wrote:
>> In the quest to remove all stack VLAs from the kernel[1], this switches
>> the "status" stack buffer to use the existing small (8) upper bound on
>> h
don't particularly
> like arbitrary limits on how many ports a switch can have, or how many
> switches a board can have.
>
> So i would prefer to not use DSA_MAX_PORTS here.
>
> You could make the bitmap part of the dsa_switch structure. This is
> allocated by dsa_switch_alloc() and is passed the number of ports.
> Doing the allocation there means you don't need to worry about it
> failing in dsa_switch_mdb_add() or dsa_switch_vlan_add().
Are dsa_switch_mdb_add() and dsa_switch_vlan_add() guaranteed to be
single-threaded?
-Kees
--
Kees Cook
Pixel Security
er required unless you have a special firmware file that
> - resides in a non-standard path. Moreover, the udev support has
> - been deprecated upstream.
> + Enabling this option forces a sysfs userspace fallback mechanism
> + to be used for all firmware requests which explicitly do not
> disable a
> + a fallback mechanism. Firmware calls which do prohibit a fallback
> + mechanism is request_firmware_direct(). This option is kept for
> + backward compatibility purposes given this precise mechanism can
> also
> + be enabled by setting the proc sysctl value to true:
> +
> + /proc/sys/kernel/firmware_config/force_sysfs_fallback
>
> If you are unsure about this, say N here.
>
> +endif # FW_LOADER
> +endmenu
> +
> config WANT_DEV_COREDUMP
> bool
> help
> --
> 2.17.0
>
-Kees
--
Kees Cook
Pixel Security
gt; As for the rename that you wanted, perhaps we can do this late in the
> merge window considering we're at rc4 now. I can prep something up for
> that later.
>
> Question, and specially rants are warmly welcomed.
I sent some typo catches, but with those fixed, please consider the
whole series:
Reviewed-by: Kees Cook
Thanks!
-Kees
--
Kees Cook
Pixel Security
On Wed, May 9, 2018 at 1:55 PM, Luis R. Rodriguez wrote:
> On Tue, May 08, 2018 at 03:42:33PM -0700, Kees Cook wrote:
>> On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez wrote:
>> > + This used to be the default firmware loading facility, and udev
>> > us
erfaces with file interfaces,
I'm cautious to add a new blob interface. Maybe just pull all the
blob-finding/loading into the interface, and just make it something
like fork_usermode_kmod(struct module *mod, struct umh_info *info) ?
-Kees
--
Kees Cook
Pixel Security
Signed-off-by: Kees Cook
---
v3:
- adjust Subject and commit log (Steffen)
- use "= { }" instead of memset() (Stefano)
- reorder variables (Stefano)
v2:
- use XFRM_MAX_DEPTH for "count" array (Steffen and Mathias).
---
net/ipv6/xfrm6_state.c | 4 ++--
1 file changed, 2 insertio
In the quest to remove all stack VLA usage from the kernel[1], this
redefines FFT_NUM_SAMPLES as a #define instead of const int, which still
triggers gcc's VLA checking pass.
[1] https://lkml.org/lkml/2018/3/7/621
Co-developed-by: Andreas Christoforou
Signed-off-by: Kees Cook
---
v3: re
89e3e
Ah! Cool, no worries. I didn't see that in linux-next yet. :)
Thanks!
-Kees
--
Kees Cook
Pixel Security
Signed-off-by: Kees Cook
---
v4:
- actually remove memset(). :)
v3:
- adjust Subject and commit log (Steffen)
- use "= { }" instead of memset() (Stefano)
v2:
- use XFRM_MAX_DEPTH for "count" array (Steffen and Mathias).
---
net/ipv6/xfrm6_state.c | 6 ++
1 file changed, 2
On Tue, Mar 20, 2018 at 4:23 PM, Linus Torvalds
wrote:
> On Sat, Mar 17, 2018 at 1:07 PM, Kees Cook wrote:
>>
>> No luck! :( gcc 4.4 refuses to play along. And, hilariously, not only
>> does it not change the complaint about __builtin_choose_expr(), it
>> also think
level controls: leave LSM wide open, make /dev/bpf owned
by "bpfadmin" and bpftool becomes setuid "bpfadmin". For fine-grained
controls, leave /dev/bpf wide open and add policy to SELinux, etc.)
With only a new CAP, you don't get the fine-grained controls. (The
"request abilities" part is the key there.)
--
Kees Cook
ing things worse.
I'm all for a "less privileged than root" API for eBPF, but I get worried
when I see "security" being treated as a binary state. Especially when
it is considered an always-failed state. :)
--
Kees Cook
ou're building a tree that includes
9dd3fcb0ab73 ("selftests/seccomp: Handle namespace failures gracefully")? I
assume it does, but I suspect something similar is happening, where the
environment is slightly different than expected and the test stalls.
Does it behave the same way under emulation (i.e. can I hope to
reproduce this myself?)
--
Kees Cook
false
> positive by adding and using __BPF_PROG_RUN() variant that does not have the
> cant_sleep(); check.
>
> Fixes: 568f196756ad ("bpf: check that BPF programs run with preemption
> disabled")
> Reported-by: syzbot+8bf19ee2aa580de7a...@syzkaller.appspotmail.com
sleep(); check.
> > >
> > > Fixes: 568f196756ad ("bpf: check that BPF programs run with preemption
> > > disabled")
> > > Reported-by: syzbot+8bf19ee2aa580de7a...@syzkaller.appspotmail.com
> > > Signed-off-by: Daniel Borkmann
> > > Acked-b
On Thu, Feb 21, 2019 at 9:45 AM Eric Sandeen wrote:
>
> Add a test node for proc_do_large_bitmap to the test_sysctl.c
> infrastructure. It's sized the same as the one existing user.
>
> Signed-off-by: Eric Sandeen
Acked-by: Kees Cook
-Kees
> ---
>
> diff --
On Thu, Feb 21, 2019 at 11:29 AM Alexei Starovoitov
wrote:
>
> On Thu, Feb 21, 2019 at 01:56:53PM +0100, Jann Horn wrote:
> > On Thu, Feb 21, 2019 at 9:53 AM Daniel Borkmann
> > wrote:
> > > On 02/21/2019 06:31 AM, Kees Cook wrote:
> > > > On Wed, Feb
never happen. (In fact, recently I even had
Tycho see if he could implement the recent seccomp user notification
stuff via eBPF.)
--
Kees Cook
used-function]
> static int proc_dointvec_minmax_bpf_stats(struct ctl_table *table, int write,
>
> The CONFIG_BPF_SYSCALL check was already handled, but the SYSCTL check
> is needed on top.
>
> Fixes: 492ecee892c2 ("bpf: enable program stats")
> Signed-off-by: Arnd Bergmann
7;s an ugly hack.
> Another alternative is to attach seccomp prog to parent task
> instead of N childrens.
seccomp's filter is already shared by all the children of whatever
process got the filter attached.
--
Kees Cook
proc_dointvec_minmax func.
> >>
> >> Signed-off-by: Zhiqiang Liu
> >> Reported-by: Qiang Ning
> >> Reviewed-by: Jie Liu
If proc_dointvec_jiffies() can't just be fixed, where will the new
function get used? It seems all the "unsigned int" users could benefit.
--
Kees Cook
On Wed, Oct 4, 2017 at 11:47 PM, Johannes Berg
wrote:
> On Wed, 2017-10-04 at 17:49 -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list
>> pointer to all timer callbacks, switch to using the new timer_setup()
>> and from_timer() to p
.
Cc: Johannes Berg
Cc: "David S. Miller"
Cc: linux-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be o
On Thu, Oct 5, 2017 at 6:58 AM, Jozsef Kadlecsik
wrote:
> Hi,
>
> On Wed, 4 Oct 2017, Kees Cook wrote:
>
>> In preparation for unconditionally passing the struct timer_list pointer
>> to all timer callbacks, switch to using the new timer_setup() and
>> from_tim
uct timer_list *t))
{
struct list_set *map = set->data;
- setup_timer(&map->gc, gc, (unsigned long)set);
+ timer_setup(&map->gc, gc, 0);
mod_timer(&map->gc, jiffies + IPSET_GC_PERIOD(set->timeout) * HZ);
}
@@ -606,6 +607,7 @@ init_list_set(struct net *net, struct ip_set *set, u32 size)
map->size = size;
map->net = net;
+ map->set = set;
INIT_LIST_HEAD(&map->members);
set->data = map;
--
2.7.4
--
Kees Cook
Pixel Security
On Thu, Oct 5, 2017 at 12:58 AM, Paul Bolle wrote:
> Hi Kees,
>
> On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote:
>> Also uses kzmalloc to replace open-coded field assignments to NULL and zero.
>
> If I'm allowed to whine (chances that I'm allowed to do that a
This replaces a kmalloc followed by a bunch of per-field zeroing with a
single kzalloc call, reducing the lines of code.
Cc: Paul Bolle
Cc: Karsten Keil
Cc: "David S. Miller"
Cc: Johan Hovold
Cc: gigaset307x-com...@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by:
et307x-com...@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
v2:
- split kzalloc() into a separate patch; pebolle.
---
driv
On Thu, Oct 5, 2017 at 2:38 AM, Leon Romanovsky wrote:
> On Wed, Oct 04, 2017 at 05:51:54PM -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>&
On Fri, Oct 6, 2017 at 12:00 PM, Paul Bolle wrote:
> On Thu, 2017-10-05 at 12:31 -0700, Kees Cook wrote:
>> --- a/drivers/isdn/gigaset/bas-gigaset.c
>> +++ b/drivers/isdn/gigaset/bas-gigaset.c
>
>> -static void cmd_in_timeout(unsigned long data)
>> +static void cmd_i
On Mon, Oct 9, 2017 at 2:15 AM, David Laight wrote:
> From: Kees Cook
>> Sent: 06 October 2017 20:40
> ...
>> I'm in no rush for any specific change. There are about 900 call sites
>> I'm making my way through, about 2/3rd are pretty trivial, and the
>> l
On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde wrote:
> On 10/05/2017 02:51 AM, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to p
: Jens Axboe
Cc: netdev@vger.kernel.org
Cc: linux-wirel...@vger.kernel.org
Cc: de...@driverdev.osuosl.org
Signed-off-by: Kees Cook
Acked-by: Greg Kroah-Hartman # for staging
Acked-by: Krzysztof Halasa # for wan/hdlc*
Acked-by: Jens Axboe # for amiflop
---
This should go via the timer/core tree
On Tue, Oct 10, 2017 at 1:26 AM, Kalle Valo wrote:
> Kees Cook wrote:
>
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicit
Calling setup_timer() is redundant when DEFINE_TIMER() has been used.
Cc: Chas Williams <3ch...@gmail.com>
Cc: linux-atm-gene...@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
This is intended to go via the timer tree. Acks appreciated!
---
drivers/atm/idt7
.data fields.
Cc: David S. Miller
Cc: Krzysztof Halasa
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/net/wan/hdlc_ci
ully both
gcc and clang have stepped up to solve this the same way static
analyzers have solved it. It's not exactly pretty, but it does both
document the intention for humans and provide a way for analyzers to
report issues. Having the compiler help us not make mistakes is quite
handy, and
, along with the tid index itself.
Cc: Johannes Berg
Cc: "David S. Miller"
Cc: linux-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
This has been the least trivial timer conversion yet. Given the use of
RCU and other things I may not even know about, I
kernel.org
Signed-off-by: Kees Cook
---
net/mac80211/ibss.c | 7 +++
net/mac80211/ieee80211_i.h | 3 ++-
net/mac80211/led.c | 11 ++-
net/mac80211/main.c | 3 +--
net/mac80211/mesh.c | 27 ---
net/mac80211/mesh.h |
-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 7 +++
drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/quantenna
Cc: linux-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/wireless/realtek/rtlwifi/base.c | 21 +++--
drivers/net/wireless/realtek/rtlwifi/base.h | 4 ++--
drivers/net/wireless/realtek/rtlwifi/core.c | 2
-off-by: Kees Cook
---
drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +-
drivers/net/wireless/intel/iwlegacy/3945-rs.c | 10 +++---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 9 -
drivers/net/wireless/intel/iwlegacy/common.c | 4 ++--
drivers/net/wireless/intel
rge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
include/net/dn.h| 7 ---
include/net/dn_nsp.h| 1 -
net/decnet/af_decnet.c | 4
net/decnet/dn_dev.c | 12 +---
net/decnet/dn_nsp_out.c | 11 ---
5 files changed, 5 insertions(+), 30 deletion
Morton
Cc: Anton Vasilyev
Cc: Ingo Molnar
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/isdn/hardware/mISDN/mISDNipac.c | 7 +++
drivers/isdn/hardware/mISDN/w6692.c | 7 +++
drivers/isdn/mISDN/dsp.h| 2 +-
drivers/isdn/mISDN/dsp_core.c
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Jon Mason
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/ethernet/neterion
: Philippe Reynes
Cc: Jarod Wilson
Cc: Arvind Yadav
Cc: "Bjørn Mork"
Cc: "Stefan Brüns"
Cc: Alexey Dobriyan
Cc: Greg Ungerer
Cc: linux-...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/usb/catc.c | 6 +++---
dri
kernel.org
Signed-off-by: Kees Cook
---
drivers/net/ethernet/apple/bmac.c | 12 +---
drivers/net/ethernet/apple/mace.c | 12 +---
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/apple/bmac.c
b/drivers/net/ethernet/apple/bmac.c
index ea
-wired-...@lists.osuosl.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/ethernet/intel/e100.c | 6 +++---
drivers/net/ethernet/intel/e1000e/netdev.c| 14 ++
drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 8
drivers/net/ethernet
"
Cc: Hans Liljestrand
Cc: "Reshetova, Elena"
Cc: Bhumika Goyal
Cc: Johannes Berg
Cc: Roopa Prabhu
Cc: Augusto Mecking Caringi
Cc: Jarod Wilson
Cc: Kalle Valo
Cc: Thomas Gleixner
Cc: Alexey Dobriyan
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
net/atm/clip.c | 4
l Viro
Cc: Stephen Hemminger
Cc: Arnd Bergmann
Cc: Johannes Berg
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/isdn/isdnloop/isdnloop.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/drivers/isdn/isdnloop/isdnloop.c b/dr
ned-off-by: Kees Cook
---
drivers/net/ethernet/3com/3c574_cs.c | 12 +---
drivers/net/ethernet/3com/3c589_cs.c | 10 +-
drivers/net/ethernet/3com/3c59x.c| 20 ++--
3 files changed, 20 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c574_cs.c
Williams <3ch...@gmail.com>
Cc: linux-atm-gene...@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/atm/idt77252.c | 21 -
drivers/atm/idt77252.h | 3 +++
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/atm/idt772
too. When tasklets have their .data field removed, this can be refactored
to call a central function after resolving the correct container_of() for a
separate callback function for timer and tasklet.
Cc: Oliver Neukum
Cc: netdev@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Samuel Chessman
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/ethernet/ti
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Michael Ellerman
Cc: linux-pcm...@lists.infradead.org
Signed-off-by: Kees Cook
---
drivers/pcmcia
Wilson
Cc: Philippe Reynes
Cc: netdev@vger.kernel.org
Cc: linux-par...@vger.kernel.org
Signed-off-by: Kees Cook
Reviewed-by: Tobias Klauser
---
drivers/net/ethernet/dec/tulip/de2104x.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/de
Cc: Arnd Bergmann
Cc: Jarod Wilson
Cc: netdev@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Kees Cook
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/net/etherne
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Kalle Valo
Cc: linux-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
Molnar
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
.../staging/irda/include/net/irda/irlmp_event.h| 6 +--
drivers/staging/irda/include/net/irda/timer.h | 11 ++---
drivers/staging/irda/net/af_irda.c | 7 ++-
drivers/staging/irda/net/ircomm/ircomm_tty.c
Signed-off-by: Kees Cook
---
net/xfrm/xfrm_policy.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 2746b62a8944..b669c624a1ec 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -57,7 +57,7
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/staging/irda/drivers
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Karsten Keil
Cc: Geliang Tang
Cc: "David S. Miller"
Cc: netdev@vger.kernel.org
Signed-of
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Andreas Koensgen
Cc: linux-h...@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Russell King
Cc: linux-arm-ker...@lists.infradead.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees
1 - 100 of 799 matches
Mail list logo
