[REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-23 Thread Arjun V.
Hi all, The following patch introduced a regression in Chelsio cxgb4 driver, causing port failure when running heavy TSO traffic: commit 10d3be569243def8d92ac3722395ef5a59c504e6 Author: Eric Dumazet Date: Thu Apr 21 10:55:23 2016 -0700 tcp-tso: do not split TSO packets at retransmit tim

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-27 Thread Arjun V
On Friday, June 06/24/16, 2016 at 21:55:07 +0530, Eric Dumazet wrote: > On Fri, 2016-06-24 at 07:25 -0700, Eric Dumazet wrote: > > Please do not top post on netdev mailing list > > > > On Fri, Jun 24, 2016 at 4:38 AM, Arjun V. wrote: > > > Eric, > > > W

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-27 Thread Arjun V
On Monday, June 06/27/16, 2016 at 13:36:22 +0530, Eric Dumazet wrote: > On Mon, 2016-06-27 at 12:47 +0530, Arjun V wrote: > > > Eric, > > > > Thanks for the quick patch. It didn't help much. We still see packets > > larger than 65536 with the patch. > >

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-27 Thread Arjun V
On Monday, June 06/27/16, 2016 at 14:51:19 +0530, Eric Dumazet wrote: > On Mon, 2016-06-27 at 14:29 +0530, Arjun V wrote: > > On Monday, June 06/27/16, 2016 at 13:36:22 +0530, Eric Dumazet wrote: > > > On Mon, 2016-06-27 at 12:47 +0530, Arjun V wrote: > > > > >

Re: [REGRESSION, bisect]cxgb4 port failure with TSO traffic after commit 10d3be569243def8("tcp-tso: do not split TSO packets at retransmit time")

2016-06-27 Thread Arjun V
On Monday, June 06/27/16, 2016 at 19:06:05 +0530, Neal Cardwell wrote: > On Mon, Jun 27, 2016 at 9:27 AM, Eric Dumazet wrote: > > Excellent idea ;) > > > > Here is the v2 patch. > > > > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > > index 8bd9911fdd16..e00e972c4e6a 100644 > > --- a