Re: [PATCH bpf 2/2] bpf: test_verifier, test for lookup on queue/stack maps

2018-11-28 Thread Daniel Borkmann
On 11/28/2018 08:51 AM, Prashant Bhole wrote: > This patch adds tests to check whether bpf verifier prevents lookup > on queue/stack maps > > Signed-off-by: Prashant Bhole > --- > tools/testing/selftests/bpf/test_verifier.c | 52 + > 1 file changed, 52 insertions(+) > > diff

RE:(2) (2) FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-28 Thread 배석진
> What harm is caused by these stale sessions? I thought that was the > intended behaviour. > our system stability guys concern about this. when its count grows up too much, whether it can be harm to system or not. > If you look at the original design discussions that led to the > SOCK_DESTROY an

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: David Miller > Sent: Wednesday, November 28, 2018 2:25 AM > To: Ioana Ciocoi Radulescu > Cc: [email protected]; Ioana Ciornei ; > [email protected]; Camelia Alexandra Groza > Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support > > From

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-28 Thread Xin Long
On Thu, Nov 22, 2018 at 2:53 AM Marcelo Ricardo Leitner wrote: > > On Wed, Nov 21, 2018 at 03:47:33PM +0900, Xin Long wrote: > > On Wed, Nov 21, 2018 at 9:46 AM Marcelo Ricardo Leitner > > wrote: > > > > > > On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > > > > On Tue, Nov 20, 2018

Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx_timeout()

2018-11-28 Thread Ivan Vecera
On 27. 11. 18 23:51, David Miller wrote: From: Petr Oros Date: Thu, 22 Nov 2018 15:24:07 +0100 @@ -4700,8 +4700,11 @@ int be_update_queues(struct be_adapter *adapter) struct net_device *netdev = adapter->netdev; int status; - if (netif_running(netdev)) + if (netif_run

Re: BPF uapi structures and 32-bit

2018-11-28 Thread Daniel Borkmann
On 11/27/2018 11:25 PM, David Miller wrote: > > In the linux/bpf.h UAPI header, we must absolutely avoid any > non-fixed-sized types. > > Otherwise we have serious problems on 32-bit. > > Unfortunately I discovered today that we have take on two such cases, > sk_msg_md and sk_reuseport_md, both

RE: Invalid transport_offset with AF_PACKET socket

2018-11-28 Thread Maxim Mikityanskiy
Hi Willem, > That is not what offset_hint 0 does. It also sets the transport header > to the same as the network header. No, it's not accurate. With offset_hint == 0 I have the transport header set to the offset of the mac header. It's impossible that both offset_hint == 0 and 14 set skb->transpo

RE: Invalid transport_offset with AF_PACKET socket

2018-11-28 Thread Maxim Mikityanskiy
Hi Saeed, > Can you elaborate more, what NIC? what configuration ? what do you mean > by confusion, anyway please see below ConnectX-4, after running `mlnx_qos -i eth1 --trust dscp`, which sets inline mode 2 (MLX5_INLINE_MODE_IP). I'll explain what I mean by confusion below. > in mlx5 with Conne

[iproute PATCH] man: ip-route.8: Fix ENCAP references in synopsis

2018-11-28 Thread Phil Sutter
The different encapsulation types are described in ENCAP_* non-terminals, but ENCAP definition lists them without the ENCAP_ prefix. Fix this for consistency. Signed-off-by: Phil Sutter --- man/man8/ip-route.8.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-r

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-28 Thread Marcelo Ricardo Leitner
On Wed, Nov 28, 2018 at 12:08:38AM -0200, Marcelo Ricardo Leitner wrote: > On Tue, Nov 27, 2018 at 11:18:02PM +0100, Jakub Audykowicz wrote: > > On 2018-11-19 08:20, Xin Long wrote: > > > > > On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz > > > wrote: > > >> Calling send on a connected SCTP soc

Re: [PATCHv2 net] sctp: update frag_point when stream_interleave is set

2018-11-28 Thread Neil Horman
On Tue, Nov 27, 2018 at 07:11:50PM +0800, Xin Long wrote: > sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu > changes, but we missed one place in sctp_association_init(). It would > cause frag_point is zero when sending data. > > As says in Jakub's reproducer, if sp->pathmtu

Re: [PATCH bpf 2/2] bpf: test_verifier, test for lookup on queue/stack maps

2018-11-28 Thread Mauricio Vasquez
On 11/28/18 3:45 AM, Daniel Borkmann wrote: On 11/28/2018 08:51 AM, Prashant Bhole wrote: This patch adds tests to check whether bpf verifier prevents lookup on queue/stack maps Signed-off-by: Prashant Bhole --- tools/testing/selftests/bpf/test_verifier.c | 52 + 1 fil

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-28 Thread Marcelo Ricardo Leitner
On Wed, Nov 28, 2018 at 06:36:45PM +0900, Xin Long wrote: > On Thu, Nov 22, 2018 at 2:53 AM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Nov 21, 2018 at 03:47:33PM +0900, Xin Long wrote: > > > On Wed, Nov 21, 2018 at 9:46 AM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Tue, Nov 20,

I need your assistance to invest!

2018-11-28 Thread Miss Lisa Stewart
Dear Sir, I need your support to relocate and invest in your country. I ask your assistance because I don’t have knowledge about business and the rules that guide your country for safe investment. Will you promise to be sincere with me? Please contact me for more information details! With bes

Re: (2) FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-28 Thread Eric Dumazet
On 11/27/2018 10:17 PM, 배석진 wrote: >>> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK. >> >> These sessions should have a timer, and eventually disappear. > > FIN_WAIT2 and TIME_WAIT have a timer. > but FIN_WAIT1 and LAST_ACK are have too? Sure. Otherwise we have a more

Re: [PATCH v3 net-next 3/4] tcp: make tcp_space() aware of socket backlog

2018-11-28 Thread Jean-Louis Dupond
On 27/11/18 23:42, Eric Dumazet wrote: Jean-Louis Dupond reported poor iscsi TCP receive performance that we tracked to backlog drops. Apparently we fail to send window updates reflecting the fact that we are under stress. Note that we might lack a proper window increase when backlog is fully p

Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

2018-11-28 Thread Eric Dumazet
On Tue, Nov 27, 2018 at 10:10 PM Cong Wang wrote: > > When an ethernet frame is padded to meet the minimum ethernet frame > size, the padding octets are not covered by the hardware checksum. > Fortunately the padding octets are ususally zero's, which don't affect > checksum. However, we have a swi

[PATCH net,stable] s390/qeth: fix length check in SNMP processing

2018-11-28 Thread Julian Wiedmann
The response for a SNMP request can consist of multiple parts, which the cmd callback stages into a kernel buffer until all parts have been received. If the callback detects that the staging buffer provides insufficient space, it bails out with error. This processing is buggy for the first part of

pull-request: can-next 2018-11-28

2018-11-28 Thread Marc Kleine-Budde
bae1: net/ipv4: Fix missing raw_init when CONFIG_PROC_FS is disabled (2018-11-27 20:58:02 -0800) are available in the Git repository at: ssh://[email protected]/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.21-20181128

Re: [PATCH v2 net-next 8/8] dpaa2-eth: Add xdp counters

2018-11-28 Thread David Ahern
On 11/26/18 9:27 AM, Ioana Ciocoi Radulescu wrote: > Add counters for xdp processed frames to the channel statistics. > > Signed-off-by: Ioana Radulescu > --- > v2: no changes > Reviewed-by: David Ahern

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread David Ahern
On 11/28/18 2:18 AM, Ioana Ciocoi Radulescu wrote: >> -Original Message- >> From: David Miller >> Sent: Wednesday, November 28, 2018 2:25 AM >> To: Ioana Ciocoi Radulescu >> Cc: [email protected]; Ioana Ciornei ; >> [email protected]; Camelia Alexandra Groza >> Subject: Re: [PATCH v

Re: [PATCH v2 net-next 1/8] dpaa2-eth: Add basic XDP support

2018-11-28 Thread David Ahern
On 11/26/18 9:27 AM, Ioana Ciocoi Radulescu wrote: > We keep one XDP program reference per channel. The only actions > supported for now are XDP_DROP and XDP_PASS. > > Until now we didn't enforce a maximum size for Rx frames based > on MTU value. Change that, since for XDP mode we must ensure no >

[PATCH net-next 0/6 v3] qed*: Doorbell overflow recovery

2018-11-28 Thread Ariel Elior
Doorbell Overflow If sufficient CPU cores will send doorbells at a sufficiently high rate, they can cause an overflow in the doorbell queue block message fifo. When fill level reaches maximum, the device stops accepting all doorbells from that PF until a recovery procedure has taken place. Doorbel

[PATCH net-next v3 1/6] qed: Add doorbell overflow recovery mechanism

2018-11-28 Thread Ariel Elior
Add the database used to register doorbelling entities, and APIs for adding and deleting entries, and logic for traversing the database and doorbelling once on behalf of all entities. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/

[PATCH net-next v3 2/6] qed: Use the doorbell overflow recovery mechanism in case of doorbell overflow

2018-11-28 Thread Ariel Elior
In case of an attention from the doorbell queue block, analyze the HW indications. In case of a doorbell overflow, execute a doorbell recovery. Since there can be spurious indications (race conditions between multiple PFs), schedule a periodic task for checking whether a doorbell overflow may have

[PATCH net-next v3 3/6] qed: Register slowpath queue doorbell with doorbell overflow recovery mechanism

2018-11-28 Thread Ariel Elior
Slow path queue is a doorbelling entity. Register it with the overflow mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++- drivers/net/ethernet/qlogic/qed/qed_spq.c | 47 +++

[PATCH net-next v3 4/6] qed: Register light L2 queues with doorbell overflow recovery mechanism

2018-11-28 Thread Ariel Elior
Light L2 queues are doorbelling entities. Modify the implementation to keep the doorbell data necessary for doorbelling in well known location instead of recomputing every time. Register the LL2 queue with doorbell recovery mechanism. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Sig

[PATCH net-next v3 5/6] qed: Expose the doorbell overflow recovery mechanism to the protocol drivers

2018-11-28 Thread Ariel Elior
Most of the doorbelling entities are outside of the core module. L2 queues, Roce queues, iscsi and fcoe all need to register. Make the APIs available for these drivers. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_

[PATCH net-next v3 6/6] qede: Register l2 queues with doorbell overflow recovery mechanism

2018-11-28 Thread Ariel Elior
All L2 queues funnel through this flow, so this would cover the regular RSS queues, as well queues created for VFs, mqos queues, xdp queues, etc. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qede/qede_main.c | 9 +

[PATCH RFC iproute2-next 0/2] Dynamic rdma link creation

2018-11-28 Thread Steve Wise
This series adds rdmatool support for creating/deleting rdma links. This will be used, mainly, by soft rdma drivers to allow adding/deleting rdma links over netdev interfaces. I've tagged this as "RFC" to start reviewing it, and because it is dependent on kernel changes which are still under revie

[PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe dev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 106 +++ rdma/rdma

[PATCH RFC iproute2-next 2/2] rdma: man page update for link add/delete

2018-11-28 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 51 +++ 1 file changed, 51 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index 97dd8bb994d2..b994c326dc34 10

[PATCH net-next] net: reorder flowi_common fields to avoid holes

2018-11-28 Thread Paolo Abeni
the flowi* structures are used and memsetted by server functions in critical path. Currently flowi_common has a couple of holes that we can eliminate reordering the struct fields. As a side effect, both flowi4 and flowi6 shrink by 8 bytes. Before: pahole -EC flowi_common struct flowi_common { // .

Re: [PATCH v3 net-next 2/4] tcp: take care of compressed acks in tcp_add_reno_sack()

2018-11-28 Thread Neal Cardwell
On Tue, Nov 27, 2018 at 5:42 PM Eric Dumazet wrote: > > Neal pointed out that non sack flows might suffer from ACK compression > added in the following patch ("tcp: implement coalescing on backlog queue") > > Instead of tweaking tcp_add_backlog() we can take into > account how many ACK were coales

Re: [PATCH v3 net-next 4/4] tcp: implement coalescing on backlog queue

2018-11-28 Thread Neal Cardwell
On Tue, Nov 27, 2018 at 5:42 PM Eric Dumazet wrote: > > In case GRO is not as efficient as it should be or disabled, > we might have a user thread trapped in __release_sock() while > softirq handler flood packets up to the point we have to drop. > > This patch balances work done from user thread a

Re: [PATCH v3 3/4] libbpf: add bpf_prog_test_run_xattr

2018-11-28 Thread Lorenz Bauer
On Wed, 28 Nov 2018 at 05:05, Alexei Starovoitov wrote: > > On Mon, Nov 26, 2018 at 4:45 AM Lorenz Bauer wrote: > > > > That's what I had initially, but that makes re-using test_attr really > > awkward. Either > > you need to reset data_out_size before every call because it is used > > to return

[PATCH v4 0/4] Fix unsafe BPF_PROG_TEST_RUN interface

2018-11-28 Thread Lorenz Bauer
Right now, there is no safe way to use BPF_PROG_TEST_RUN with data_out. This is because bpf_test_finish copies the output buffer to user space without checking its size. This can lead to the kernel overwriting data in user space after the buffer if xdp_adjust_head and friends are in play. Changes

[PATCH v4 2/4] tools: sync uapi/linux/bpf.h

2018-11-28 Thread Lorenz Bauer
Pull changes from "bpf: respect size hint to BPF_PROG_TEST_RUN if present". Signed-off-by: Lorenz Bauer --- tools/include/uapi/linux/bpf.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 23e2031a43d4

[PATCH v4 4/4] selftests: add a test for bpf_prog_test_run_xattr

2018-11-28 Thread Lorenz Bauer
Make sure that bpf_prog_test_run_xattr returns the correct length and that the kernel respects the output size hint. Also check that errno indicates ENOSPC if there is a short output buffer given. Signed-off-by: Lorenz Bauer --- tools/testing/selftests/bpf/test_progs.c | 55 +

[PATCH v4 1/4] bpf: respect size hint to BPF_PROG_TEST_RUN if present

2018-11-28 Thread Lorenz Bauer
Use data_size_out as a size hint when copying test output to user space. ENOSPC is returned if the output buffer is too small. Callers which so far did not set data_size_out are not affected. Signed-off-by: Lorenz Bauer --- include/uapi/linux/bpf.h | 7 +-- net/bpf/test_run.c | 15 +++

[PATCH v4 3/4] libbpf: add bpf_prog_test_run_xattr

2018-11-28 Thread Lorenz Bauer
Add a new function, which encourages safe usage of the test interface. bpf_prog_test_run continues to work as before, but should be considered unsafe. Signed-off-by: Lorenz Bauer --- tools/lib/bpf/bpf.c | 23 +++ tools/lib/bpf/bpf.h | 19 +++ 2 files changed,

[net 2/4] i40e: Fix deletion of MAC filters

2018-11-28 Thread Jeff Kirsher
From: Lihong Yang In __i40e_del_filter function, the flag __I40E_MACVLAN_SYNC_PENDING for the PF state is wrongly set for the VSI. Deleting any of the MAC filters has caused the incorrect syncing for the PF. Fix it by setting this state flag to the intended PF. CC: stable Signed-off-by: Lihong

[net 0/4][pull request] Intel Wired LAN Driver Fixes 2018-11-28

2018-11-28 Thread Jeff Kirsher
This series contains fixes to igb, ixgbe and i40e. Yunjian Wang from Huawei resolves a variable that could potentially be NULL before it is used. Lihong fixes an i40e issue which goes back to 4.17 kernels, where deleting any of the MAC filters was causing the incorrect syncing for the PF. Josh E

[net 3/4] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-28 Thread Jeff Kirsher
From: Josh Elsasser Add the two 1000BaseLX enum values to the X550's check for 1Gbps modules, allowing the core driver code to establish a link over this SFP type. This is done by the out-of-tree driver but the fix wasn't in mainline. Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability f

[net 4/4] i40e: fix kerneldoc for xsk methods

2018-11-28 Thread Jeff Kirsher
From: Jan Sokolowski One method, xsk_umem_setup, had an incorrect kernel doc description, which has been corrected. Also fixes small typos found in the comments. Signed-off-by: Jan Sokolowski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_xsk.c

[net 1/4] igb: fix uninitialized variables

2018-11-28 Thread Jeff Kirsher
From: Yunjian Wang This patch fixes the variable 'phy_word' may be used uninitialized. Signed-off-by: Yunjian Wang Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/e1000_i210.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel

[PATCH bpf] tools: bpftool: fix a bitfield pretty print issue

2018-11-28 Thread Yonghong Song
Commit b12d6ec09730 ("bpf: btf: add btf print functionality") added btf pretty print functionality to bpftool. There is a problem though in printing a bitfield whose type has modifiers. For example, for a type like typedef int ___int; struct tmp_t { int a:3; ___int b:3; }

[PATCH net] net/sched: act_police: fix memory leak in case of invalid control action

2018-11-28 Thread Davide Caratti
when users set an invalid control action, kmemleak complains as follows: # echo clear >/sys/kernel/debug/kmemleak # ./tdc.py -e b48b Test b48b: Add police action with exceed goto chain control action All test results: 1..1 ok 1 - b48b # Add police action with exceed goto chain control actio

[PATCH net-next 0/2] net/sched: act_tunnel_key: support key-less tunnels

2018-11-28 Thread Or Gerlitz
This short series from Adi Nissim allows to support key-less tunnels by the tc tunnel key actions, which is needed for some GRE use-cases. Adi Nissim (2): net/sched: act_tunnel_key: Allow key-less tunnels net/sched: act_tunnel_key: Don't dump dst port if it wasn't set net/sched/act_tunnel_ke

[PATCH net-next 1/2] net/sched: act_tunnel_key: Allow key-less tunnels

2018-11-28 Thread Or Gerlitz
From: Adi Nissim Allow setting a tunnel without a tunnel key. This is required for tunneling protocols, such as GRE, that define the key as an optional field. Signed-off-by: Adi Nissim Acked-by: Or Gerlitz Reviewed-by: Oz Shlomo Acked-by: Jiri Pirko --- net/sched/act_tunnel_key.c | 19 +

[PATCH net-next 2/2] net/sched: act_tunnel_key: Don't dump dst port if it wasn't set

2018-11-28 Thread Or Gerlitz
From: Adi Nissim It's possible to set a tunnel without a destination port. However, on dump(), a zero dst port is returned to user space even if it was not set, fix that. Note that so far it wasn't required, b/c key less tunnels were not supported and the UDP tunnels do require destination port.

Re: [PATCH net-next 1/2] rtnetlink: remove a level of indentation in rtnl_newlink()

2018-11-28 Thread David Ahern
On 11/27/18 11:32 PM, Jakub Kicinski wrote: > rtnl_newlink() used to create VLAs based on link kind. Since > commit ccf8dbcd062a ("rtnetlink: Remove VLA usage") statically > sized array is created on the stack, so there is no more use > for a separate code block that used to be the VLA's live rang

Re: [PATCH net-next 0/2] rtnetlink: avoid a warning in rtnl_newlink()

2018-11-28 Thread David Ahern
On 11/27/18 11:32 PM, Jakub Kicinski wrote: > Hi! > > I've been hoping for some time that someone more competent would fix > the stack frame size warning in rtnl_newlink(), but looks like I'll > have to take a stab at it myself :) That's the only warning I see > in most of my builds. Somehow my

Re: [PATCH net-next 2/2] rtnetlink: avoid frame size warning in rtnl_newlink()

2018-11-28 Thread David Ahern
On 11/27/18 11:32 PM, Jakub Kicinski wrote: > Standard kernel compilation produces the following warning: > > net/core/rtnetlink.c: In function ‘rtnl_newlink’: > net/core/rtnetlink.c:3232:1: warning: the frame size of 1288 bytes is larger > than 1024 bytes [-Wframe-larger-than=] > } > ^ > > T

Re: [PATCH iproute2] bridge: make -c match -compressvlans first instead of -color

2018-11-28 Thread David Ahern
On 11/27/18 7:02 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library") > broke previous use of -c to represent compressvlans. This restores > previous use of -c to represent compressvlans. Understand the original > motivation t

[PATCH net-next] tun: implement carrier change

2018-11-28 Thread Nicolas Dichtel
The userspace may need to control the carrier state. Signed-off-by: Nicolas Dichtel Signed-off-by: Didier Pallard --- drivers/net/tun.c | 27 ++- include/uapi/linux/if_tun.h | 1 + 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/net/tun.

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Leon Romanovsky
On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: > Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > device to a netdev interface. > > EG: > > rdma link add rxe_eth0 type rxe dev eth0 > rdma link delete rxe_eth0 > > Signed-off-by: Steve Wise > --- > rdma/link.

[PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN, and RTM_GETCHAIN

2018-11-28 Thread Paul Moore
Commit 32a4f5ecd738 ("net: sched: introduce chain object to uapi") added new RTM_* definitions without properly updating SELinux, this patch adds the necessary SELinux support. While there was a BUILD_BUG_ON() in the SELinux code to protect from exactly this case, it was bypassed in the broken com

Re: [PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN, and RTM_GETCHAIN

2018-11-28 Thread Paul Moore
On Wed, Nov 28, 2018 at 1:44 PM Paul Moore wrote: > Commit 32a4f5ecd738 ("net: sched: introduce chain object to uapi") > added new RTM_* definitions without properly updating SELinux, this > patch adds the necessary SELinux support. > > While there was a BUILD_BUG_ON() in the SELinux code to prote

[PATCH mlx5-next 00/11] Remove SRQ code from mlx5_core

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky Hi Doug and Jason, This series is intended to be applied on mlx5-next after Saeed's infrastructure changes series are accepted: https://patchwork.kernel.org/project/linux-rdma/list/?series=47809 -- The fol

[PATCH mlx5-next 02/11] net/mlx5: Remove dead transobj code

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky Delete functions which are not called and not needed. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- .../ethernet/mellanox/mlx5/core/transobj.c| 66 --- include/linux/mlx5/transobj.h | 5 -- 2 files changed, 71 deletions(-

[PATCH mlx5-next 03/11] net/mlx5: Remove not-used lib/eq.h header file

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky lib/eq.h is needed for EQ manipulation which are not performed in SRQ. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/srq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/srq.

[PATCH mlx5-next 07/11] RDMA/mlx5: Use stages for callback to setup and release DEVX

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky Reuse existing infrastructure to initialize and release DEVX uid. The DevX interface is intended for user space access, so it is supposed to be initialized before ib_register_device(). Also it isn't supported in switchdev mode and don't need to initialize it in that mode. F

[PATCH mlx5-next 01/11] net/mlx5: Align SRQ licenses and copyright information

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky Ensure that both RDMA and netdev parts of SRQ implementation has same copyright and license information annotated by SPDX tags. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/srq.c | 31 ++- drivers/net/

[PATCH mlx5-next 04/11] net/mlx5: Remove references to local mlx5_core functions

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky As a preparation to move SRQ functionality to RDMA, drop all references to mlx5_core logic and make SRQ be dependent on shared code only. Most of the time, we are interested to know if events are working/not working and it is possible with previous commit ("net/mlx5: Debug

[PATCH mlx5-next 05/11] net/mlx5: Move SRQ functions to RDMA part

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky There is no need to keep SRQ which is RDMA object in mlx5_core. In this patch, we partially move the execution code, while next patches will move table initialization/release logic too. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5

[PATCH mlx5-next 08/11] RDMA/mlx5: Update SRQ functions signatures to mlx5_ib format

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky Reflect the change of moving SRQ code from mlx5_core to mlx5_ib by updating function signatures do not require mlx5_core_dev as an input, because all operations in mlx5_ib are supposed to use mlx5_ib_dev. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers

[PATCH mlx5-next 10/11] RDMA/mlx5: Unfold create RMP function

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky There is no need to perform create_rmp in two separate function, while one of them uses stack as a placeholder for data while other allocates it dynamically. Combine those two functions to one instead of two. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- dri

[PATCH mlx5-next 09/11] RDMA/mlx5: Initialize SRQ tables on mlx5_ib

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky Transfer initialization and cleanup from mlx5_priv struct of mlx5_core_dev to be part of mlx5_ib_dev. This completes removal of SRQ from mlx5_core. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c | 4 ++ drivers/i

[PATCH rdma-next 11/11] RDMA/mlx5: Unfold modify RMP function

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky There is no need to perform modify_rmp in two separate function, while one of them uses stack as a placeholder for data while other allocates it dynamically. Combine those two functions to one call instead of two. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky ---

[PATCH mlx5-next 06/11] RDMA/mlx5: Remove SRQ signature global flag

2018-11-28 Thread Leon Romanovsky
From: Leon Romanovsky SRQ signature is not supported, hence no need for special static global variable to announce it. Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/srq.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/in

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Wed, 28 Nov 2018 09:18:28 + > They apply cleanly for me. I figured out what happend. The patches were mis-ordered (specifically patches #3 and #4) when I added them to the patchwork bundle, and that is what causes them to fail. Series applied, thanks!

Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx_timeout()

2018-11-28 Thread David Miller
From: Ivan Vecera Date: Wed, 28 Nov 2018 11:12:22 +0100 > On 27. 11. 18 23:51, David Miller wrote: >> From: Petr Oros >> Date: Thu, 22 Nov 2018 15:24:07 +0100 >> >>> @@ -4700,8 +4700,11 @@ int be_update_queues(struct be_adapter >>> *adapter) >>> struct net_device *netdev = adapter->netdev;

Re: BPF uapi structures and 32-bit

2018-11-28 Thread David Miller
From: Daniel Borkmann Date: Wed, 28 Nov 2018 11:34:55 +0100 > Yeah fully agree. Thinking diff below should address it, do you > have a chance to give this a spin for sparc / 32 bit to check if > test_verifier still explodes? Great, let me play with this. I did something simpler yesterday, just

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: >> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma >> device to a netdev interface. >> >> EG: >> >> rdma link add rxe_eth0 type rxe dev eth0 >> rdma link delete

Re: [PATCH net,stable] s390/qeth: fix length check in SNMP processing

2018-11-28 Thread David Miller
From: Julian Wiedmann Date: Wed, 28 Nov 2018 16:20:50 +0100 > The response for a SNMP request can consist of multiple parts, which > the cmd callback stages into a kernel buffer until all parts have been > received. If the callback detects that the staging buffer provides > insufficient space, it

Re: pull-request: can-next 2018-11-28,pull-request: can-next 2018-11-28

2018-11-28 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 28 Nov 2018 17:01:13 +0100 > > ssh://[email protected]/pub/scm/linux/kernel/git/mkl/linux-can-next.git > tags/linux-can-next-for-4.21-20181128 This doesn't work for me at all. I'm not adding a custom .ssh config entry to point

Re: [PATCH bpf] bpf: Support sk lookup in netns with id 0

2018-11-28 Thread Joe Stringer
On Tue, 27 Nov 2018 at 13:12, Alexei Starovoitov wrote: > > On Tue, Nov 27, 2018 at 10:01:40AM -0800, Joe Stringer wrote: > > On Tue, 27 Nov 2018 at 06:49, Nicolas Dichtel > > wrote: > > > > > > Le 26/11/2018 ą 23:08, David Ahern a écrit : > > > > On 11/26/18 2:27 PM, Joe Stringer wrote: > > > >

Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx_timeout()

2018-11-28 Thread Ivan Vecera
On 28. 11. 18 20:00, David Miller wrote: From: Ivan Vecera Date: Wed, 28 Nov 2018 11:12:22 +0100 On 27. 11. 18 23:51, David Miller wrote: From: Petr Oros Date: Thu, 22 Nov 2018 15:24:07 +0100 @@ -4700,8 +4700,11 @@ int be_update_queues(struct be_adapter *adapter) struct net_device

Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx_timeout()

2018-11-28 Thread David Miller
From: Ivan Vecera Date: Wed, 28 Nov 2018 20:29:44 +0100 > And the right way? netif_device_detach() that does not fire > linkwatch events? Allocate all the TX queue resources first. Do not modify the TX queue configuration in any way whatsoever meanwhile. Only after successfully allocating the

Re: [net 0/4][pull request] Intel Wired LAN Driver Fixes 2018-11-28

2018-11-28 Thread David Miller
From: Jeff Kirsher Date: Wed, 28 Nov 2018 09:10:18 -0800 > This series contains fixes to igb, ixgbe and i40e. > > Yunjian Wang from Huawei resolves a variable that could potentially be > NULL before it is used. > > Lihong fixes an i40e issue which goes back to 4.17 kernels, where > deleting any

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
... >>> + rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, &seq, >>> + (NLM_F_REQUEST | NLM_F_ACK)); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, name); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_LINK_TYPE, type); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_A

Re: [PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN, and RTM_GETCHAIN

2018-11-28 Thread David Miller
From: Paul Moore Date: Wed, 28 Nov 2018 13:47:25 -0500 > On Wed, Nov 28, 2018 at 1:44 PM Paul Moore wrote: >> Commit 32a4f5ecd738 ("net: sched: introduce chain object to uapi") >> added new RTM_* definitions without properly updating SELinux, this >> patch adds the necessary SELinux support. >>

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Leon Romanovsky
On Wed, Nov 28, 2018 at 01:34:14PM -0600, Steve Wise wrote: > ... > > >>> + rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, &seq, > >>> +(NLM_F_REQUEST | NLM_F_ACK)); > >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, name); > >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_LI

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Leon Romanovsky
On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: > > > On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > > On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: > >> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > >> device to a netdev interface. > >> > >

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: >> >> On 11/28/2018 12:26 PM, Leon Romanovsky wrote: >>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: Add new 'link' subcommand 'add' and 'delete' to allow binding a so

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Leon Romanovsky
On Wed, Nov 28, 2018 at 10:02:04PM +0200, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 01:34:14PM -0600, Steve Wise wrote: > > ... > > > > >>> + rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, &seq, > > >>> + (NLM_F_REQUEST | NLM_F_ACK)); > > >>> + mnl_attr_put_strz(

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Leon Romanovsky
On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: > > > On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > > On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: > >> > >> On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > >>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote:

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 2:08 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 10:02:04PM +0200, Leon Romanovsky wrote: >> On Wed, Nov 28, 2018 at 01:34:14PM -0600, Steve Wise wrote: >>> ... >>> >> +rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, &seq, >> + (NLM_F_REQUE

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 2:13 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: >> >> On 11/28/2018 2:04 PM, Leon Romanovsky wrote: >>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > On Thu, Sep 13

[PATCH] bpf: Fix various lib and testsuite build failures on 32-bit.

2018-11-28 Thread David Miller
Cannot cast a u64 to a pointer on 32-bit without an intervening (long) cast otherwise GCC warns. Signed-off-by: David S. Miller -- diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index eadcf8d..c2d641f 100644 --- a/tools/lib/bpf/btf.c +++ b/tools/lib/bpf/btf.c @@ -466,7 +466,7 @@ int bt

Re: [PATCH bpf-next v2 0/3] bpf: add sk_msg helper sk_msg_pop_data

2018-11-28 Thread Daniel Borkmann
On 11/26/2018 11:16 PM, John Fastabend wrote: > After being able to add metadata to messages with sk_msg_push_data we > have also found it useful to be able to "pop" this metadata off before > sending it to applications in some cases. This series adds a new helper > sk_msg_pop_data() and the associ

Re: [PATCH] selftests/bpf: add config fragment CONFIG_FTRACE_SYSCALLS

2018-11-28 Thread Daniel Borkmann
On 11/27/2018 04:24 PM, Naresh Kamboju wrote: > CONFIG_FTRACE_SYSCALLS=y is required for get_cgroup_id_user test case > this test reads a file from debug trace path > /sys/kernel/debug/tracing/events/syscalls/sys_enter_nanosleep/id > > Signed-off-by: Naresh Kamboju > --- > tools/testing/selftest

Re: [PATCH net-next] tun: implement carrier change

2018-11-28 Thread Andrew Lunn
On Wed, Nov 28, 2018 at 07:12:56PM +0100, Nicolas Dichtel wrote: > The userspace may need to control the carrier state. Hi Nicolas Could you explain your user case a bit more. Are you running a routing daemon on top of the interface, and want it to reroute when the carrier goes down? Thanks

[PATCH net-next 3/3] vxlan: move flag sets to use a helper func vxlan_nl2conf

2018-11-28 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 95 - 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 4cb6b50..47671fd 100644 --- a/drivers/net/vxlan.c ++

[PATCH net-next 2/3] vxlan: extack support for some changelink cases

2018-11-28 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 76 + 1 file changed, 59 insertions(+), 17 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 73caa65..4cb6b50 100644 --- a/drivers/net/vxlan.c ++

[PATCH net-next 0/3] vxlan: a few minor cleanups

2018-11-28 Thread Roopa Prabhu
From: Roopa Prabhu Roopa Prabhu (3): vxlan: support changelink for a few more attributes vxlan: extack support for some changelink cases vxlan: move flag sets to use a helper func vxlan_nl2conf drivers/net/vxlan.c | 199 +++- 1 file changed,

[PATCH net-next 1/3] vxlan: support changelink for a few more attributes

2018-11-28 Thread Roopa Prabhu
From: Roopa Prabhu We started very conservative when supporting changelink especially because not all attribute changes could be tested. This patch opens up a few more attributes for changelink. The reason for choosing this set of attributes is based on code references for these attributes. I hav

Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

2018-11-28 Thread Cong Wang
On Wed, Nov 28, 2018 at 7:00 AM Eric Dumazet wrote: > > Nice packet of death alert. > > pad_len can be 0xFF67 here, if frame_len is smaller than pad_offset. Unless IP header is malformed, how could it be? Speaking of IP header sanity, I am totally aware of it, I don't check it because I kno

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Jason Gunthorpe
On Wed, Nov 28, 2018 at 02:18:55PM -0600, Steve Wise wrote: > > > On 11/28/2018 2:13 PM, Leon Romanovsky wrote: > > On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: > >> > >> On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > >>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote:

  1   2   3   4   >