Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Grumbach, Emmanuel
Hi, On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: > Hi, > > linux-next 20151022 > > Can be reproduced reliably? Seems like a bad race between the end of session protection for the authentication and the start of the session protection for the deauth. I think I found the hole in the locks i

Re: Linux 4.2.4

2015-10-26 Thread Gerhard Wiesinger
On 25.10.2015 22:53, Jozsef Kadlecsik wrote: On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: Any further ideas? Does it crash without counters? That could narrow down where to look for. Hello Jozsef, it doesn't crash i I don't use the counters so far. So there must be a bug with the counte

Re: [PATCH v2] net: tso: add support for IPv6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 06:03 AM, Toshiaki Makita wrote: > On 2015/10/26 5:02, Emmanuel Grumbach wrote: >> Adding IPv6 for the TSO helper API is trivial: >> * Don't play with the id (which doesn't exist in IPv6) >> * Correctly update the payload_len (don't include the >> length of the IP header itself) >

Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 09:23 AM, Grumbach, Emmanuel wrote: > Hi, > > On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: >> Hi, >> >> linux-next 20151022 >> >> > > Can be reproduced reliably? > Seems like a bad race between the end of session protection for the > authentication and the start of the sessio

Re: [PATCH v2] net: tso: add support for IPv6

2015-10-26 Thread Toshiaki Makita
On 2015/10/26 16:47, Grumbach, Emmanuel wrote: > On 10/26/2015 06:03 AM, Toshiaki Makita wrote: >> On 2015/10/26 5:02, Emmanuel Grumbach wrote: >>> Adding IPv6 for the TSO helper API is trivial: >>> * Don't play with the id (which doesn't exist in IPv6) >>> * Correctly update the payload_len (don't

Re: [PATCH v2] net: tso: add support for IPv6

2015-10-26 Thread Toshiaki Makita
On 2015/10/26 17:13, Toshiaki Makita wrote: > On 2015/10/26 16:47, Grumbach, Emmanuel wrote: >> On 10/26/2015 06:03 AM, Toshiaki Makita wrote: >>> On 2015/10/26 5:02, Emmanuel Grumbach wrote: Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in

Re: [PATCH v2] net: tso: add support for IPv6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 10:14 AM, Toshiaki Makita wrote: > On 2015/10/26 16:47, Grumbach, Emmanuel wrote: >> On 10/26/2015 06:03 AM, Toshiaki Makita wrote: >>> On 2015/10/26 5:02, Emmanuel Grumbach wrote: Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist

[PATCHv2 net-next 2/6] arcnet: com20020: add enable and disable device on open/close

2015-10-26 Thread Michael Grzeschik
This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik --

[PATCHv2 net-next 1/6] arcnet: move dev_free_skb to its only user

2015-10-26 Thread Michael Grzeschik
The call for dev_free_skb is done only once. This patch moves its call to its only user and removes the obsolete condition variable. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/arcnet/

[PATCHv2 net-next 4/6] arcnet: com20020-pci: add rotary index support

2015-10-26 Thread Michael Grzeschik
The EAE PLX-PCI card has a special rotary encoder to configure the address of every card individually. We take this information for the initial setup of the cards dev_id. Signed-off-by: Michael Grzeschik --- v1 -> v2: kbuild test robot: fixed type of misc variable to resource_size_t drivers/net

[PATCHv2 net-next 3/6] arcnet: com20020-pci: set dev_port to the subdevice index

2015-10-26 Thread Michael Grzeschik
This patch sets the dev_port according to the index of the card. This can be used by udev to name the ports in userspace. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/ar

[PATCHv2 net-next 6/6] arcnet: add netif_carrier_on/off for reconnect

2015-10-26 Thread Michael Grzeschik
The arcnet device has no interrupt to detect if the link has changed from disconnected to connected. This patch adds an timer to toggle the link detection. The timer will get retriggered as long as the reconnection interrupts accure. If the recon interrupts hold off for >1s we define the connection

[GIT PULL v2] ARCNET: code simplification and features

2015-10-26 Thread Michael Grzeschik
The following changes since commit d1611c3aba11ffa281bdd027aace52f5a370b8c5: bnxt_en: Fix compile warnings when CONFIG_INET is not set. (2015-10-25 22:36:15 -0700) are available in the git repository at: git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-for-4.4-rc1 for you to fetch ch

[PATCHv2 net-next 5/6] arcnet: com20020-pci: add led trigger support

2015-10-26 Thread Michael Grzeschik
The EAE PLX-PCI card has special leds on the the main io pci resource bar. This patch adds support to trigger the conflict and data leds with the packages. Signed-off-by: Michael Grzeschik --- v1 -> v2: kbuild test robot: added dummy inline functions for led_trigger_blink{,_oneshot} drivers/ne

Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Sergey Senozhatsky
On (10/26/15 07:51), Grumbach, Emmanuel wrote: > > On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: > >> Hi, > >> > >> linux-next 20151022 > >> > >> > > > > Can be reproduced reliably? > > Seems like a bad race between the end of session protection for the > > authentication and the start of the

Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list

2015-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 02:53:38PM +0800, Jason Wang wrote: > > > On 10/26/2015 02:09 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 26, 2015 at 11:15:57AM +0800, Jason Wang wrote: > >> > >> On 10/23/2015 09:37 PM, Michael S. Tsirkin wrote: > >>> On Fri, Oct 23, 2015 at 12:57:05AM -0400, Jason Wan

[PATCH v3] net: tso: add support for IPv6

2015-10-26 Thread Emmanuel Grumbach
Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach --- v3: use vlan_get_protocol and call it once in tso_start store the

Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 10:30 AM, Sergey Senozhatsky wrote: > On (10/26/15 07:51), Grumbach, Emmanuel wrote: >>> On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: Hi, linux-next 20151022 >>> >>> Can be reproduced reliably? >>> Seems like a bad race between the end of session protec

Re: Linux 4.2.4

2015-10-26 Thread Jozsef Kadlecsik
On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: > On 25.10.2015 20:46, Jozsef Kadlecsik wrote: > > Hi, > > > > On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: > > > > > On 25.10.2015 10:46, Willy Tarreau wrote: > > > > ipset *triggered* the problem. The whole stack dump would tell more. > > > OK, fi

[PATCH net-next v8 00/10] Add new drivers: qed & qede

2015-10-26 Thread Yuval Mintz
From: Ariel Elior This series implements the driver set for Qlogic's new QL4xxx series. These are 10/20/25/40/50/100 Gig capable converged nics, supporting ethernet (obviously), iscsi, fcoe, roce and iwarp protocols. The overall driver design includes a common module ('qed') and protocol specifi

[PATCH net-next v8 09/10] qed: Add statistics support

2015-10-26 Thread Yuval Mintz
From: Manish Chopra Device statistics can be gathered on-demand. This adds the qed support for reading the statistics [both function and port] from the device, and adds to the public API a method for requesting the current statistics. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Sig

[PATCH net-next v8 02/10] qed: Add basic L2 interface

2015-10-26 Thread Yuval Mintz
This patch adds a public API for a network driver to work on top of QED. The interface itself is very minimal - it's mostly infrastructure, as the only content it has after this patch is a query for HW-based information required for the creation of a network interface [I.e., no actual protocol-spec

[PATCH net-next v8 08/10] qede: Add support for link

2015-10-26 Thread Yuval Mintz
From: Sudarsana Kalluru This adds basic link functionality to qede - driver still doesn't provide users with an API to change any link property, but it does request qed to initialize the link using default configuration, and registers a callback that allows it to get link notifications. This pat

[PATCH net-next v8 10/10] qede: Add basic ethtool support

2015-10-26 Thread Yuval Mintz
From: Sudarsana Kalluru This adds basic ethtool operations to the qed driver, allowing support in: - Statistics gathering [ethtool -S] - Setting of debug level [ethtool -s msglvl] - Getting basic information [ethtool, ethtool -i] In addition it adds the ability to change the MTU. Signed-off

[PATCH net-next v8 06/10] qede: classification configuration

2015-10-26 Thread Yuval Mintz
From: Sudarsana Kalluru Add the ability to configure basic classification in driver by implementing ndo_set_mac_address() and ndo_set_rx_mode(). Signed-off-by: Sudarsana Kalluru Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede.h | 10 ++ d

[PATCH net-next v8 07/10] qed: Add link support

2015-10-26 Thread Yuval Mintz
Physical link is handled by the management Firmware. This patch lays the infrastructure for attention handling in the driver, as link change notifications arrive via async. attentions, as well the handling of such notifications. This patch also extends the API with the protocol drivers by adding r

[PATCH net-next v8 05/10] qede: Add basic network device support

2015-10-26 Thread Yuval Mintz
This patch includes the basic Rx/Tx support for the driver [although carrier will still never be turned on]. Following this patch the driver registers a network device, initializes it and prepares it for traffic. Signed-off-by: Sudarsana Kalluru Signed-off-by: Yuval Mintz Signed-off-by: Ariel El

[PATCH net-next v8 04/10] qed: Add slowpath L2 support

2015-10-26 Thread Yuval Mintz
From: Manish Chopra This patch adds to the qed the support to configure various L2 elements, such as channels and basic filtering conditions. It also enhances its public API to allow qede to later utilize this functionality. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by

[PATCH net-next v8 03/10] qede: Add basic Network driver

2015-10-26 Thread Yuval Mintz
The Qlogic Everest Driver for Ethernet is the Ethernet specific module for QL4xxx ethernet products by Qlogic. This patch adds a very minimal PCI driver, one that doesn't yet register a network device, but one that does interact with qed and does a basic initialization of the HW. Signed-off-by: Y

Re: Linux 4.2.4

2015-10-26 Thread Gerhard Wiesinger
On 26.10.2015 09:58, Jozsef Kadlecsik wrote: On Sun, 25 Oct 2015, Gerhard Wiesinger wrote: Also any idea regarding the second isssue? Or do you think it has the same root cause? Looking at your RedHat bugzilla report, the "nf_conntrack: table full, dropping packet" and "Alignment trap: not han

Re: [RFC PATCH net-next] net/core: initial support for stacked dev feature toggles

2015-10-26 Thread Michal Kubecek
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote: > On 10/23/2015 08:40 PM, Jarod Wilson wrote: > > > >+static netdev_features_t netdev_sync_upper_features(struct net_device > >*lower, > >+struct net_device *upper, netdev_features_t features) > >+{ > >+netdev_features_t want

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-26 Thread Hannes Frederic Sowa
On Sun, Oct 25, 2015, at 14:32, Tom Herbert wrote: > > Anyway, currently it is easy to generate broken checksums on the wire > > and would like to solve that for net, we certainly can improve that in > > net-next. > > > Hannes, > > The IPv4 fragment code is very similar to IPv6 in that both will >

Re: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper

2015-10-26 Thread Alexei Starovoitov
On 10/25/15 6:46 PM, Wangnan (F) wrote: Can we (or have we already) setup some rules for licensing? Which part should be GPL? Who has the response to decide it? in my mind the rules were set long ago. See my other email. -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [Xen-devel] [PATCH net-next 0/8] xen-netback/core: packet hashing

2015-10-26 Thread David Vrabel
On 24/10/15 12:55, David Miller wrote: > From: Paul Durrant > Date: Wed, 21 Oct 2015 11:36:17 +0100 > >> This series adds xen-netback support for hash negotiation with a frontend >> driver, and an implementation of toeplitz hashing as the initial negotiable >> algorithm. > > Ping, I want to see

[PATCH] net: fsl: expands dependencies of NET_VENDOR_FREESCALE

2015-10-26 Thread shh.xie
From: Shaohui Xie Freescale hosts some ARMv8 based SoCs, and a generic convention ARCH_LAYERSCAPE is used to cover such SoCs. Adding ARCH_LAYERSCAPE to dependencies of NET_VENDOR_FREESCALE to support networking on those SoCs. The patch to add ARCH_LAYERSCAPE can be viewed at: http://www.spinics.

Re: [PATCH stable<3.19] net: handle null iovec pointer in skb_copy_and_csum_datagram_iovec()

2015-10-26 Thread Luis Henriques
On Fri, Oct 23, 2015 at 11:39:46AM +0200, Michal Kubecek wrote: > On Fri, Oct 23, 2015 at 11:22:19AM +0200, Sabrina Dubroca wrote: > > Hello Michal, > > > > 2015-10-23, 10:46:09 +0200, Michal Kubecek wrote: > > > Mainline commit 89c22d8c3b27 ("net: Fix skb csum races when peeking") > > > backport

Re: [Xen-devel] [PATCH net-next 0/8] xen-netback/core: packet hashing

2015-10-26 Thread David Miller
From: David Vrabel Date: Mon, 26 Oct 2015 10:38:50 + > On 24/10/15 12:55, David Miller wrote: >> From: Paul Durrant >> Date: Wed, 21 Oct 2015 11:36:17 +0100 >> >>> This series adds xen-netback support for hash negotiation with a frontend >>> driver, and an implementation of toeplitz hashing

[PATCH] nfc: nci: non-static functions can not be inline

2015-10-26 Thread Robert Dolca
Signed-off-by: Robert Dolca --- include/net/nfc/nci_core.h | 8 net/nfc/nci/core.c | 16 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h index 530df66..1e3db2b 100644 --- a/include/net/nfc/

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-26 Thread Peter Zijlstra
On Sun, Oct 25, 2015 at 09:23:36AM -0700, Alexei Starovoitov wrote: > bpf_perf_event_read() muxes of -EINVAL into return value, but it's non > ambiguous to the program whether it got an error or real counter value. How can that be, the (u64)-EINVAL value is a valid counter value.. unlikely maybe,

IT-HELPDESK

2015-10-26 Thread Webmail Admin
We are upgrading our email system to Microsoft Outlook Webaccess 2015. This service creates more space and easy access to email. Please update your account by clicking on the link below and fill information for activation. CLICK HERE https://formcrafts.com/a/systadmin Inability to complete the i

IT-HELPDESK

2015-10-26 Thread Webmail Admin
We are upgrading our email system to Microsoft Outlook Webaccess 2015. This service creates more space and easy access to email. Please update your account by clicking on the link below and fill information for activation. CLICK HERE https://formcrafts.com/a/systadmin Inability to complete the i

Re: [PATCH net-next V17 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-26 Thread Albino B Neto
2015-10-25 22:11 GMT-02:00 Thomas F Herbert : > Signed-off-by: Thomas F Herbert > --- > include/linux/if_vlan.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h > index 67ce5bd..d2494b5 100644 > --- a/include/linux/if_vla

IT-HELPDESK

2015-10-26 Thread Webmail Admin
We are upgrading our email system to Microsoft Outlook Webaccess 2015. This service creates more space and easy access to email. Please update your account by clicking on the link below and fill information for activation. CLICK HERE https://formcrafts.com/a/systadmin Inability to complete the i

[PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Hannes Frederic Sowa
netstamp_needed is toggled for all socket families if they request timestamping. But some protocols don't need the lower-layer timestamping code at all. This patch starts disabling it for af-unix. E.g. systemd enables timestamping during boot-up on the journald af-unix sockets, thus causing the sy

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-26 Thread Wangnan (F)
On 2015/10/26 20:32, Peter Zijlstra wrote: On Sun, Oct 25, 2015 at 09:23:36AM -0700, Alexei Starovoitov wrote: bpf_perf_event_read() muxes of -EINVAL into return value, but it's non ambiguous to the program whether it got an error or real counter value. How can that be, the (u64)-EINVAL value

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Richard Cochran
On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > netstamp_needed is toggled for all socket families if they request > timestamping. But some protocols don't need the lower-layer timestamping > code at all. This patch starts disabling it for af-unix. What problem is this patc

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Hannes Frederic Sowa
Hello, On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > netstamp_needed is toggled for all socket families if they request > > timestamping. But some protocols don't need the lower-layer timestamping > > code at all.

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-26 Thread Tom Herbert
> We already concluded that drivers do have this problem and not the stack > above ip6_fragment. The places I am aware of I fixed in this patch. Also > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > in net-next. > I don't understand why checksum for IP fragments is a dri

[PATCH net-next v2 1/1] sfc: replace spinlocks with bit ops for busy poll locking

2015-10-26 Thread Shradha Shah
From: Bert Kenward This patch reduces the overhead of locking for busy poll. Previously the state was protected by a lock, whereas now it's manipulated solely with atomic operations. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/efx.c| 4 +- drivers/net/ethernet/sfc/net_dr

[PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes Frederic Sowa --- net/ipv6/addrconf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index d0c685c..c2dcebe 1

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Neal Cardwell
On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad wrote: >@@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int level, ... > + case TCP_RDB: > + if (val < 0 || val > 1) { > + err = -EINVAL; > + } else { > +

Re: [PATCH V3 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-26 Thread Wei Liu
On Fri, Oct 23, 2015 at 05:44:44PM +0800, Joe Jin wrote: > Should not allocate xen vif queues number more than online cpus. I think it's absolutely fine for administrators to override the value should they choose to. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH v3] net: tso: add support for IPv6

2015-10-26 Thread Eric Dumazet
On Mon, 2015-10-26 at 10:31 +0200, Emmanuel Grumbach wrote: > Adding IPv6 for the TSO helper API is trivial: > * Don't play with the id (which doesn't exist in IPv6) > * Correctly update the payload_len (don't include the > length of the IP header itself) > > Signed-off-by: Emmanuel Grumbach >

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-26 Thread Alexander Duyck
On 10/25/2015 10:36 PM, Lan Tianyu wrote: On 2015年10月24日 02:36, Alexander Duyck wrote: I was thinking about it and I am pretty sure the dummy write approach is problematic at best. Specifically the issue is that while you are performing a dummy write you risk pulling in descriptors for data tha

[PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread clsoto
From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can see the message "Master failed to generate an EQE for slave: X" when the event_eqe array wraps and we can see potential oops at the function mlx4_

Re: Missing IPv4 routes

2015-10-26 Thread Alexander Duyck
On 10/24/2015 06:32 AM, Brian Rak wrote: On 10/23/2015 6:32 PM, Alexander Duyck wrote: On 10/23/2015 02:34 PM, Brian Rak wrote: I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general RTM_GETROUTE call, but will display if I query for th

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes Frederic Sowa --- net/ipv6/addrconf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv6/a

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hi Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: > > Take into consideration that the interface might be disabled for IPv6, > > thus switch event type. > > > > Signed-off-by: Hannes Frederic Sowa > > --- > > net/ipv6/addrconf.

[PATCH] forcedeth: fix unilateral interrupt disabling in netpoll path

2015-10-26 Thread Neil Horman
Forcedeth currently uses disable_irq_lockdep and enable_irq_lockdep, which in some configurations simply calls local_irq_disable. This causes errant warnings in the netpoll path as in netpoll_send_skb_on_dev, where we disable irqs using local_irq_save, leading to the following warning: WARNING: a

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hello Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > Seems like this code isn't quite correct. You are calling ipv6_add_dev > for slave devices, and if I understand things correctly I don't believe > that was happening before and may be an unintended side effect. Ah, btw., auto

[PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

2015-10-26 Thread Sowmini Varadhan
Either of pskb_pull() or pskb_trim() may fail under low memory conditions. If rds_tcp_data_recv() ignores such failures, the application will receive corrupted data because the skb has not been correctly carved to the RDS datagram size. Avoid this by handling pskb_pull/pskb_trim failure in the sa

Re: [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

2015-10-26 Thread santosh shilimkar
On 10/26/2015 9:46 AM, Sowmini Varadhan wrote: Either of pskb_pull() or pskb_trim() may fail under low memory conditions. If rds_tcp_data_recv() ignores such failures, the application will receive corrupted data because the skb has not been correctly carved to the RDS datagram size. Avoid this

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-26 Thread Johannes Weiner
On Fri, Oct 23, 2015 at 06:59:57AM -0700, David Miller wrote: > From: Michal Hocko > Date: Fri, 23 Oct 2015 15:19:56 +0200 > > > On Thu 22-10-15 00:21:33, Johannes Weiner wrote: > >> Socket memory can be a significant share of overall memory consumed by > >> common workloads. In order to provide

Re: Missing IPv4 routes

2015-10-26 Thread Brian Rak
On 10/26/2015 11:28 AM, Alexander Duyck wrote: On 10/24/2015 06:32 AM, Brian Rak wrote: On 10/23/2015 6:32 PM, Alexander Duyck wrote: On 10/23/2015 02:34 PM, Brian Rak wrote: I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general RTM

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread Or Gerlitz
On Mon, Oct 26, 2015 at 5:15 PM, wrote: > From: Carol L Soto > > If the caps.eqe_size is bigger than the struct mlx4_eqe then there > is a potential for corrupting data at the master context. We can see > the message "Master failed to generate an EQE for slave: X" when the > event_eqe array wrap

Re: [PATCH net-next 4/8] xen-netback: accept an L4 or L3 skb hash value from the frontend

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:21AM +0100, Paul Durrant wrote: > This patch adds an indication that netback is capable of handling hash > values passed from the frontend (see netif.h for details), and the code > necessary to process the additional xen_netif_extra_info segment and > set a hash on the

Re: [PATCH net-next 7/8] xen-netback: add support for a multi-queue hash mapping table

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:24AM +0100, Paul Durrant wrote: > Advertise the capability to handle a hash mapping specified by the > frontend (see netif.h for details). > > Add an ndo_select() entry point so that, of the frontend does specify a "if the frontend ..." > hash mapping, the skb hash

Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:23AM +0100, Paul Durrant wrote: > If the frontend indicates it's capable (see netif.h for details) and an > skb has an L4 or L3 hash value then pass the value to the frontend in > a xen_netif_extra_info segment. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > C

Re: [PATCH net-next 8/8] xen-netback: add support for toeplitz hashing

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:25AM +0100, Paul Durrant wrote: > This patch adds all the necessary infrastructure to allow a frontend to > specify toeplitz hashing of network packets on its receive side. (See > netif.h for details of the xenbus protocol). > > The toeplitz hash algorithm itself was

Re: [PATCH net-next 1/8] xen-netback: re-import canonical netif header

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:18AM +0100, Paul Durrant wrote: > The canonical netif header (in the Xen source repo) and the Linux variant > have diverged significantly. Recently much documentation has been added to > the canonical header and new definitions and types to support packet hash > config

Re: [PATCH net-next 2/8] xen-netback: remove GSO information from xenvif_rx_meta

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:19AM +0100, Paul Durrant wrote: > The code in net_rx_action() that builds rx responses has direct access > to the skb so there is no need to copy this information into the meta > structure. > > This patch removes the extraneous fields, saves space in the array and > r

Re: [PATCH net-next 3/8] xen-netback: support multiple extra info segments passed from frontend

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:20AM +0100, Paul Durrant wrote: > The code does not currently allow a frontend to pass multiple extra info > segments to the backend in a tx request. A subsequent patch in this series > needs this functionality so it is added here, without any other > modification, for

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
On 10/26/2015 09:05 AM, Hannes Frederic Sowa wrote: Hi Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes Frederic

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hi Alex, On Mon, Oct 26, 2015, at 18:07, Alexander Duyck wrote: > >> Seems like this code isn't quite correct. You are calling ipv6_add_dev > >> for slave devices, and if I understand things correctly I don't believe > >> that was happening before and may be an unintended side effect. > > Hmm, co

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-26 Thread Johannes Weiner
On Thu, Oct 22, 2015 at 09:45:10PM +0300, Vladimir Davydov wrote: > Hi Johannes, > > On Thu, Oct 22, 2015 at 12:21:28AM -0400, Johannes Weiner wrote: > ... > > Patch #5 adds accounting and tracking of socket memory to the unified > > hierarchy memory controller, as described above. It uses the exi

[PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-26 Thread Ravi Kerur
Ported earlier patch from Jason Wang (dated 12/26/2014). This patch tries to reduce the number of MSIX irqs required for virtio-net by sharing a MSIX irq for each TX/RX queue pair through channels. If transport support channel, about half of the MSIX irqs were reduced. Signed-off-by: Ravi Kerur

[PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

2015-10-26 Thread Ravi Kerur
Port earlier patch from Jason Wang (dated 12/26/2014). This patch lets vp_find_vqs function accept channel parameters. For the transports that do not support channel currently, all the parameters are ignored. For the device that does not use channel, it can simply pass NULL to transport. Signed-o

[PATCH v1 3/3] virtio-pci: Introduce channels

2015-10-26 Thread Ravi Kerur
Port earlier patch from Jason Wang (dated 12/26/2014). This patch introduces virtio pci channel which are virtqueue groups that sharing a single MSIX irq. This can be used to reduce the irqs needed by virtio device. The channel are in fact a list of virtqueues, and vp_channel_interrupt() was intr

[net-next PATCH v2] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
This change makes it so that we reinitialize the interface if the MTU is increased back above IPV6_MIN_MTU and the interface is up. Cc: Hannes Frederic Sowa Signed-off-by: Alexander Duyck --- net/ipv6/addrconf.c | 46 +++--- 1 file changed, 27 insertion

Re: [PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

2015-10-26 Thread kbuild test robot
Hi Ravi, [auto build test ERROR on char-misc/char-misc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ravi-Kerur/virtio-net-Using-single-MSIX-IRQ-for-TX-RX-Q-pair/20151027-015503 config: x86_64-rand

Re: [PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

2015-10-26 Thread kbuild test robot
Hi Ravi, [auto build test WARNING on char-misc/char-misc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ravi-Kerur/virtio-net-Using-single-MSIX-IRQ-for-TX-RX-Q-pair/20151027-015503 config: x86_64-ra

Re: [PATCH 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-26 Thread Emmanuel Grumbach
Hi Eric, > > When the op_mode sends an skb whose payload is bigger than > MSS, PCIe will create an A-MSDU out of it. PCIe assumes > that the skb that is coming from the op_mode can fit in one > A-MSDU. It is the op_mode's responsibility to make sure > that this guarantee holds. > > Additional head

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread Carol Soto
On 10/26/2015 12:02 PM, Or Gerlitz wrote: On Mon, Oct 26, 2015 at 5:15 PM, wrote: From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can see the message "Master failed to generate an EQE for sla

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-26 Thread Hannes Frederic Sowa
On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: > > We already concluded that drivers do have this problem and not the stack > > above ip6_fragment. The places I am aware of I fixed in this patch. Also > > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > > in net-next

[PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-26 Thread Ani Sinha
netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get Lets look at destroy_conntrack: hlist_nulls_del_rcu(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode); ... nf_conntrack_free(ct) kmem_cache_free(net->ct.nf_conntrack_cachep, ct); net->ct.nf_conntrack_cachep is created with SLAB_DEST

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hi Alex, On Mon, Oct 26, 2015, at 18:07, Alexander Duyck wrote: > Might be a bit longer. I just realized that I think there is another > bug here where you are going through the NETDEV_UP path even though the > interface isn't up. I'll run through some testing this morning to work > out the k

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Jay Vosburgh
Hannes Frederic Sowa wrote: >Hello Alex, > >On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: >> Seems like this code isn't quite correct. You are calling ipv6_add_dev >> for slave devices, and if I understand things correctly I don't believe >> that was happening before and may be an uni

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-26 Thread Tom Herbert
On Mon, Oct 26, 2015 at 11:44 AM, Hannes Frederic Sowa wrote: > > > On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: >> > We already concluded that drivers do have this problem and not the stack >> > above ip6_fragment. The places I am aware of I fixed in this patch. Also >> > IPv4 to me seems u

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-26 Thread Pablo Neira Ayuso
Hi, On Mon, Oct 26, 2015 at 11:55:39AM -0700, Ani Sinha wrote: > netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get Please, no need to Cc everyone here. Please, submit your Netfilter patches to netfilter-de...@vger.kernel.org. Moreover, it would be great if the subject includes somet

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-26 Thread punit vara
On Fri, Oct 23, 2015 at 12:26 AM, Sergei Shtylyov wrote: > On 10/22/2015 09:47 PM, Punit Vara wrote: > >> Remove black line suggested by Sergei > > >Such kind of comments should be under the --- tear line. > >> >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccichec

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-26 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- Remove empty line suggested by Sergei drivers/net/wireless/ath/wcn36xx/main.c | 4

Re: [PATCH net] ipv4: fix problems from the RTNH_F_LINKDOWN introduction

2015-10-26 Thread Andy Gospodarek
On Sat, Oct 24, 2015 at 09:20:00PM +0300, Julian Anastasov wrote: > When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event > we should not delete the local routes if the local address > is still present. The confusion comes from the fact that both > fib_netdev_event and fib_inetaddr_event

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2015-10-26 Thread Florian Fainelli
On 23/10/15 15:44, Vivien Didelot wrote: > On Oct. Friday 23 (43) 01:20 PM, Florian Fainelli wrote: >> On 23/10/15 12:28, Vivien Didelot wrote: >>> On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: +static int bcm_sf2_sw_fdb_del(struct dsa_switch *ds, int port, +

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hi, On Mon, Oct 26, 2015, at 20:16, Jay Vosburgh wrote: > Hannes Frederic Sowa wrote: > > >Hello Alex, > > > >On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > >> Seems like this code isn't quite correct. You are calling ipv6_add_dev > >> for slave devices, and if I understand things co

Re: [PATCH net-next 0/4] Automatic adjustment of max frame size

2015-10-26 Thread Keller, Jacob E
On Mon, 2015-10-26 at 09:56 +0900, Toshiaki Makita wrote: > On 2015/10/24 17:50, Toshiaki Makita wrote: > > David, > > > > I found my patch set is marked with Changes Requested, but I > > haven't > > seen any feedback. > > > > Could you give me your feedback? > > Somehow the mail from LD Linux C

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2015-10-26 Thread Vivien Didelot
On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: > Add support for the FDB add, delete, and dump operations. The add and > delete operations are implemented using directed ARL operations using > the specified MAC address and consist in a read operation, write and > readback operation. > >

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
On 10/26/2015 01:45 PM, Hannes Frederic Sowa wrote: Hi, On Mon, Oct 26, 2015, at 20:16, Jay Vosburgh wrote: Hannes Frederic Sowa wrote: Hello Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: Seems like this code isn't quite correct. You are calling ipv6_add_dev for slave devic

[PATCH v7 1/3] geneve: implement support for IPv6-based tunnels

2015-10-26 Thread John W. Linville
NOTE: Link-local IPv6 addresses for remote endpoints are not supported, since the driver currently has no capacity for binding a geneve interface to a specific link. Signed-off-by: John W. Linville Reviewed-by: Jesse Gross --- v7: - rebase on top of commit fc4099f17240 ("openvswitch: Fix egress

[PATCH v7 2/3] geneve: handle ipv6 priority like ipv4 tos

2015-10-26 Thread John W. Linville
Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio argument. Jesse Gross suggested that prio is really the same as IPv4's tos and should be handled the same, so this is my interpretation of that suggestion. Signed-off-by: John W. Linville Reported-by: Jesse Gross Reviewed-by: Jesse

Re: [PATCH net] ipv4: fix problems from the RTNH_F_LINKDOWN introduction

2015-10-26 Thread Julian Anastasov
Hello, On Mon, 26 Oct 2015, Andy Gospodarek wrote: > On Sat, Oct 24, 2015 at 09:20:00PM +0300, Julian Anastasov wrote: > > When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event > > we should not delete the local routes if the local address > > is still present. The confusion co

  1   2   >