Re: various TLS bug fixes...

2019-08-21 Thread Jakub Kicinski
On Wed, 21 Aug 2019 11:03:46 -0700, Jakub Kicinski wrote: > On Tue, 20 Aug 2019 23:51:12 -0700, Jakub Kicinski wrote: > > > If you have more details I can also spend some cycles looking into it. > > > > Awesome, I'll let you know what the details are as soon as I get them. > > Just a quick

Re: various TLS bug fixes...

2019-08-21 Thread Jakub Kicinski
On Tue, 20 Aug 2019 23:51:12 -0700, Jakub Kicinski wrote: > > If you have more details I can also spend some cycles looking into it. > > Awesome, I'll let you know what the details are as soon as I get them. Just a quick update on that. The test case is nginx running with ktls offload. The cl

Re: various TLS bug fixes...

2019-08-20 Thread Jakub Kicinski
On Tue, 20 Aug 2019 22:18:30 -0700, John Fastabend wrote: > > > I suspect you've triaged through this already on your side for other > > > reasons, so perhaps you could help come up with a sane set of TLS > > > bug fix backports that would be appropriate for -stable? > > > > I'm planning to spen

Re: various TLS bug fixes...

2019-08-20 Thread John Fastabend
Jakub Kicinski wrote: > On Tue, 20 Aug 2019 16:05:17 -0700 (PDT), David Miller wrote: > > Jakub, > > > > I just did a batch of networking -stable submissions, however I ran > > into some troubles with the various TLS backports. > > Yes, the TLS back ports are a little messy :S > > > I was able t

Re: various TLS bug fixes...

2019-08-20 Thread Jakub Kicinski
On Tue, 20 Aug 2019 16:05:17 -0700 (PDT), David Miller wrote: > Jakub, > > I just did a batch of networking -stable submissions, however I ran > into some troubles with the various TLS backports. Yes, the TLS back ports are a little messy :S > I was able to backport commit 414776621d10 ("net/tls

various TLS bug fixes...

2019-08-20 Thread David Miller
Jakub, I just did a batch of networking -stable submissions, however I ran into some troubles with the various TLS backports. I was able to backport commit 414776621d10 ("net/tls: prevent skb_orphan() from leaking TLS plain text with offload") to v5.2 but not to v4.19 I was not able to backpor