Re: tcp crash in net-2.6 tree

2007-04-02 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2007-04-02 02:02 > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Mon, 2 Apr 2007 11:38:51 +0300 (EEST) > > > [PATCH] [TCP]: Fix invalid skb referencing in LOST marker code > > > > The after() referenced an invalid skb if loop exited when skb had > > reached

Re: tcp crash in net-2.6 tree

2007-04-02 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 2 Apr 2007 11:38:51 +0300 (EEST) > [PATCH] [TCP]: Fix invalid skb referencing in LOST marker code > > The after() referenced an invalid skb if loop exited when skb had > reached sk_write_queue. I chose to move this part inside the loop > where

Re: tcp crash in net-2.6 tree

2007-04-02 Thread Ilpo Järvinen
On Sat, 31 Mar 2007, [EMAIL PROTECTED] wrote: > On 3/31/2007, "David Miller" <[EMAIL PROTECTED]> wrote: > > From: Thomas Graf <[EMAIL PROTECTED]> > > Date: Sat, 31 Mar 2007 00:10:54 +0200 > > > > > * David Miller <[EMAIL PROTECTED]> 2007-03-30 14:43 > > > > Let's not speculate, let's find out for

Re: tcp crash in net-2.6 tree

2007-03-31 Thread ijjarvin
On 3/31/2007, "David Miller" <[EMAIL PROTECTED]> wrote: > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Sat, 31 Mar 2007 00:10:54 +0200 > > > * David Miller <[EMAIL PROTECTED]> 2007-03-30 14:43 > > > Let's not speculate, let's find out for sure if snd_una is > > > surpassing high_seq while we're

Re: tcp crash in net-2.6 tree

2007-03-30 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Sat, 31 Mar 2007 00:10:54 +0200 > * David Miller <[EMAIL PROTECTED]> 2007-03-30 14:43 > > Let's not speculate, let's find out for sure if snd_una is > > surpassing high_seq while we're in this state. > > > > Andrew please give this debugging patch a spi

Re: tcp crash in net-2.6 tree

2007-03-30 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Fri, 30 Mar 2007 15:06:03 -0700 > > Andrew please give this debugging patch a spin, > > OK, will take a look at that this evening, hopefully. BTW, Thomas Graf can also reproduce this and he is about to post a log message from my patch. > distccd see

Re: tcp crash in net-2.6 tree

2007-03-30 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2007-03-30 14:43 > Let's not speculate, let's find out for sure if snd_una is > surpassing high_seq while we're in this state. > > Andrew please give this debugging patch a spin, and also what > is your workload? I'd like to play with it too. > > I've tried to

Re: tcp crash in net-2.6 tree

2007-03-30 Thread Andrew Morton
On Fri, 30 Mar 2007 14:43:47 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: "Ilpo_J__rvinen" <[EMAIL PROTECTED]> > Date: Fri, 30 Mar 2007 17:33:28 +0300 (EEST) > > > If there is nothing at high_seq (application hasn't given any data to/past > > that point), the search fails to find

Re: tcp crash in net-2.6 tree

2007-03-30 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 30 Mar 2007 17:33:28 +0300 (EEST) > If there is nothing at high_seq (application hasn't given any data to/past > that point), the search fails to find any skb and returns NULL... But I > have no idea how this can happen? As TCP does after(skb-

Re: tcp crash in net-2.6 tree

2007-03-30 Thread Andrew Morton
On Fri, 30 Mar 2007 17:33:28 +0300 (EEST) "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote: > On Thu, 29 Mar 2007, Andrew Morton wrote: > > > Full -mm lineup. The x86_64 box was acting as a distcc server at the time. > > > > Nothing hit the logs, I'm afraid. But almost all the info is in > > http://

Re: tcp crash in net-2.6 tree

2007-03-30 Thread Ilpo Järvinen
On Thu, 29 Mar 2007, Andrew Morton wrote: > Full -mm lineup. The x86_64 box was acting as a distcc server at the time. > > Nothing hit the logs, I'm afraid. But almost all the info is in > http://userweb.kernel.org/~akpm/s5000494.jpg > > > > It died in tcp_update_scoreboard_fack() here: > >

tcp crash in net-2.6 tree

2007-03-29 Thread Andrew Morton
Full -mm lineup. The x86_64 box was acting as a distcc server at the time. Nothing hit the logs, I'm afraid. But almost all the info is in http://userweb.kernel.org/~akpm/s5000494.jpg It died in tcp_update_scoreboard_fack() here: if ((!IsFack(tp) || !tcp_skb_timedout(sk, sk