Re: skbuff: Fix checksum start check in skb_postpull_rcsum

2015-10-01 Thread Herbert Xu
On Thu, Oct 01, 2015 at 08:15:43AM -0700, David Miller wrote: > > A patch with this and more should be in the 'net' tree already. Yes this looks much better. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

Re: skbuff: Fix checksum start check in skb_postpull_rcsum

2015-10-01 Thread David Miller
From: Herbert Xu Date: Thu, 1 Oct 2015 19:34:07 +0800 > In skb_postpull_rcsum the skb has already been pulled so we should > be testing whether the checksum start offset is non-negative rather > than how it compares to the length that we have pulled. > > Fixes: 6ae459bdaaee ("skbuff: Fix skb che

Re: skbuff: Fix checksum start check in skb_postpull_rcsum

2015-10-01 Thread Mike Galbraith
Yup, all better. Thanks. -Mike On Thu, 2015-10-01 at 19:34 +0800, Herbert Xu wrote: > In skb_postpull_rcsum the skb has already been pulled so we should > be testing whether the checksum start offset is non-negative rather > than how it compares to the length that we have pulled. > > Fi

skbuff: Fix checksum start check in skb_postpull_rcsum

2015-10-01 Thread Herbert Xu
In skb_postpull_rcsum the skb has already been pulled so we should be testing whether the checksum start offset is non-negative rather than how it compares to the length that we have pulled. Fixes: 6ae459bdaaee ("skbuff: Fix skb checksum flag on skb pull") Reported-by: Mike Galbraith Signed-off-b