Re: safe skb resetting after decapsulation and encapsulation

2018-05-14 Thread Md. Islam
On Sun, May 13, 2018 at 9:24 AM, Jason A. Donenfeld wrote: > On Sat, May 12, 2018 at 4:07 AM, Md. Islam wrote: >> I'm not an expert on this, but it looks about right. > > Really? Even zeroing between headers_start and headers_end? With the > latest RHEL 7.5 kernel's i40e driver, doing this result

Re: safe skb resetting after decapsulation and encapsulation

2018-05-13 Thread Jason A. Donenfeld
On Sat, May 12, 2018 at 4:07 AM, Md. Islam wrote: > I'm not an expert on this, but it looks about right. Really? Even zeroing between headers_start and headers_end? With the latest RHEL 7.5 kernel's i40e driver, doing this results in a crash in kfree. It's possible redhat is putting something sil

Re: safe skb resetting after decapsulation and encapsulation

2018-05-11 Thread Md. Islam
I'm not an expert on this, but it looks about right. You can take a look at build_skb() or __build_skb(). It shows the fields that needs to be set before passing to netif_receive_skb/netif_rx. On Fri, May 11, 2018 at 6:56 PM, Jason A. Donenfeld wrote: > Hey Netdev, > > A UDP skb comes in via the

safe skb resetting after decapsulation and encapsulation

2018-05-11 Thread Jason A. Donenfeld
Hey Netdev, A UDP skb comes in via the encap_rcv interface. I do a lot of wild things to the bytes in the skb -- change where the head starts, modify a few fragments, decrypt some stuff, trim off some things at the end, etc. In other words, I'm decapsulating the skb in a pretty intense way. I bene