Re: remove pci_enable_msix() V3

2017-04-11 Thread David Miller
From: Christoph Hellwig Date: Tue, 11 Apr 2017 13:01:20 +0200 > this series removes the remaining callers of the pci_enable_msix() > function and then the function itself. The final removal has been > Acked by Bjorn. > > Changes since V2: > - add another patch on Dave's request > - add variou

[PATCH 4/5] PCI: remove pci_enable_msix

2017-04-11 Thread Christoph Hellwig
Unused now that all callers switched to pci_alloc_irq_vectors. Signed-off-by: Christoph Hellwig Acked-by: Bjorn Helgaas --- drivers/pci/msi.c | 21 - include/linux/pci.h | 4 2 files changed, 25 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index d

remove pci_enable_msix() V3

2017-04-11 Thread Christoph Hellwig
Hi all, this series removes the remaining callers of the pci_enable_msix() function and then the function itself. The final removal has been Acked by Bjorn. Changes since V2: - add another patch on Dave's request - add various acks - spelling fixes in the commit logs Changes since V1: - rep

Re: [PATCH 4/4] PCI: remove pci_enable_msix

2017-04-06 Thread Bjorn Helgaas
On Thu, Apr 06, 2017 at 02:24:48PM +0200, Christoph Hellwig wrote: > Unused now that all callers switched to pci_alloc_irq_vectors. > > Signed-off-by: Christoph Hellwig I already acked this, but I can do it again :) (https://lkml.kernel.org/r/20170330230913.ga3...@bhelgaas-glaptop.roam.corp.goog

remove pci_enable_msix() V2

2017-04-06 Thread Christoph Hellwig
Hi all, this series removes the remaining callers of the pci_enable_msix() function and then the function itself. All remaining users in in network drivers, so if Bjorn is fine with it I'd like to handle it entirely through the netdev tree. Changes since V1: - replace the two previous thunderx

[PATCH 4/4] PCI: remove pci_enable_msix

2017-04-06 Thread Christoph Hellwig
Unused now that all callers switched to pci_alloc_irq_vectors. Signed-off-by: Christoph Hellwig --- drivers/pci/msi.c | 21 - include/linux/pci.h | 4 2 files changed, 25 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index d571bc330686..0042c365b29b

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-30 Thread Bjorn Helgaas
On Mon, Mar 27, 2017 at 10:29:36AM +0200, Christoph Hellwig wrote: > Unused now that all callers switched to pci_alloc_irq_vectors. > > Signed-off-by: Christoph Hellwig Acked-by: Bjorn Helgaas I assume this will be merged with the rest via the netdev tree. > --- > drivers/pci/msi.c | 21 --

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-30 Thread David Daney
On 03/30/2017 03:56 PM, Bjorn Helgaas wrote: On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote: On 03/27/2017 11:41 PM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: Use pci_enable_msix_{exact,range} for now, as I told you before. That still

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-30 Thread Bjorn Helgaas
On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote: > On 03/27/2017 11:41 PM, Christoph Hellwig wrote: > >On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: > >>>Use pci_enable_msix_{exact,range} for now, as I told you before. > >>> > >> > >>That still results in twice as many MS

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-28 Thread David Daney
On 03/27/2017 11:41 PM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: Use pci_enable_msix_{exact,range} for now, as I told you before. That still results in twice as many MSI-X being provisioned than are needed. How so? Except for the return value, a

RE: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-28 Thread David Laight
From: David Daney > Sent: 27 March 2017 18:31 > On 03/27/2017 10:11 AM, Christoph Hellwig wrote: > > On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote: > >> On 03/27/2017 01:29 AM, Christoph Hellwig wrote: > >>> Unused now that all callers switched to pci_alloc_irq_vectors. > >>> > >> > >

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread Christoph Hellwig
On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: >> Use pci_enable_msix_{exact,range} for now, as I told you before. >> > > That still results in twice as many MSI-X being provisioned than are needed. How so? Except for the return value, a pci_enable_msix_exact call with the same argu

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread David Daney
On 03/27/2017 10:11 AM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote: On 03/27/2017 01:29 AM, Christoph Hellwig wrote: Unused now that all callers switched to pci_alloc_irq_vectors. And you are aware that the ThunderX GPIO driver that I am attempting t

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread 'Christoph Hellwig'
On Mon, Mar 27, 2017 at 03:03:30PM +, David Laight wrote: > Indeed, but pci_enable_msix_range() only appeared in 3.14. > We have to support a wide range of kernels. > I think we've finally managed to get most of our customers off 2.6.18. That's your problem, not that of upstream kernel develop

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread Christoph Hellwig
On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote: > On 03/27/2017 01:29 AM, Christoph Hellwig wrote: >> Unused now that all callers switched to pci_alloc_irq_vectors. >> > > And you are aware that the ThunderX GPIO driver that I am attempting to > merge uses this interface. > > If this

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread David Daney
On 03/27/2017 01:29 AM, Christoph Hellwig wrote: Unused now that all callers switched to pci_alloc_irq_vectors. And you are aware that the ThunderX GPIO driver that I am attempting to merge uses this interface. If this patch gets merged, should I ask to revert it when the GPIO driver goes

RE: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread David Laight
From: 'Christoph Hellwig' > Sent: 27 March 2017 15:52 > On Mon, Mar 27, 2017 at 02:06:45PM +, David Laight wrote: > > Apart from all the 'out of tree' drivers that will need > > fixing and a conditional compile added. > > That has never been a reason for stopping linux kernel changes. I'm awa

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread 'Christoph Hellwig'
On Mon, Mar 27, 2017 at 02:06:45PM +, David Laight wrote: > Apart from all the 'out of tree' drivers that will need > fixing and a conditional compile added. That has never been a reason for stopping linux kernel changes. Never mind that your out of tree drivers should probably never have use

RE: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread David Laight
From: Christoph Hellwig > Sent: 27 March 2017 09:30 > > Unused now that all callers switched to pci_alloc_irq_vectors. Apart from all the 'out of tree' drivers that will need fixing and a conditional compile added. At least give us a couple of kernel versions to get it sorted. David

[PATCH 5/5] PCI: remove pci_enable_msix

2017-03-27 Thread Christoph Hellwig
Unused now that all callers switched to pci_alloc_irq_vectors. Signed-off-by: Christoph Hellwig --- drivers/pci/msi.c | 21 - include/linux/pci.h | 4 2 files changed, 25 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index d571bc330686..0042c365b29b

remove pci_enable_msix()

2017-03-27 Thread Christoph Hellwig
Hi all, this series removes the remaining callers of the pci_enable_msix() function and then the function itself. All remaining users in in network drivers, so if Bjorn is fine with it I'd like to handle it entirely through the netdev tree.