Re: qdisc hash table changes...

2016-08-10 Thread David Miller
From: Jiri Kosina Date: Tue, 9 Aug 2016 11:02:43 +0200 (CEST) > Does that strictly have to be a show-stopper for the qdisc hash > conversion, given the fact that the whole tree is building properly? I guess not. Please submit that change as a series, first patches that correct the build requir

Re: qdisc hash table changes...

2016-08-09 Thread Jiri Kosina
On Tue, 9 Aug 2016, David Miller wrote: > > It does indirectly pull in some networking headers, but it doesn't pull in > > netdevice.h (which is the place where the actual include of hashtable.h > > happens): > > It pulls in skbuff.h, so are you willing to bet forever that skbuff.h > won't indi

Re: qdisc hash table changes...

2016-08-09 Thread David Miller
From: Jiri Kosina Date: Tue, 9 Aug 2016 09:42:01 +0200 (CEST) > It does indirectly pull in some networking headers, but it doesn't pull in > netdevice.h (which is the place where the actual include of hashtable.h > happens): It pulls in skbuff.h, so are you willing to bet forever that skbuff.h

Re: qdisc hash table changes...

2016-08-09 Thread Jiri Kosina
On Mon, 8 Aug 2016, David Miller wrote: > I think there will still be build failures even with v6 due to symbol > clashes. > > For example, kernel/audit_tree.c defines HASH_SIZE as an enumeration > value, and that (indirectly) includes networking headers. It does indirectly pull in some networki

qdisc hash table changes...

2016-08-08 Thread David Miller
I think there will still be build failures even with v6 due to symbol clashes. For example, kernel/audit_tree.c defines HASH_SIZE as an enumeration value, and that (indirectly) includes networking headers. There are others all over the tree. I would therefore ask that you first fix the namespac