On Thu, Aug 30, 2007 at 05:01:31PM +0200, Johannes Berg wrote:
> Jochen had a patch: http://marc.info/?l=linux-wireless&m=118842715026614&w=2
That's exactly the right patch, please add
Acked-by: Matthew Wilcox <[EMAIL PROTECTED]>
I just checked over the commit that introduced the bug, and I didn
On Thu, 2007-08-30 at 07:49 -0700, Stephen Hemminger wrote:
> Devices aren't required to have ethtool_ops. The code there used to
> call ethtool directly, and it would handle the error cases. I'll rollup
> a fix this morning.
Great, thanks.
Jochen had a patch: http://marc.info/?l=linux-wireless&
On Thu, Aug 30, 2007 at 07:49:49AM -0700, Stephen Hemminger wrote:
> > > static int port_cost(struct net_device *dev)
> > > {
> > > if (dev->ethtool_ops->get_settings) {
> > >
> > >
> > > As far as I can figure out, dev->ethtool_ops is NULL and the
On Thu, 2007-08-30 at 07:49 -0700, Stephen Hemminger wrote:
> Devices aren't required to have ethtool_ops. The code there used to
> call ethtool directly, and it would handle the error cases. I'll rollup
> a fix this morning.
Great, thanks.
johannes
signature.asc
Description: This is a digital
Hi Jochen,
[added CCs since it affects bridge code]
> If I read this correctly, the EIP in the last line corresponds to
> net/bridge/br_if.c, line 36:
>
> static int port_cost(struct net_device *dev)
> {
> if (dev->ethtool_ops->get_settings) {
>^
