Herbert Xu wrote:
> On Mon, May 21, 2007 at 06:36:57PM +0200, Patrick McHardy wrote:
>
>>The IP stack shouldn't be too hard, we currently set skb->dev in
>>ip_output, after that we only have the POST_ROUTING hook and ip_fragment
>>which care. It wouldn't help with ipip/ip_gre though, at that point
On Mon, May 21, 2007 at 06:36:57PM +0200, Patrick McHardy wrote:
>
> The IP stack shouldn't be too hard, we currently set skb->dev in
> ip_output, after that we only have the POST_ROUTING hook and ip_fragment
> which care. It wouldn't help with ipip/ip_gre though, at that point
> skb->dev must poi
David Miller wrote:
> The post ip_output() case is very unfortunate. Perhaps we
> can tag the call sites, or if that doesn't work we can
> find some way to perhaps tag the dst as an input vs. output
> route in order to avoid this problem.
Tagging call-sites should make sure we don't use an addre
Herbert Xu wrote:
> Patrick McHardy <[EMAIL PROTECTED]> wrote:
>
>>This leaves the question what to do in the path after ip_output,
>>when skb->dev points to the output device. We don't know the
>>input device anymore, so there doesn't seem to be a way to make
>>it do what the sysctl promises.
>
Patrick McHardy <[EMAIL PROTECTED]> wrote:
>
> This leaves the question what to do in the path after ip_output,
> when skb->dev points to the output device. We don't know the
> input device anymore, so there doesn't seem to be a way to make
> it do what the sysctl promises.
Perhaps we could chang
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 17 May 2007 18:52:29 +0200
> [IPV4]: icmp: fix crash with sysctl_icmp_errors_use_inbound_ifaddr
>
> When icmp_send is called on the local output path before the
> packet hits ip_output, skb->dev is not set, causing a crash
> when sysctl_icmp_er
Hello,
On Thu, 17 May 2007, Patrick McHardy wrote:
> > saddr = iph->daddr;
> > if (!(rt->rt_flags & RTCF_LOCAL)) {
> > if (sysctl_icmp_errors_use_inbound_ifaddr)
> >
> >
> > saddr = inet_select_addr(skb_in->dev, 0, RT_SCOPE_LINK);
> > else
> >
Patrick McHardy wrote:
>>>BUG: unable to handle kernel NULL pointer dereference at virtual address
>>>00a8
>>>[...]
>>>EIP is at inet_select_addr+0x4/0x9f
>>>Call Trace:
>>>[] reject+0x0/0x4ae [ipt_REJECT]
>>>[] icmp_send+0x14d/0x39b
>>
>>
>>A REJECT target in the output chain will trigger this
8:46pm Patrick McHardy said:
James Morris wrote:
-- Forwarded message --
Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
From: Curtis Doty <[EMAIL PROTECTED]>
To: Linux Kernel <[EMAIL PROTECTED]>
Subject: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr
Summa
Patrick McHardy wrote:
> James Morris wrote:
>
>>-- Forwarded message --
>>Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
>>From: Curtis Doty <[EMAIL PROTECTED]>
>>To: Linux Kernel <[EMAIL PROTECTED]>
>>Subject: oops in net/ipv4/icmp.c:icmp_send() with
>>icmp_errors_use_inbound_ifadd
James Morris wrote:
> -- Forwarded message --
> Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
> From: Curtis Doty <[EMAIL PROTECTED]>
> To: Linux Kernel <[EMAIL PROTECTED]>
> Subject: oops in net/ipv4/icmp.c:icmp_send() with
> icmp_errors_use_inbound_ifaddr
>
> Summary: On a multi-h
-- Forwarded message --
Date: Mon, 14 May 2007 08:15:50 -0700 (PDT)
From: Curtis Doty <[EMAIL PROTECTED]>
To: Linux Kernel <[EMAIL PROTECTED]>
Subject: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr
Summary: On a multi-homed box, after turning on
/proc/sys/
12 matches
Mail list logo
