The ndo_start_xmit() method must return NETDEV_TX_OK if the DMA mapping
fails, after freeing the socket buffer.
Fix the mtk_star_netdev_start_xmit() function accordingly.
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Vincent Stehlé
Cc: David S. Miller
Cc: Bartos
On Thu, Nov 12, 2020 at 12:35 PM Vincent Stehlé
wrote:
>
> The ndo_start_xmit() method must return NETDEV_TX_OK if the DMA mapping
> fails, after freeing the socket buffer.
> Fix the mtk_star_netdev_start_xmit() function accordingly.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driv
On Thu, May 14, 2020 at 12:40:40PM +0200, Christoph Hellwig wrote:
> On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote:
> > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote:
> > > And call it directly from dlm instead of going through kernel_setsockopt.
> >
>
On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote:
> On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote:
> > And call it directly from dlm instead of going through kernel_setsockopt.
>
> The advantage on using kernel_setsockopt here is that sctp module will
> o
Greetings,
It was nice to have your contact and I hope this mail doesn't come to
you as a surprise or be treated as spam because i consider this info
highly classified and pertinent. I am Mr. Ahmed Zama, A Senior staff
in one of Bank here in Burkina Faso. I am contacting you with regards
to this p
Greetings,
I humbly solicit for your partnership to transfer €15 million Euros
into your personal or company’s account .I will offer you 30% of the
total sum,60% will be for me while 10% will set aside for expenses
that may be incurred on the process of transferring the fund. Contact
me for more d
.
Don't do any work if netif carrier is not OK.
Fixes: 8221c5eba8c13 (ixgbe: add AF_XDP zero-copy Tx support)
Signed-off-by: Jan Sokolowski
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driver
rk if netif carrier is not OK.
Fixes: 8221c5eba8c13 (ixgbe: add AF_XDP zero-copy Tx support)
Signed-off-by: Jan Sokolowski
---
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
b/driver
It is easier to distinguish "[ OK ]" from "[FAIL]" than "[PASS]".
Signed-off-by: Ido Schimmel
Suggested-by: David Ahern
Cc: David Ahern
---
tools/testing/selftests/net/forwarding/lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/te
Good Day,
I am in need of a reliable and trust worthy person to work with me in
receiving huge sum of money into his or her account. I will give you
the full details immediately you respond to this email.
Ahmed Zama
+22675844869
From: Or Gerlitz
Reaching here, means we didn't err anywhere, so lets just
return success.
Signed-off-by: Or Gerlitz
Reviewed-by: Jianbo Liu
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --gi
From: Jiri Pirko
Date: Wed, 7 Mar 2018 13:57:59 +0100
> From: Jiri Pirko
>
> Fix the "ok" action test so it checks that packet that is okayed does not
> continue to be processed by other rules. Fix error message as well.
>
> Signed-off-by: Jiri Pirko
> Reviewed-by: Ido Schimmel
Applied.
From: Jiri Pirko
Fix the "ok" action test so it checks that packet that is okayed does not
continue to be processed by other rules. Fix error message as well.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
---
tools/testing/selftests/net/forwarding/tc_actions.sh | 5 +++
From: Denis Du
Date: Sat, 24 Feb 2018 16:51:42 -0500
> Sometimes when physical lines have a just good noise to make the protocol
> handshaking fail, but the carrier detect still good. Then after remove of
> the noise, nobody will trigger this protocol to be start again to cause
> the link to neve
Sometimes when physical lines have a just good noise to make the protocol
handshaking fail, but the carrier detect still good. Then after remove of
the noise, nobody will trigger this protocol to be start again to cause
the link to never come back. The fix is when the carrier is still on, not
termi
From: Denis Du
Date: Wed, 21 Feb 2018 03:35:31 + (UTC)
> How is your thinking about this patch?
I cannot apply a patch which has been corrupted by your email client like
this.
Please send it properly again, plain ASCII text, and no trasnformations
by your email client.
You should send the
Hi, David:
How is your thinking about this patch?
>From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep 17 00:00:00 2001
From: Denis Du
Date: Mon, 15 Jan 2018 17:26:06 -0500
Subject: [PATCH] netdev: carrier detect ok, don't turn off negotiation
Sometimes when physical lines hav
Ok, I submit it again.
In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the
carrier detect still ok, but the protocol will fail. So if carrier detect ok,
don't turn off protocol negotiation
This patch is against the kernel version Linux 4.15-rc8
On Tu
From: Denis Du
Date: Tue, 6 Feb 2018 15:15:28 + (UTC)
> How do you think my patch?
>
> As you see, Krzysztof think my patch is ok to be accepted.
> But if you have a better idea to fix it,I am glad to see it. Anyway, this
> issue have to be fixed.
Please resubmit it and I
Hi, David:
How do you think my patch?
As you see, Krzysztof think my patch is ok to be accepted.
But if you have a better idea to fix it,I am glad to see it. Anyway, this issue
have to be fixed.
Denis DU
On Sunday, January 28, 2018, 9:34:15 AM EST, Krzysztof Halasa
wrote
Denis Du writes:
>>From the above code, I can get that only Carrier have some change, it
> will restart the protocol by hdlc_proto_start(dev);and thus the timer,
> the previous timer expired due to protocol fail.
>
> If carrier keep no change by if (hdlc->carrier == on)
> goto carrier_exi
Ok, I check the source code again. It have nothing to do with the interrupts,
it is related how the hdlc.c is implemented.
In drivers/net/wan/hdlc.c#L108
if (hdlc->carrier == on)
goto carrier_exit; /* no change in DCD line level */
hdlc->carrier = on;
if (!hdlc
The timer is supposed to be triggered by carrier detect interrupt. After remove
the line noise, the carrier detect interrupt is never triggered again, because
the carrier is always ok and it only trigger the timer once, Since the protocol
was terminated and no new interrupts happen, the link
From: Denis Du
Date: Tue, 16 Jan 2018 16:58:25 + (UTC)
> From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep 17 00:00:00 2001
> From: Denis Du
> Date: Mon, 15 Jan 2018 17:26:06 -0500
> Subject: [PATCH] netdev: carrier detect ok, don't turn off negotiation
>
>
In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the
carrier detect still ok, but the protocol will fail. So if carrier detect ok,
don't turn off protocol negotiation
This patch is against the kernel version Linux 4.15-rc8From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mo
From: Jiri Pirko
If action is "gact_ok", offload it to HW.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
b/drivers/net/ethernet/
t;
>>> not technical expert enough, i just wanted to give a short user
>>> feedback. for realtek wlan on atom, kernels up to 4.9.5 are ok, and
>>> kernel 4.10.0-rc7-g926af6273fc6 (arch linux-git version numbering) as
>>> well. kernels 4.9.6, 4.9.7, and 4.9.8
On 02/09/2017 01:43 PM, Bjorn Helgaas wrote:
[+cc rtl8192ce folks in case they've seen this]
On Thu, Feb 09, 2017 at 03:45:01PM +0100, rupert THURNER wrote:
hi,
not technical expert enough, i just wanted to give a short user
feedback. for realtek wlan on atom, kernels up to 4.9.5 are ok
[+cc rtl8192ce folks in case they've seen this]
On Thu, Feb 09, 2017 at 03:45:01PM +0100, rupert THURNER wrote:
> hi,
>
> not technical expert enough, i just wanted to give a short user
> feedback. for realtek wlan on atom, kernels up to 4.9.5 are ok, and
> kernel 4.10.0-rc7
From: Jamal Hadi Salim
This is what used to happen before:
tc filter add dev tap1 parent : protocol 0xfefe prio 10 \
u32 match u32 0 0 flowid 1:16 \
action ife decode allow mark ok
tc -s filter ls dev tap1 parent :
filter protocol [65278] pref 10 u32
filter protocol [65278
On Wed, 06 Dec 2006 12:44:26 -0500
jamal <[EMAIL PROTECTED]> wrote:
>
> a small one.
> I have a few more but just run out of cycles for now;
> if you dont mind holding before releasing for a short while so i can
> get them out I will appreciate it.
>
> cheers,
> jamal
>
applied all 4 thanks
a small one.
I have a few more but just run out of cycles for now;
if you dont mind holding before releasing for a short while so i can
get them out I will appreciate it.
cheers,
jamal
[DOC]: clarify "ok" and "pass"
A small fixup to elucidate the mysteries of acce
> What eeprom part and vendor are you using?
>
atmel 93C46B
> your eeprom seems to have 64 words. The addr_len being incorrect
> might be causing a problem. is there any chance you could try hard
> coding it?
I tried this, it did not help, the reads were still bogus. I'm still
leaning toward
33 matches
Mail list logo
