Re: new NAPI quota synchronization issue

2007-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 15:01:29 -0700 > There might be a future problem if some driver decided to change > weight often on the fly? Perhaps you need to sample it once in > start of napi_schedule. Fair enough, I checked the following into net-2.6.24 co

Re: new NAPI quota synchronization issue

2007-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2007 10:35:08 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 09:58:25 -0700 (PDT) > > > Probably a good way to deal with this is to simply make the quota > > handling stateless. > > > > The only reason we handl

Re: new NAPI quota synchronization issue

2007-09-19 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 09:58:25 -0700 (PDT) > Probably a good way to deal with this is to simply make the quota > handling stateless. > > The only reason we handle partial quota usage is to handle the > global netdev_budget. But we can simply "round up" and

new NAPI quota synchronization issue

2007-09-19 Thread David Miller
Ok, as has been hinted at with some postings from Krishna and others, we still have some mutual exclusion issues in the new NAPI code. In short, the napi->quota updates happen outside of the sections where the code stream "owns" the napi_struct instance, so it can be modified in parallel on multi