Re: net: netdev_sync_lower_features()

2020-05-18 Thread Cong Wang
On Mon, May 18, 2020 at 1:32 AM Michał Mirosław wrote: > > Hi! > > I just saw commit dd912306ff008 ("net: fix a potential recursive > NETDEV_FEAT_CHANGE") landing in Linux master. The problem with it (or > rather: with the netdev_sync_lower_features() function) is that > netdev_update_features() i

net: netdev_sync_lower_features()

2020-05-18 Thread Michał Mirosław
Hi! I just saw commit dd912306ff008 ("net: fix a potential recursive NETDEV_FEAT_CHANGE") landing in Linux master. The problem with it (or rather: with the netdev_sync_lower_features() function) is that netdev_update_features() is allowed to change more than one feature at a time, including force-