Re: net: BUG still has locks held in unix_stream_splice_read

2016-11-17 Thread Hannes Frederic Sowa
On 17.11.2016 22:44, Cong Wang wrote: > On Sun, Oct 9, 2016 at 8:14 PM, Al Viro wrote: >> E.g what will happen if some code does a read on AF_UNIX socket with >> some local mutex held? AFAICS, there are exactly two callers of >> freezable_schedule_timeout() - this one and one in XFS; the latter i

Re: net: BUG still has locks held in unix_stream_splice_read

2016-11-17 Thread Cong Wang
On Sun, Oct 9, 2016 at 8:14 PM, Al Viro wrote: > E.g what will happen if some code does a read on AF_UNIX socket with > some local mutex held? AFAICS, there are exactly two callers of > freezable_schedule_timeout() - this one and one in XFS; the latter is > in a kernel thread where we do have goo

Re: net: BUG still has locks held in unix_stream_splice_read

2016-11-17 Thread Dmitry Vyukov
On Mon, Oct 10, 2016 at 10:01 AM, Dmitry Vyukov wrote: > On Mon, Oct 10, 2016 at 5:14 AM, Al Viro wrote: >> On Mon, Oct 10, 2016 at 03:46:07AM +0100, Al Viro wrote: >>> On Sun, Oct 09, 2016 at 12:06:14PM +0200, Dmitry Vyukov wrote: >>> > I suspect this is: >>> > >>> > commit 25869262ef7af24ccde98

Re: net: BUG still has locks held in unix_stream_splice_read

2016-10-10 Thread Dmitry Vyukov
On Mon, Oct 10, 2016 at 5:14 AM, Al Viro wrote: > On Mon, Oct 10, 2016 at 03:46:07AM +0100, Al Viro wrote: >> On Sun, Oct 09, 2016 at 12:06:14PM +0200, Dmitry Vyukov wrote: >> > I suspect this is: >> > >> > commit 25869262ef7af24ccde988867ac3eb1c3d4b88d4 >> > Author: Al Viro >> > Date: Sat Sep

Re: net: BUG still has locks held in unix_stream_splice_read

2016-10-09 Thread Al Viro
On Mon, Oct 10, 2016 at 03:46:07AM +0100, Al Viro wrote: > On Sun, Oct 09, 2016 at 12:06:14PM +0200, Dmitry Vyukov wrote: > > I suspect this is: > > > > commit 25869262ef7af24ccde988867ac3eb1c3d4b88d4 > > Author: Al Viro > > Date: Sat Sep 17 21:02:10 2016 -0400 > > skb_splice_bits(): get ri

Re: net: BUG still has locks held in unix_stream_splice_read

2016-10-09 Thread Al Viro
On Sun, Oct 09, 2016 at 12:06:14PM +0200, Dmitry Vyukov wrote: > I suspect this is: > > commit 25869262ef7af24ccde988867ac3eb1c3d4b88d4 > Author: Al Viro > Date: Sat Sep 17 21:02:10 2016 -0400 > skb_splice_bits(): get rid of callback > since pipe_lock is the outermost now, we don't need

Re: net: BUG still has locks held in unix_stream_splice_read

2016-10-09 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer on commit b66484cd74706fa8681d051840fe4b18a3da40ff (Oct 7), I am getting: [ BUG: syz-executor/15138 still has locks held! ] 4.8.0+ #29 Not tainted - 1 lock held by syz-executor/15138: #0: (&pipe->mutex/1){+.+.+.}, at: [<

net: BUG still has locks held in unix_stream_splice_read

2016-10-09 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer on commit b66484cd74706fa8681d051840fe4b18a3da40ff (Oct 7), I am getting: [ BUG: syz-executor/15138 still has locks held! ] 4.8.0+ #29 Not tainted - 1 lock held by syz-executor/15138: #0: (&pipe->mutex/1){+.+.+.}, at: [<