Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread David Miller
From: Cong Wang Date: Fri, 21 Apr 2017 11:55:04 -0700 > On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds > wrote: >> On Fri, Apr 21, 2017 at 5:48 AM, Andrey Konovalov >> wrote: >>> >>> I've got the following error report while fuzzing the kernel with syzkaller. >>> >>> [ cut here ]

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread David Miller
From: Linus Torvalds Date: Fri, 21 Apr 2017 10:42:48 -0700 > Over to Eric and networking people. This oops is user-triggerable, and > leaves the machine in a bad state (the original BUG_ON() and the new > GP fault both happen while holding the RTNL, so networking is not > healthy afterwards. I h

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread Cong Wang
On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds wrote: > On Fri, Apr 21, 2017 at 5:48 AM, Andrey Konovalov > wrote: >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> [ cut here ] >> kernel BUG at net/core/dev.c:6813! > > Another use

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread Nikolay Aleksandrov
On 21/04/17 20:42, Linus Torvalds wrote: > On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds > wrote: >> >> I'm assuming that the real cause is simply that "dev->reg_state" ends >> up being NETREG_UNREGISTERING or something. Maybe the BUG_ON() could >> be just removed, and replaced by the previous

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread Linus Torvalds
On Fri, Apr 21, 2017 at 5:48 AM, Andrey Konovalov wrote: > > I've got the following error report while fuzzing the kernel with syzkaller. > > [ cut here ] > kernel BUG at net/core/dev.c:6813! Another useless BUG_ON() that (a) kills the machine (b) doesn't tell the actua

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread Linus Torvalds
On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds wrote: > > I'm assuming that the real cause is simply that "dev->reg_state" ends > up being NETREG_UNREGISTERING or something. Maybe the BUG_ON() could > be just removed, and replaced by the previous warning about > NETREG_UNINITIALIZED. > > Somethi