Re: net/can: warning in bcm_connect/proc_register

2016-10-24 Thread Oliver Hartkopp
Hello Andrey, hello Cong, thanks for catching this issue. I added lock_sock() and a check for a failing proc_create_data() below. Can you please check if it solved the issue? I tested the patched version with the stress tool as advised by Andrey and did not see any problems in dmesg anymore.

Re: net/can: warning in bcm_connect/proc_register

2016-10-24 Thread Andrey Konovalov
Hi Cong, I'm able to reproduce it by running https://gist.github.com/xairy/33f2eb6bf807b004e643bae36c3d02d7 in a tight parallel loop with stress (https://godoc.org/golang.org/x/tools/cmd/stress): $ gcc -lpthread tmp.c $ ./stress ./a.out The C program was generated from the following syzkaller pro

Re: net/can: warning in bcm_connect/proc_register

2016-10-24 Thread Cong Wang
On Mon, Oct 24, 2016 at 9:21 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > WARNING: CPU: 0 PID: 32451 at fs/proc/generic.c:345 proc_register+0x25e/0x300 > proc_dir_entry 'can-bcm/249757' already registered > Kernel panic - not syn

net/can: warning in bcm_connect/proc_register

2016-10-24 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: WARNING: CPU: 0 PID: 32451 at fs/proc/generic.c:345 proc_register+0x25e/0x300 proc_dir_entry 'can-bcm/249757' already registered Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 32451 Comm: syz-executor Not