Re: memory leak in do_ipv6_setsockopt

2015-12-01 Thread Daniel Borkmann
On 12/01/2015 03:38 PM, Eric Dumazet wrote: On Tue, 2015-12-01 at 15:24 +0100, Daniel Borkmann wrote: On 12/01/2015 03:16 PM, Eric Dumazet wrote: On Tue, 2015-12-01 at 15:07 +0100, Daniel Borkmann wrote: Yeah, we miss inet6_destroy_sock() in SCTP. :-( Looks good to me. OK, I will send a fo

Re: memory leak in do_ipv6_setsockopt

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 15:24 +0100, Daniel Borkmann wrote: > On 12/01/2015 03:16 PM, Eric Dumazet wrote: > > On Tue, 2015-12-01 at 15:07 +0100, Daniel Borkmann wrote: > > > >> Yeah, we miss inet6_destroy_sock() in SCTP. :-( > >> > >> Looks good to me. > > > > OK, I will send a formal (and tested ;)

Re: memory leak in do_ipv6_setsockopt

2015-12-01 Thread Daniel Borkmann
On 12/01/2015 03:16 PM, Eric Dumazet wrote: On Tue, 2015-12-01 at 15:07 +0100, Daniel Borkmann wrote: Yeah, we miss inet6_destroy_sock() in SCTP. :-( Looks good to me. OK, I will send a formal (and tested ;) ) patch. I was shortly wondering whether there could be a use-after-free by doing

Re: memory leak in do_ipv6_setsockopt

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 15:07 +0100, Daniel Borkmann wrote: > Yeah, we miss inet6_destroy_sock() in SCTP. :-( > > Looks good to me. OK, I will send a formal (and tested ;) ) patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...

Re: memory leak in do_ipv6_setsockopt

2015-12-01 Thread Daniel Borkmann
On 12/01/2015 02:36 PM, Eric Dumazet wrote: On Tue, 2015-12-01 at 13:27 +0100, Dmitry Vyukov wrote: Hello, The following program causes a memory leak : // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include int

Re: memory leak in do_ipv6_setsockopt

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 13:27 +0100, Dmitry Vyukov wrote: > Hello, > > The following program causes a memory leak : > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include > #include > > int main() > { >

memory leak in do_ipv6_setsockopt

2015-12-01 Thread Dmitry Vyukov
Hello, The following program causes a memory leak : // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include int main() { long r1 = syscall(SYS_socket, PF_INET6, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROT