Re: iproute2 mpls max labels

2016-07-23 Thread Roopa Prabhu
On 7/21/16, 12:43 PM, Magnus Bergroth wrote: > >> Roopa Prabhu >> 21 juli 2016 20:53 >> I did not realize it is hardcoded to 8 in iproute2. Because kernel has >> a hard coded limit of >> 2. >> I think we need to fix it in a few places: >> a) we should move the ker

Re: iproute2 mpls max labels

2016-07-23 Thread Roopa Prabhu
On 7/22/16, 12:20 PM, Eric W. Biederman wrote: > Roopa Prabhu writes: > >> On 7/21/16, 1:00 PM, Eric W. Biederman wrote: >>> Roopa Prabhu writes: >>> >>> [snip] >>> I did not realize it is hardcoded to 8 in iproute2. Because kernel has a >>> hard coded limit of >>> 2. >>> I think we need to fix

Re: iproute2 mpls max labels

2016-07-22 Thread Eric W. Biederman
Magnus Bergroth writes: >> Eric W. Biederman >> a) I just looked and the kernel netlink protocol does not have a limit. >>The kernel does have a limit but the netlink protocol does not so >>there is no point in exporting a limit in a uapi header, it will >

Re: iproute2 mpls max labels

2016-07-22 Thread Eric W. Biederman
Roopa Prabhu writes: > On 7/21/16, 1:00 PM, Eric W. Biederman wrote: >> Roopa Prabhu writes: >> >>> On 7/16/16, 11:24 AM, Magnus Bergroth wrote: Wanted to use more than the default maximum of 8 mpls labels. Max labels seems to be hardcode to 8 in two places. --- iproute2-4.6.

Re: iproute2 mpls max labels

2016-07-21 Thread Roopa Prabhu
On 7/21/16, 1:00 PM, Eric W. Biederman wrote: > Roopa Prabhu writes: > >> On 7/16/16, 11:24 AM, Magnus Bergroth wrote: >>> Wanted to use more than the default maximum of 8 mpls labels. Max labels >>> seems to be hardcode to 8 in two places. >>> >>> --- iproute2-4.6.0/lib/utils.c2016-05-18 20:5

Re: iproute2 mpls max labels

2016-07-21 Thread Magnus Bergroth
> Eric W. Biederman > 21 juli 2016 22:00 > Roopa Prabhu writes: > >> On 7/16/16, 11:24 AM, Magnus Bergroth wrote: >>> Wanted to use more than the default maximum of 8 mpls labels. Max labels >>> seems to be hardcode to 8 in two places. >>> >>> --- iproute2-4.6.0/li

Re: iproute2 mpls max labels

2016-07-21 Thread Eric W. Biederman
Roopa Prabhu writes: > On 7/16/16, 11:24 AM, Magnus Bergroth wrote: >> Wanted to use more than the default maximum of 8 mpls labels. Max labels >> seems to be hardcode to 8 in two places. >> >> --- iproute2-4.6.0/lib/utils.c2016-05-18 20:56:02.0 +0200 >> +++ iproute2-4.6.0-bergroth/li

Re: iproute2 mpls max labels

2016-07-21 Thread Magnus Bergroth
> Roopa Prabhu > 21 juli 2016 20:53 > I did not realize it is hardcoded to 8 in iproute2. Because kernel has > a hard coded limit of > 2. > I think we need to fix it in a few places: > a) we should move the kernel #define to a uapi header file which > iproute2 c

Re: iproute2 mpls max labels

2016-07-21 Thread Roopa Prabhu
On 7/16/16, 11:24 AM, Magnus Bergroth wrote: > Wanted to use more than the default maximum of 8 mpls labels. Max labels > seems to be hardcode to 8 in two places. > > --- iproute2-4.6.0/lib/utils.c2016-05-18 20:56:02.0 +0200 > +++ iproute2-4.6.0-bergroth/lib/utils.c2016-07-16 20:12:

iproute2 mpls max labels

2016-07-16 Thread Magnus Bergroth
Wanted to use more than the default maximum of 8 mpls labels. Max labels seems to be hardcode to 8 in two places. --- iproute2-4.6.0/lib/utils.c2016-05-18 20:56:02.0 +0200 +++ iproute2-4.6.0-bergroth/lib/utils.c2016-07-16 20:12:10.714958071 +0200 @@ -476,7 +476,7 @@ addr-