Re: [PATCH net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-02-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 12:12:38 +0300 you wrote: > There are several error handling bugs in mscc_ocelot_init_ports(). I > went through the code, and carefully audited it and made fixes and > cleanups. &g

[PATCH net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-02-02 Thread Dan Carpenter
There are several error handling bugs in mscc_ocelot_init_ports(). I went through the code, and carefully audited it and made fixes and cleanups. 1) The ocelot_probe_port() function didn't have a mirror release function so it was hard to follow. I created the ocelot_release

[PATCH v2 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-26 Thread Dan Carpenter
There are several error handling bugs in mscc_ocelot_init_ports(). I went through the code, and carefully audited it and made fixes and cleanups. 1) The ocelot_probe_port() function didn't have a mirror release function so it was hard to follow. I created the ocelot_release

[PATCH 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-26 Thread Dan Carpenter
There are several error handling bugs in mscc_ocelot_init_ports(). I went through the code, and carefully audited it and made fixes and cleanups. 1) The ocelot_probe_port() function didn't have a mirror release function so it was hard to follow. I created the ocelot_release

Re: [PATCH v2 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-26 Thread Vladimir Oltean
On Tue, Jan 26, 2021 at 10:27:53AM +0300, Dan Carpenter wrote: > > If you resend, can you please squash this diff on top of your patch? > > Yep. I will resend. Thanks for basically writing v2 for me. Your > review comments were very clear but code is always 100% clear so that's > really great.

Re: [PATCH v2 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-26 Thread Dan Carpenter
On Mon, Jan 25, 2021 at 04:18:07PM +, Vladimir Oltean wrote: > Hi Dan, > > On Mon, Jan 25, 2021 at 11:42:03AM +0300, Dan Carpenter wrote: > > diff --git a/drivers/net/ethernet/mscc/ocelot_net.c > > b/drivers/net/ethernet/mscc/ocelot_net.c > > index 9553eb3e441c..875ab8532d8c 100644 > > --- a/

Re: [PATCH 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-25 Thread Dan Carpenter
Oops. Please ignore this patch. Part of it is missing. regards, dan carpenter

Re: [PATCH v2 1/2 net-next] net: mscc: ocelot: fix error handling bugs in mscc_ocelot_init_ports()

2021-01-25 Thread Vladimir Oltean
Hi Dan, On Mon, Jan 25, 2021 at 11:42:03AM +0300, Dan Carpenter wrote: > diff --git a/drivers/net/ethernet/mscc/ocelot_net.c > b/drivers/net/ethernet/mscc/ocelot_net.c > index 9553eb3e441c..875ab8532d8c 100644 > --- a/drivers/net/ethernet/mscc/ocelot_net.c > +++ b/drivers/net/ethernet/mscc/ocelot

Re: [PATCH] cfg80211: fix station info handling bugs

2018-01-18 Thread David Miller
From: Johannes Berg Date: Tue, 16 Jan 2018 23:20:22 +0100 > From: Johannes Berg > > Fix two places where the structure isn't initialized to zero, > and thus can't be filled properly by the driver. > > Fixes: 4a4b8169501b ("cfg80211: Accept multiple RSSI thresholds for CQM") > Fixes: 9930380f0b

[PATCH] cfg80211: fix station info handling bugs

2018-01-16 Thread Johannes Berg
From: Johannes Berg Fix two places where the structure isn't initialized to zero, and thus can't be filled properly by the driver. Fixes: 4a4b8169501b ("cfg80211: Accept multiple RSSI thresholds for CQM") Fixes: 9930380f0bd8 ("cfg80211: implement IWRATE") Signed-off-by: Johannes Berg --- Dave,

handling bugs...

2007-11-20 Thread David Miller
Some of you wireless guys should really be ashamed of yourselves how you handled the zd1211rw bugs reported by the sparc64 user. Instead of helping the user work towards getting a working setup, analyzing their bug and presenting test patches for the user to try, all of you passed the buck around