Re: git-net warnings

2005-12-11 Thread Benjamin LaHaise
On Sat, Dec 10, 2005 at 11:28:33PM -0800, Andrew Morton wrote: > > This is from my x86_64 box's boot output: > > > Badness in sk_del_node_init at include/net/sock.h:330 I wonder why this didn't trigger on my box. It looks like I missed the sock_put in the error codepath, which the following f

Re: git-net warnings

2005-12-11 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 11 Dec 2005 00:39:42 -0800 > "David S. Miller" <[EMAIL PROTECTED]> wrote: > > > > Andrew, does reverting the following make the problem go > > away? > > yup. Ok, thanks for testing. I'll revert until we figure out exactly what's going on here.

Re: git-net warnings

2005-12-11 Thread Andrew Morton
"David S. Miller" <[EMAIL PROTECTED]> wrote: > > Andrew, does reverting the following make the problem go > away? yup. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: git-net warnings

2005-12-11 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 11 Dec 2005 00:19:58 -0800 > Ah, sorry. -mm's git-net is from > git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.16.git > > I tend to prefer the latest and greatest of everything. Ok. Ben, you're not off the hook sorry :-) Ma

Re: git-net warnings

2005-12-11 Thread Andrew Morton
"David S. Miller" <[EMAIL PROTECTED]> wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sat, 10 Dec 2005 23:46:36 -0800 > > > It gets uglier. This is with just 2.6.15-rc5, linus.patch and > > git-net.patch, btw: > > > > We get a slab scribble. ppc64 and x86 seem OK. For some reason, x8

Re: git-net warnings

2005-12-11 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sat, 10 Dec 2005 23:46:36 -0800 > It gets uglier. This is with just 2.6.15-rc5, linus.patch and > git-net.patch, btw: > > We get a slab scribble. ppc64 and x86 seem OK. For some reason, x86_64 > doesn't like it. This rules out Ben's AF_UNIX optimiz

Re: git-net warnings

2005-12-10 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sat, 10 Dec 2005 23:28:33 -0800 > Badness in sk_del_node_init at include/net/sock.h:330 > > Call Trace:{local_bh_enable+119} > {__unix_remove_socket+98} >{unix_release_sock+57} > {unix_release+33} >{sock_release+27} {sock_close+55} >

Re: git-net warnings

2005-12-10 Thread Andrew Morton
It gets uglier. This is with just 2.6.15-rc5, linus.patch and git-net.patch, btw: We get a slab scribble. ppc64 and x86 seem OK. For some reason, x86_64 doesn't like it. Starting pcmcia: [ OK ] Setting network parameters: general protection fault: [1] <3>Slab corrupt2 Redzone: 0x5a

git-net warnings

2005-12-10 Thread Andrew Morton
This is from my x86_64 box's boot output: Badness in sk_del_node_init at include/net/sock.h:330 Call Trace:{local_bh_enable+119} {__unix_remove_socket+98} {unix_release_sock+57} {unix_release+33} {sock_release+27} {sock_close+55} {__fput+195} {fput+21} {filp_close+