Re: fq_codel and skb->hash

2017-01-18 Thread Andrew Collins
On 01/17/2017 08:14 AM, Eric Dumazet wrote: Right, but that might add overhead in cases we do not need skb->hash after IPsec . I've heard IPsec is already quite slow :/ I've been running with the following change locally with good results: --- a/net/sched/sch_fq_codel.c +++ b/net/sched/sch_fq_

Re: fq_codel and skb->hash

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 13:21 -0700, Andrew Collins wrote: > > Any interest in me spinning a real patch for this? I agree that it'd be > better > if we were guaranteed to get a pre-encryption flow hash for any IPsec traffic, > but in my particular case I don't care, as I control the HW and can ma

Re: fq_codel and skb->hash

2017-01-17 Thread Eric Dumazet
On Mon, 2017-01-16 at 22:18 -0800, Tom Herbert wrote: > On Mon, Jan 16, 2017 at 6:34 PM, Eric Dumazet wrote: > > On Mon, 2017-01-16 at 17:44 -0800, Eric Dumazet wrote: > >> On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > > > >> > Is there a better way to manage flow separation in rout

Re: fq_codel and skb->hash

2017-01-16 Thread Tom Herbert
On Mon, Jan 16, 2017 at 6:34 PM, Eric Dumazet wrote: > On Mon, 2017-01-16 at 17:44 -0800, Eric Dumazet wrote: >> On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > >> > Is there a better way to manage flow separation in routed+encapsulated >> > traffic? >> >> Encapsulated traffic is fin

Re: fq_codel and skb->hash

2017-01-16 Thread Eric Dumazet
On Mon, 2017-01-16 at 17:44 -0800, Eric Dumazet wrote: > On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > > Is there a better way to manage flow separation in routed+encapsulated > > traffic? > > Encapsulated traffic is fine, since flow dissector skips encap header(s) > up to the L4

Re: fq_codel and skb->hash

2017-01-16 Thread Eric Dumazet
On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > The fq_codel packet scheduler always regenerates the skb flow hash. Is there > any reason > to do this other than the recent hash perturbation additions? > > I ask because I have a case where an incoming set of TCP flows is > encapsulat

fq_codel and skb->hash

2017-01-16 Thread Andrew Collins
The fq_codel packet scheduler always regenerates the skb flow hash. Is there any reason to do this other than the recent hash perturbation additions? I ask because I have a case where an incoming set of TCP flows is encapsulated in a single ipsec tunnel, which is then classified on egress into