On Thu, 28 Jan 2021 21:45:02 + Nguyen, Anthony L wrote:
> > drivers/net/ethernet/intel/e100.c | 92 -
>
> My apologies, this patch slipped through the cracks for me. I will send
> it in my next net-next 1GbE series or Jakub you can take it directly
on e1, e2;
> @@
> -pci_set_dma_mask(e1, e2)
> +dma_set_mask(&e1->dev, e2)
>
> @@
> expression e1, e2;
> @@
> -pci_set_consistent_dma_mask(e1, e2)
> +dma_set_coherent_mask(&e1->dev, e2)
>
> Signed-off-by: Christophe JAILLET
> Tested-by: Aaron Br
janitors&m=158745678307186&w=4
First sent on 18 Jul. 2020, see:
https://lore.kernel.org/lkml/20200718115546.358240-1-christophe.jail...@wanadoo.fr/
It still applies cleanly with latest linux-next
Tested tag, see:
https://lore.kernel.org/lkml/dm6pr11mb289001e5538e536f0cb60a1fb
>Let us know if you are interested in our fuzzing/static analysis setup.
>We're planning to submit a paper soon and we will publish the source >code
>along with the paper.
We already have an own static analysis/fuzzing frame work, but it's not
released yet.
-Andi
uosl.org
>> Cc: dos...@vmware.com ; jesse.brandeb...@intel.com
>> ; anthony.l.ngu...@intel.com
>> ; Morbitzer, Mathias
>> ; Robert Buhren
>> ; f...@sect.tu-berlin.de
>> ; Banse, Christian
>> ; brijesh.si...@amd.com
>> ; thomas.lenda...@amd.com ;
>&g
> ; Morbitzer, Mathias
> ; Robert Buhren
> ; f...@sect.tu-berlin.de
> ; Banse, Christian
> ; brijesh.si...@amd.com
> ; thomas.lenda...@amd.com ;
> pv-driv...@vmware.com ; martin.b.ra...@gmail.com
>
> Subject: Security issue with vmxnet3 and e100 for AMD SEV(
uosl.org;
> linux-ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] e100: switch from 'pci_' to 'dma_' API
>
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has bee
GFP_ATOMIC allocation. The next invoked function e100_alloc_cbs() is
using GFP_KERNEL already.
Change the allocation mode in e100_rx_alloc_list() to GFP_KERNEL as well.
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Thomas Gleixner
---
drivers/net/ethernet/intel/e100.c |4
Cc: Jakub Kicinski
Cc: intel-wired-...@lists.osuosl.org
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/intel/e100.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1531,7 +1531,7 @@ static int e1
sable().
Compile-tested only.
Signed-off-by: Vaibhav Gupta
Tested-by: Aaron Brown
Signed-off-by: Tony Nguyen
---
drivers/net/ethernet/intel/e100.c | 32 ++-
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/driver
p;e1->dev, e2)
@@
expression e1, e2;
@@
-pci_set_consistent_dma_mask(e1, e2)
+dma_set_coherent_mask(&e1->dev, e2)
Signed-off-by: Christophe JAILLET
---
If needed, see post from Christoph Hellwig on the kernel-janitors ML:
https://marc.info/?l=kernel-janitors&m=1587456
ger.kernel.org;
> linux-ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org;
> sk...@linuxfoundation.org; linux-kernel-ment...@lists.linuxfoundation.org
> Subject: [Intel-wired-lan] [PATCH v1 5/5] e100: use generic power management
>
> With legacy PM hooks, it was the responsibility of a
ested only.
Signed-off-by: Vaibhav Gupta
---
drivers/net/ethernet/intel/e100.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 1b8d015ebfb0..7506fb5eca8f 100644
--- a/dr
From: YueHaibing
Fix a static code checker warning:
drivers/net/ethernet/intel/e100.c:1349
e100_load_ucode_wait() warn: passing zero to 'PTR_ERR'
Signed-off-by: YueHaibing
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/e100.c | 4 ++--
1 file
..@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] e100: Fix passing zero to
> 'PTR_ERR' warning in e100_load_ucode_wait
>
> Fix a static code checker warning:
> drivers/net/ethernet/intel/e100.c:1349
> e100_load_ucode_wait() warn: passing zero to 'PTR_ER
Fix a static code checker warning:
drivers/net/ethernet/intel/e100.c:1349
e100_load_ucode_wait() warn: passing zero to 'PTR_ERR'
Signed-off-by: YueHaibing
---
drivers/net/ethernet/intel/e100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethe
Add the SPDX-Lincense-Identifier to the Intel wired Ethernet *.rst
kernel documentation.
Signed-off-by: Jeff Kirsher
Tested-by: Andrew Bowers
Tested-by: Aaron Brown
---
Documentation/networking/e100.rst | 3 ++-
Documentation/networking/e1000.rst | 3 ++-
2 files changed, 4 insertions(+), 2
From: Mauro Carvalho Chehab
Documentation/networking/e100.rst:57: WARNING: Literal block expected; none
found.
Documentation/networking/e100.rst:68: WARNING: Literal block expected; none
found.
Documentation/networking/e100.rst:75: WARNING: Literal block expected; none
found
x-next) Add
> >>> linux-next specific files for 20180621
> >>>
> >>>
> >>> I split the patches in between the two drivers to enable use of the
> >>> 'Fixes:' tag.
> >>>
> >>> Tobin C. Harding (4):
>
documentation.
Signed-off-by: Jeff Kirsher
Tested-by: Aaron Brown
---
.../networking/{e100.txt => e100.rst} | 60 +--
Documentation/networking/index.rst| 1 +
MAINTAINERS | 2 +-
3 files changed, 29 insertions(+), 34 deleti
---
drivers/net/ethernet/intel/e100.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 44b3937f7e81..29486478836e 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel
From: Romain Perier
Date: Fri, 15 Dec 2017 20:31:21 +0100
> From: Romain Perier
>
> The PCI pool API is deprecated. This commit replaces the PCI pool old
> API by the appropriate function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> Acked-by: Peter Senna Tschudin
> Acked-by: Jef
/e100.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 44b3937f7e81..29486478836e 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -607,7 +607,7
fw could be NULL and put into PTR_ERR
also zero in PTR_ERR will be translated into success return statement
Signed-off-by: Vasyl Gomonovych
---
drivers/net/ethernet/intel/e100.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers
/e100.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 44b3937f7e81..29486478836e 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -607,7 +607,7
/e100.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 184f11242f56..ba52475b9ff0 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -607,7 +607,7
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
--- a/drivers/net/ethernet/intel/e1
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12
by the appropriate function with the DMA pool API.
>>>
>>> Signed-off-by: Romain Perier
>>> Acked-by: Peter Senna Tschudin
>>> Tested-by: Peter Senna Tschudin
>>> ---
>>> drivers/net/ethernet/intel/e100.c | 12 ++--
>>> 1 file
igned-off-by: Romain Perier
> > Acked-by: Peter Senna Tschudin
> > Tested-by: Peter Senna Tschudin
> > ---
> > drivers/net/ethernet/intel/e100.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Acked-by: Jeff Kirsher
>
> My onl
ter Senna Tschudin
> ---
> drivers/net/ethernet/intel/e100.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Jeff Kirsher
My only concern is:
- what hardware did this get tested with? Since this affects all e100
parts, it would be hard to believe that all the af
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12 ++--
1 file changed, 6
The PCI pool API is deprecated. This commits replaces the PCI pool old
API by the appropriated function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12 ++--
1 file changed, 6
t; Signed-off-by: Romain Perier
> ---
> drivers/net/ethernet/intel/e100.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c
> b/drivers/net/ethernet/intel/e100.c
> index 2b7323d..d1002c2 100644
> --- a/
From: Philippe Reynes
Date: Sat, 7 Jan 2017 23:18:07 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes
Applied.
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/intel/e100.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c
Apparently the e100.txt document contained a "License" section left
over from days of old, which does not need to be in the kernel
documentation. So clean it up..
CC: John Ronciak
Signed-off-by: Jeff Kirsher
Tested-by: Aaron Brown
---
Documentation/networking/e100.txt | 14 ---
Signed-off-by: Jia-Ju Bai
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/e100.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index d2657a4..767c161 100644
--- a/drivers/net/et
: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/e100.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 767c161..068789e 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b
..@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] e100: Add a check after pci_pool_create
> to avoid null pointer dereference
>
> The driver lacks the check of nic->cbs_pool after pci_pool_create
> in e100_probe. When this function is failed, a null pointer dereference
> occurs
..@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] e100: Release skb when DMA mapping is
> failed in e100_xmit_prepare
>
> When pci_dma_mapping_error in e100_xmit_prepare is failed, the skb buffer
> allocated by netdev_alloc_skb_ip_align in e100_rx_alloc_skb is not
> released, w
/e100.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index d2657a4..cc90616 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1770,8 +1770,11 @@ static int
Ju Bai
---
drivers/net/ethernet/intel/e100.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index d2657a4..767c161 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -
sysenter_past_esp+0x5f/0xa5
> >>>> [ 8805.292038] ===
> >>>> [ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
> >>>> [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
> >>&g
t;>> [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
>>>> [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
>>>> state [S3]
>>>> [ 8805.376670] Back to C!
>>>>
>>>> Interface is unused normally (only for net
tering sleep
>>> state [S3]
>>> [ 8805.376670] Back to C!
>>>
>>> Interface is unused normally (only for netconsole sometimes). dmesg and
>>> config
>>> attached.
>> Does reverting this:
>>
>> commit 8543da6672b0994921f014f2250e27ae816
mes). dmesg and
>> config
>> attached.
>
> Does reverting this:
>
> commit 8543da6672b0994921f014f2250e27ae81645580
> Author: Auke Kok <[EMAIL PROTECTED]>
> Date: Wed Dec 12 16:30:42 2007 -0800
>
> e100: free IRQ to remove warningwhenrebooting
>
&
On Monday 18 February 2008, Andrew Morton wrote:
> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]> wrote:
>
> > ... and possibly reboot/poweroff (it flows by too fast to be legible).
> >
> > [ 8803.850634] ACPI: Preparing to enter system sleep state S3
> > [ 8803.853141] S
: Entering sleep
> state [S3]
> [ 8805.376670] Back to C!
>
> Interface is unused normally (only for netconsole sometimes). dmesg and config
> attached.
Does reverting this:
commit 8543da6672b0994921f014f2250e27ae81645580
Author: Auke Kok <[EMAIL PROTECTED]>
Date: We
From: Andreas Mohr <[EMAIL PROTECTED]>
Signed-off-by: Andreas Mohr <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers/net/e100.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e1
From: Jiri Slaby <[EMAIL PROTECTED]>
writeX functions are not permitted on iomap-ped space change to iowriteX,
also pci_unmap pci_map-ped space on exit (instead of iounmap).
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers
Andreas Mohr wrote:
> Hi,
>
> On Tue, Jan 29, 2008 at 03:09:25PM -0800, Kok, Auke wrote:
>> Andreas Mohr wrote:
>>> Perhaps it's useful to file a bug/patch
>>> on http://sourceforge.net/projects/e1000/ ? Perhaps -mm testing?
>> I wanted to push this though our testing labs first which has not happ
Hi,
On Tue, Jan 29, 2008 at 03:09:25PM -0800, Kok, Auke wrote:
> Andreas Mohr wrote:
> > Perhaps it's useful to file a bug/patch
> > on http://sourceforge.net/projects/e1000/ ? Perhaps -mm testing?
>
> I wanted to push this though our testing labs first which has not happened
> due to
> time con
Andreas Mohr wrote:
> Hi,
>
> On Tue, Jan 01, 2008 at 09:09:08PM +0100, Andreas Mohr wrote:
>> Thanks for your quick reply!
>>
>> OK, here's part 1, the MII-less support stuff.
>> (preliminary posting, for review only)
>>
>> Note that these diffs apply to 2.6.24-rc6-mm1 without much trouble,
>> th
Hi,
On Tue, Jan 01, 2008 at 09:09:08PM +0100, Andreas Mohr wrote:
> Thanks for your quick reply!
>
> OK, here's part 1, the MII-less support stuff.
> (preliminary posting, for review only)
>
> Note that these diffs apply to 2.6.24-rc6-mm1 without much trouble,
> thus might want to do -mm testing
bit deeper review after newyears.
Part 2, the spelling corrections.
Thanks!
Signed-off-by: Andreas Mohr <[EMAIL PROTECTED]>
--- linux-2.6.24-rc6/drivers/net/e100.c 2008-01-01 18:53:21.0 +0100
+++ linux-2.6.24-rc6/drivers/net/e100.c 2008-01-01 18:53:25.0 +0100
@@ -94,7 +94,7 @@
IL PROTECTED]>
--- linux-2.6.24-rc6/drivers/net/e100.c 2008-01-01 12:57:06.0 +0100
+++ linux-2.6.24-rc6/drivers/net/e100.c 2008-01-01 16:17:45.0 +0100
@@ -251,6 +251,7 @@
mac_unknown = 0xFF,
};
+/* FIXME: these are unused: what the heck?? */
enum phy {
Andreas Mohr wrote:
> Hi all,
>
> I was mildly annoyed when rebooting my _headless_ internet gateway after a
> hotplug -> udev migration and witnessing it not coming up again,
> which turned out to be due to an eepro100 / e100 loading conflict
> since eepro100 supported b
Hi all,
I was mildly annoyed when rebooting my _headless_ internet gateway after a
hotplug -> udev migration and witnessing it not coming up again,
which turned out to be due to an eepro100 / e100 loading conflict
since eepro100 supported both of my Intel-based network cards,
whereas e100 o
Auke Kok wrote:
Adapted from Ian Wienand <[EMAIL PROTECTED]>
Explicitly free the IRQ before removing the device to remove a
warning "Destroying IRQ without calling free_irq"
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Cc: Ian Wienand <[EMAIL PROTECTED]>
---
driver
think the solution might be to free the IRQ before the pci_device_shutdown
Signed-off-by: Ian Wienand <[EMAIL PROTECTED]>
Cc: Jesse Brandeburg <[EMAIL PROTECTED]>
Cc: Auke Kok <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECT
Adapted from Ian Wienand <[EMAIL PROTECTED]>
Explicitly free the IRQ before removing the device to remove a
warning "Destroying IRQ without calling free_irq"
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Cc: Ian Wienand <[EMAIL PROTECTED]>
---
drivers/net/e100.c |
[NETDEV]: e100 Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/e100.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index e1c8a0d..7cb4ed0 100644
--- a/drivers/ne
No need to convert to bytes and back - cleanup unneeded code.
Adapted from fix from 'Roel Kluin <[EMAIL PROTECTED]>'
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers/net/e100.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/ne
Jeff Garzik wrote:
Kok, Auke wrote:
David Acker wrote:
What is the status of this patch?
Jeff merged it in netdev-2.6#upstream so it is queued for 2.6.25.
However, we could consider pushing this patch to 2.6.24 since it's a
valid fix.
Andrew has also been carrying this patch in -mm for a wh
Kok, Auke wrote:
David Acker wrote:
What is the status of this patch? Is there anything folks would like me
to do in order to move it forward? As an FYI, my company has been using
this patch since I posted it and so far we have not had any problems
with it.
-Ack
Jeff merged it in netdev-2.6
next buffer
>> and skip this one. If it sees the size set but the el-bit still set,
>> it will complete that buffer and then RNR interrupt and wait.
>>
>> Signed-off-by: David Acker <[EMAIL PROTECTED]>
>> Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
>>
on to the next buffer
and skip this one. If it sees the size set but the el-bit still set,
it will complete that buffer and then RNR interrupt and wait.
Signed-off-by: David Acker <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers
wn
I believe you are correct. Our other drivers appear to do this
correctly.
> Signed-off-by: Ian Wienand <[EMAIL PROTECTED]>
Auke will add this and push it next week.
Thanks!
>
> ---
>
> e100.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a
EMAIL PROTECTED]>
---
drivers/net/e100.c | 128
1 files changed, 99 insertions(+), 29 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 3dbaec6..2153058 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -106,6 +106,13
David Acker wrote:
> On the systems that have cache incoherent DMA, including ARM, there is a
> race condition between software allocating a new receive buffer and hardware
> writing into a buffer. The two race on touching the last Receive Frame
> Descriptor (RFD). It has its el-bit set and its n
using pktgen. I had it sending while a PC sent at it. I also ran it as
wireless access point with a 12-hour bidirectional 20 mbps UDP going between an
ethernet host on the e100 and a wireless client.
looks much simpler to me too, which I like.
It's good to see something coming from you! I
ang the RU and the
> transmit unit sometimes and if the card was restarted it would often crash the
> system with memory corruption. This patch was tested on my embedded system
> using pktgen. I had it sending while a PC sent at it. I also ran it as
> wireless access point with a 12
e a PC sent at it. I also ran it as
wireless access point with a 12-hour bidirectional 20 mbps UDP going between an
ethernet host on the e100 and a wireless client.
--- linux-2.6.24-rc1/drivers/net/e100.c.orig2007-11-01 11:42:35.0
-0400
+++ linux-2.6.24-rc1/drivers/net/e100.c 2007-11-02
David Mack wrote:
> Then I got very, very lucky, since I have successfully rebooted
> 2.6.23.1-23.fc8 four times (zero panics) and this is the first time a
> 2.6.23 kernel has not panicked on me in months.
>
> This does not fill me with confidence in the theory that the panics I've
> been seeing a
On 10/18/2007 01:59 PM, Kok, Auke wrote:
> David Mack wrote:
>> It appears that the needed e100 fix made it into the Fedora
>> 2.6.23.1-23.fc8 kernel. Boots reliably now.
>>
>> Huge thanks and great work, guys.
>
>
> DaveJ, I didn't push anything upstrea
ition.
Dave
> -Original Message-
> From: Dave Jones [mailto:[EMAIL PROTECTED]
> Sent: Sunday, October 21, 2007 6:05 PM
> To: Kok, Auke
> Cc: David Mack; Herbert Xu; netdev@vger.kernel.org;
> [EMAIL PROTECTED]
> Subject: Re: e100 problems in .23rc8 ?
>
> On Thu,
On Sun, Oct 21, 2007 at 09:04:40PM -0400, Dave Jones wrote:
>
> I included the patch below in the latest build, but I've not had
> chance to try it on an e100 box yet..
Looks good to me. Thanks Dave!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
On Thu, Oct 18, 2007 at 10:59:59AM -0700, Kok, Auke wrote:
> David Mack wrote:
> > It appears that the needed e100 fix made it into the Fedora
> > 2.6.23.1-23.fc8 kernel. Boots reliably now.
> >
> > Huge thanks and great work, guys.
>
> DaveJ, I didn&
On 10/18/2007 01:59 PM, Kok, Auke wrote:
> David Mack wrote:
>> It appears that the needed e100 fix made it into the Fedora
>> 2.6.23.1-23.fc8 kernel. Boots reliably now.
>>
>> Huge thanks and great work, guys.
>
>
> DaveJ, I didn't push anything upstre
David Mack wrote:
> It appears that the needed e100 fix made it into the Fedora
> 2.6.23.1-23.fc8 kernel. Boots reliably now.
>
> Huge thanks and great work, guys.
DaveJ, I didn't push anything upstream. Can you verify this now works?
Auke
>
> Dave
>
>> --
It appears that the needed e100 fix made it into the Fedora
2.6.23.1-23.fc8 kernel. Boots reliably now.
Huge thanks and great work, guys.
Dave
> -Original Message-
> From: Kok, Auke [mailto:[EMAIL PROTECTED]
> Sent: Friday, October 12, 2007 10:05 AM
> To: Herbert Xu
>
6, 2007 7:35 AM
> To: Eric Sandeen
> Cc: David Mack; [EMAIL PROTECTED]; [EMAIL PROTECTED];
> netdev@vger.kernel.org
> Subject: Re: e100 problems in .23rc8 ?
>
> On Tue, Oct 16, 2007 at 09:33:15AM -0500, Eric Sandeen wrote:
> >
> > Hm... running 2.6.23-6.fc8, I&#x
, disabled; I don't think that should
>> be affecting anything?
>
> Well the original problem was caused by spurious interrupts on
> the IRQ line where your e100 is so it could well be sporadic.
Hah, well, I took the other NIC out and it didn't survive more than a
coup
ink that should
> be affecting anything?
Well the original problem was caused by spurious interrupts on
the IRQ line where your e100 is so it could well be sporadic.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://g
Herbert Xu wrote:
> David Mack <[EMAIL PROTECTED]> wrote:
>> If I understand the message Dave Jones sent yesterday, the patch you
>> mention *was* applied to the e100 driver in 2.6.23-6.fc8?
>
> Nope, he applied a different one which doesn't have the crucial
>
David Mack <[EMAIL PROTECTED]> wrote:
> If I understand the message Dave Jones sent yesterday, the patch you
> mention *was* applied to the e100 driver in 2.6.23-6.fc8?
Nope, he applied a different one which doesn't have the crucial
part to disable NAPI polls before regi
Herbert Xu wrote:
> On Fri, Oct 12, 2007 at 07:54:33AM -0700, David Mack wrote:
>> Still no joy here. See attached capture. What's really weird is that it
>> shows *two* kernel panics, one in e100_poll and one in _list_add.
>
> Yes that's the symptom one would expect from that bug. We really
> n
> Cc: Herbert Xu; netdev@vger.kernel.org; [EMAIL PROTECTED];
> David Mack
> Subject: Re: e100 problems in .23rc8 ?
>
> On Thu, Oct 11, 2007 at 09:10:34AM -0700, Kok, Auke wrote:
> > Herbert Xu wrote:
> > > On Wed, Oct 10, 2007 at 08:36:38PM -0400, Dave Jones wrote
If I understand the message Dave Jones sent yesterday, the patch you
mention *was* applied to the e100 driver in 2.6.23-6.fc8?
Dave
> -Original Message-
> From: Herbert Xu [mailto:[EMAIL PROTECTED]
> Sent: Friday, October 12, 2007 8:36 AM
> To: David Mack
> Cc: Dave J
On Fri, Oct 12, 2007 at 07:54:33AM -0700, David Mack wrote:
> Still no joy here. See attached capture. What's really weird is that it
> shows *two* kernel panics, one in e100_poll and one in _list_add.
Yes that's the symptom one would expect from that bug. We really
need to apply the same fix th
olling before registering netdevice
>
> this patch actually called napi_disable() in the probe routine which was
> wrong,
> but e100 does not do that. Nonetheless e100 doesn't call netif_carrier_off()
> and
> netif_stop_queue(), so to make e100 the same as e1000 we should pro
Eric/David, the Fedora 8 RPM version 2.6.23-6.fc8 will have this if you
want to give it a shot too. It'll be at
http://people.redhat.com/davej/kernels/Fedora/f7.92/ when it's done
building in an hour or so.
Dave
Thanks, I'll give it a whirl this evening. I put a new net card in that
1 - 100 of 422 matches
Mail list logo
