On (10/14/16 16:09), Duyck, Alexander H wrote:
> Sorry I was thinking of a different piece of code. In the case of the
> atr code it would be hdr.network, not hdr.raw. Basically the thought
> was to validate that there is enough data in skb_headlen() that we can
> verify that from where the netwo
> -Original Message-
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com]
> Sent: Thursday, October 13, 2016 8:49 PM
> To: Duyck, Alexander H
> Cc: netdev@vger.kernel.org
> Subject: Re: bug in ixgbe_atr
>
> On (10/14/16 02:06), Duyck, Alexander H wrot
On (10/14/16 02:06), Duyck, Alexander H wrote:
> > + case ETH_P_IP:
> > + skb_header_pointer(skb, ETH_HLEN, sizeof (struct iphdr),
> > + &ip_hdr);
> > /* access ihl as u8 to avoid unaligned access on ia64 */
> > - hlen = (hdr.network[0]
> -Original Message-
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com]
> Sent: Thursday, October 13, 2016 6:44 PM
> To: Duyck, Alexander H ;
> netdev@vger.kernel.org
> Subject: bug in ixgbe_atr
>
> When I was playing around with TPACKET_V2, I t
When I was playing around with TPACKET_V2, I think I ran
into a bug in ixgbe_atr(): if I get here with an
sk_buff that has, e.g., just 14 bytes in the header, then
the skb_network_header is invalid. I found my kernel sometimes
wandering off into ipv6_find_hdr() in an attempt to get the
