Re: [PATCH] bonding: 3ad: update slave arr after initialize

2021-04-19 Thread Jay Vosburgh
jin yiting wrote: [...] >> The described issue is a race condition (in that >> ad_agg_selection_logic clears agg->is_active under mode_lock, but >> bond_open -> bond_update_slave_arr is inspecting agg->is_active outside >> the lock). I don't see how the above change will reliably manage this

Re: [PATCH] bonding: 3ad: update slave arr after initialize

2021-04-19 Thread jin yiting
在 2021/4/16 12:28, Jay Vosburgh 写道: jinyiting wrote: From: jin yiting The bond works in mode 4, and performs down/up operations on the bond that is normally negotiated. The probability of bond-> slave_arr is NULL Test commands: ifconfig bond1 down ifconfig bond1 up The conflict

Re: [PATCH] bonding: 3ad: update slave arr after initialize

2021-04-15 Thread Jay Vosburgh
jinyiting wrote: >From: jin yiting > >The bond works in mode 4, and performs down/up operations on the bond >that is normally negotiated. The probability of bond-> slave_arr is NULL > >Test commands: >ifconfig bond1 down >ifconfig bond1 up > >The conflict occurs in the following process:

[PATCH] bonding: 3ad: update slave arr after initialize

2021-04-15 Thread jinyiting
From: jin yiting The bond works in mode 4, and performs down/up operations on the bond that is normally negotiated. The probability of bond-> slave_arr is NULL Test commands: ifconfig bond1 down ifconfig bond1 up The conflict occurs in the following process: __dev_open (CPU A) --bond_

Re: bonding: 3ad: update slave arr after initialize

2021-04-15 Thread Jakub Kicinski
On Thu, 15 Apr 2021 14:59:49 +0800 jin yiting wrote: > From 71e63af579edd15ad7f7395760a19f67d9a1d7d3 Mon Sep 17 00:00:00 2001 > From: jin yiting > Date: Wed, 31 Mar 2021 20:38:40 +0800 > Subject: [PATCH] bonding: 3ad: update slave arr after initialize > MIME-Version: 1.0 >

bonding: 3ad: update slave arr after initialize

2021-04-15 Thread jin yiting
From 71e63af579edd15ad7f7395760a19f67d9a1d7d3 Mon Sep 17 00:00:00 2001 From: jin yiting Date: Wed, 31 Mar 2021 20:38:40 +0800 Subject: [PATCH] bonding: 3ad: update slave arr after initialize MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bond works