On Thursday 24 May 2007 03:00:56 David Miller wrote:
> From: Ingo Molnar <[EMAIL PROTECTED]>
> Date: Wed, 23 May 2007 13:40:21 +0200
>
> > * Herbert Xu <[EMAIL PROTECTED]> wrote:
> > > [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty
> > >
> > > My previous patch that changed the r
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 24 May 2007 07:41:00 +0200
> David Miller wrote:
> >>* Herbert Xu <[EMAIL PROTECTED]> wrote:
> >>
> >>>[NET_SCHED]: Fix qdisc_restart return value when dequeue is empty
> >
> > Applied, thanks everyone.
>
>
> Even though it didn't fix this pro
David Miller wrote:
>>* Herbert Xu <[EMAIL PROTECTED]> wrote:
>>
>>>[NET_SCHED]: Fix qdisc_restart return value when dequeue is empty
>
> Applied, thanks everyone.
Even though it didn't fix this problem, this patch I sent earlier is
also needed.
[NET_SCHED]: sch_htb: fix event cache time calcula
From: Ingo Molnar <[EMAIL PROTECTED]>
Date: Wed, 23 May 2007 13:40:21 +0200
>
> * Herbert Xu <[EMAIL PROTECTED]> wrote:
>
> > [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty
> >
> > My previous patch that changed the return value of qdisc_restart
> > incorrectly made the case
Linus Torvalds wrote:
> There appear to be other obvious problems in the recent "cleanups" in this
> area..
>
> Look at
>
> psched_tdiff_bounded(psched_time_t tv1, psched_time_t tv2,
> psched_time_t bound)
> {
> return min(tv1 - tv2, bound);
> }
>
> and compare
On Wed, 23 May 2007, Patrick McHardy wrote:
>
> Yes, that looks better, thanks.
There appear to be other obvious problems in the recent "cleanups" in this
area..
Look at
psched_tdiff_bounded(psched_time_t tv1, psched_time_t tv2,
psched_time_t bound)
{
return
* Herbert Xu <[EMAIL PROTECTED]> wrote:
> [NET_SCHED]: Fix qdisc_restart return value when dequeue is empty
>
> My previous patch that changed the return value of qdisc_restart
> incorrectly made the case where dequeue returns empty continue
> processing packets.
>
> This patch is based on di
Herbert Xu wrote:
> On Wed, May 23, 2007 at 12:56:04PM +0200, Patrick McHardy wrote:
>
>>Looking at the recent changes to __qdisc_run, this indeed seems
>>to be the case, when the qdisc is throttled and has packets queued
>>we return a value != 0, causing __qdisc_run to loop until all
>>packets ha
On Wed, May 23, 2007 at 12:56:04PM +0200, Patrick McHardy wrote:
>
> Looking at the recent changes to __qdisc_run, this indeed seems
> to be the case, when the qdisc is throttled and has packets queued
> we return a value != 0, causing __qdisc_run to loop until all
> packets have been sent, which
* Patrick McHardy <[EMAIL PROTECTED]> wrote:
> How is this trace to be understood? Is it simply a call trace in
> execution-order? [...]
yeah. There's a help section at the top of the trace which explains the
other fields too:
_--=> CPU#
/ _-=> irqs-of
Ingo Molnar wrote:
> if you feel inclined to try the git-bisection then by all means please
> do it (it will certainly be helpful and educative), but it's optional: i
> dont think you should 'need' to go through extra debugging chores, my
> analysis based on the excellent trace you provided stil
11 matches
Mail list logo
