Re: bad commit touching stmmac_ptp.c

2016-10-19 Thread Richard Cochran
On Wed, Oct 19, 2016 at 12:16:09AM -0400, Nicolas Pitre wrote: > Was this patch actually reviewed? And please, PLEASE put the PTP maintainer on CC for patches that use the PTP subsystem! Thanks, Richard

Re: bad commit touching stmmac_ptp.c

2016-10-19 Thread Giuseppe CAVALLARO
Hello Nicolas I have just sent a new patch to try to fix the problems you raised. Please let me know if [PATCH (net.git)] stmmac: fix and review the ptp registration actually covers and fixes the points. FYI, I am trying to review the PTP, especially for for the GMAC4, in these days so I w

bad commit touching stmmac_ptp.c

2016-10-18 Thread Nicolas Pitre
Hello, I noticed a recently added commit 7086605a6a ("stmmac: fix error check when init ptp") to the mainline linux tree from you. This commit is wrong. The affected code now reads as: int stmmac_ptp_register(struct stmmac_priv *priv) { spin_lock_init(&priv->ptp_lock); priv->pt