On 8/4/15, 12:44 AM, Dan Carpenter wrote:
Hello Roopa,
I have a concern about patch bf21563acc1d: "af_mpls: fix undefined
reference to ip6_route_output" from Jul 30, 2015.
net/mpls/af_mpls.c
450
451 dev = find_outdev(net, cfg);
452 if (IS_ERR(dev)) {
f
Hello Roopa,
I have a concern about patch bf21563acc1d: "af_mpls: fix undefined
reference to ip6_route_output" from Jul 30, 2015.
net/mpls/af_mpls.c
450
451 dev = find_outdev(net, cfg);
452 if (IS_ERR(dev)) {
find_outdev() used to return NULL pointers
From: Roopa Prabhu
Date: Thu, 30 Jul 2015 13:34:52 -0700
> This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of
> ip6_route_output. Follows the vxlan drivers usage of
> ipv6_stub_impl.ipv6_dst_lookup.
>
> There is no sk in the af_mpls context from where
> ipv6_stub_impl.ipv6_dst_loo
From: roopa
Date: Thu, 30 Jul 2015 13:38:14 -0700
> but was only concerned about ipv6 module unload.
It is not possible to unload the ipv6 module.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at ht
On 7/30/15, 7:57 AM, Hannes Frederic Sowa wrote:
On Thu, 2015-07-30 at 06:22 -0700, roopa wrote:
On 7/29/15, 10:42 PM, David Miller wrote:
From: Roopa Prabhu
Date: Tue, 28 Jul 2015 15:27:39 -0700
v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes
I think this might not work.
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of
ip6_route_output. And wraps affected code under
IS_ENABLED(CONFIG_INET) and IS_ENABLED(CONFIG_IPV6).
Report
2):
ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument
af_mpls: fix undefined reference to ip6_route_output
drivers/net/vxlan.c|2 +-
include/net/addrconf.h |4 ++--
include/net/ipv6.h |3 ++-
net/ipv6/icmp.c|6 +++---
net/ipv6/ip6_output.c | 15 ++
On Thu, 2015-07-30 at 06:22 -0700, roopa wrote:
> On 7/29/15, 10:42 PM, David Miller wrote:
> > From: Roopa Prabhu
> > Date: Tue, 28 Jul 2015 15:27:39 -0700
> >
> > > v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes
> > I think this might not work.
> >
> > The ipv6_stub pointer
On 7/29/15, 10:42 PM, David Miller wrote:
From: Roopa Prabhu
Date: Tue, 28 Jul 2015 15:27:39 -0700
v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes
I think this might not work.
The ipv6_stub pointer is NULL until the ipv6 module is loaded.
VXLAN can safely call through ipv
From: Roopa Prabhu
Date: Tue, 28 Jul 2015 15:27:39 -0700
> v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes
I think this might not work.
The ipv6_stub pointer is NULL until the ipv6 module is loaded.
VXLAN can safely call through ipv6_stub->foo() because it _knows_ the
ipv6 m
On 29/07/15 11:51, Thomas Graf wrote:
On 07/29/15 at 11:38am, Robert Shearman wrote:
On 28/07/15 17:16, roopa wrote:
RTA_OIF is optional for ipv4 and ipv6 routes and we wanted to keep it
that way for mpls routes as well (Quagga is the application in our use
case).
It was a simple patch...until
On 07/29/15 at 11:38am, Robert Shearman wrote:
> On 28/07/15 17:16, roopa wrote:
> >RTA_OIF is optional for ipv4 and ipv6 routes and we wanted to keep it
> >that way for mpls routes as well (Quagga is the application in our use
> >case).
> >It was a simple patch...until i realized the IPV6 dependen
On 28/07/15 17:16, roopa wrote:
On 7/28/15, 7:17 AM, Robert Shearman wrote:
On 28/07/15 07:40, Roopa Prabhu wrote:
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOK
On 7/28/15, 3:22 PM, Hannes Frederic Sowa wrote:
Hi roopa,
On Tue, Jul 28, 2015, at 21:28, roopa wrote:
ipv6_stub_impl.ipv6_dst_lookup seems to require sk today.
But it only needs it to get 'net' in the beginning and sk is optional
afterwards.
I will submit a patch to add 'net' as an arg to
r use case. Thanks and
apologies for the iterations on this.
Roopa Prabhu (2):
ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument
af_mpls: fix undefined reference to ip6_route_output
drivers/net/vxlan.c|2 +-
include/net/addrconf.h |4 ++--
include/net/ipv6.h |
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of
ip6_route_output. And wraps affected code under
IS_ENABLED(CONFIG_INET) and IS_ENABLED(CONFIG_IPV6).
Report
Hi roopa,
On Tue, Jul 28, 2015, at 21:28, roopa wrote:
> On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote:
> > Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do
> > that and don't have a run-time dependency on IPv6 at all (for the cost
> > of a function pointer).
> ipv6_stub_
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote:
Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do
that and don't have a run-time dependency on IPv6 at all (for the cost
of a function pointer).
ipv6_stub_impl.ipv6_dst_lookup seems to require sk today.
But it only needs it t
On 7/28/15, 7:17 AM, Robert Shearman wrote:
On 28/07/15 07:40, Roopa Prabhu wrote:
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
to lookup nexthop device if us
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote:
On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote:
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
to lookup
On 28/07/15 07:40, Roopa Prabhu wrote:
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
to lookup nexthop device if user has not specified it
in RTA_OIF attribute.
On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> Undefined reference to ip6_route_output and ip_route_output
> was reported with CONFIG_INET=n and CONFIG_IPV6=n.
>
> This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
> to lookup nexthop device if user has not specif
From: Roopa Prabhu
Undefined reference to ip6_route_output and ip_route_output
was reported with CONFIG_INET=n and CONFIG_IPV6=n.
This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
to lookup nexthop device if user has not specified it
in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP
depen
On 7/27/15, 9:20 PM, David Miller wrote:
From: Roopa Prabhu
Date: Mon, 27 Jul 2015 17:41:17 -0700
@@ -33,4 +33,11 @@ config MPLS_IPTUNNEL
---help---
mpls ip tunnel support.
+config MPLS_NEXTHOP_DEVLOOKUP
+ bool "MPLS: nexthop oif dev lookup"
+ depends on MPLS_R
From: Roopa Prabhu
Date: Mon, 27 Jul 2015 17:41:17 -0700
> @@ -33,4 +33,11 @@ config MPLS_IPTUNNEL
> ---help---
>mpls ip tunnel support.
>
> +config MPLS_NEXTHOP_DEVLOOKUP
> + bool "MPLS: nexthop oif dev lookup"
> + depends on MPLS_ROUTING && INET && (IPV6 || IPV6=n)
> +
From: Roopa Prabhu
This patch fixes undefined reference to ip6_route_output and
ip_route_output with CONFIG_INET=n and CONFIG_IPV6=n.
The patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
to lookup nexthop device if user has not specified it
in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP
de
From: roopa
Date: Thu, 23 Jul 2015 06:44:13 -0700
> On 7/23/15, 12:09 AM, David Miller wrote:
>> From: roopa
>> Date: Wed, 22 Jul 2015 13:38:31 -0700
>>
>>> I cant think of a way to fix the current problem with my patch...
>> I guess it's not obvious that adding CONFIG_MPLS_IPV6 would solve
>> t
On 7/23/15, 12:09 AM, David Miller wrote:
From: roopa
Date: Wed, 22 Jul 2015 13:38:31 -0700
I cant think of a way to fix the current problem with my patch...
I guess it's not obvious that adding CONFIG_MPLS_IPV6 would solve
the problem perfectly.
I thought that was not an option because CONF
From: roopa
Date: Wed, 22 Jul 2015 13:38:31 -0700
> I cant think of a way to fix the current problem with my patch...
I guess it's not obvious that adding CONFIG_MPLS_IPV6 would solve
the problem perfectly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a mes
From: Roopa Prabhu
seen with CONFIG_IPV6 disabled. Wrap the code around
IS_BUILTIN(CONFIG_IPV6). Also fixes undefined reference
to ip_route_output with CONFIG_INET=n
Reported-by: kbuild test robot
Reported-by: Thomas Graf
Signed-off-by: Roopa Prabhu
---
could not think of a better way. This u
On 7/22/15, 1:17 PM, Thomas Graf wrote:
On 07/22/15 at 01:04pm, David Miller wrote:
From: Thomas Graf
Date: Wed, 22 Jul 2015 21:57:06 +0200
On 07/22/15 at 12:30pm, roopa wrote:
diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
index 5c467ef..2b28615 100644
--- a/net/mpls/Kconfig
+++ b/net/mpl
On 7/22/15, 1:04 PM, David Miller wrote:
From: Thomas Graf
Date: Wed, 22 Jul 2015 21:57:06 +0200
On 07/22/15 at 12:30pm, roopa wrote:
diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
index 5c467ef..2b28615 100644
--- a/net/mpls/Kconfig
+++ b/net/mpls/Kconfig
@@ -24,6 +24,8 @@ config NET_MPLS_
On 07/22/15 at 01:04pm, David Miller wrote:
> From: Thomas Graf
> Date: Wed, 22 Jul 2015 21:57:06 +0200
>
> > On 07/22/15 at 12:30pm, roopa wrote:
> >> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
> >> index 5c467ef..2b28615 100644
> >> --- a/net/mpls/Kconfig
> >> +++ b/net/mpls/Kconfig
> >>
From: Thomas Graf
Date: Wed, 22 Jul 2015 21:57:06 +0200
> On 07/22/15 at 12:30pm, roopa wrote:
>> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
>> index 5c467ef..2b28615 100644
>> --- a/net/mpls/Kconfig
>> +++ b/net/mpls/Kconfig
>> @@ -24,6 +24,8 @@ config NET_MPLS_GSO
>>
>> config MPLS_ROUT
From: roopa
Date: Wed, 22 Jul 2015 12:30:19 -0700
> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
> index 5c467ef..2b28615 100644
> --- a/net/mpls/Kconfig
> +++ b/net/mpls/Kconfig
> @@ -24,6 +24,8 @@ config NET_MPLS_GSO
>
> config MPLS_ROUTING
> tristate "MPLS: routing support"
> +
On 07/22/15 at 12:30pm, roopa wrote:
> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
> index 5c467ef..2b28615 100644
> --- a/net/mpls/Kconfig
> +++ b/net/mpls/Kconfig
> @@ -24,6 +24,8 @@ config NET_MPLS_GSO
>
> config MPLS_ROUTING
> tristate "MPLS: routing support"
> + depends on
On 7/22/15, 5:23 AM, Thomas Graf wrote:
On 07/22/15 at 12:10am, Roopa Prabhu wrote:
From: Roopa Prabhu
seen with CONFIG_IPV6 disabled. Wrap the code
around IS_ENABLED(CONFIG_IPV6)
Reported-by: kbuild test robot
Signed-off-by: Roopa Prabhu
We need the same for CONFIG_INET=n in inet_fib_look
On 7/22/15, 10:49 AM, David Miller wrote:
From: Thomas Graf
Date: Wed, 22 Jul 2015 14:23:09 +0200
On 07/22/15 at 12:10am, Roopa Prabhu wrote:
From: Roopa Prabhu
seen with CONFIG_IPV6 disabled. Wrap the code
around IS_ENABLED(CONFIG_IPV6)
Reported-by: kbuild test robot
Signed-off-by: Roopa
From: Thomas Graf
Date: Wed, 22 Jul 2015 14:23:09 +0200
> On 07/22/15 at 12:10am, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> seen with CONFIG_IPV6 disabled. Wrap the code
>> around IS_ENABLED(CONFIG_IPV6)
>>
>> Reported-by: kbuild test robot
>> Signed-off-by: Roopa Prabhu
>
> We need t
On 07/22/15 at 12:10am, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> seen with CONFIG_IPV6 disabled. Wrap the code
> around IS_ENABLED(CONFIG_IPV6)
>
> Reported-by: kbuild test robot
> Signed-off-by: Roopa Prabhu
We need the same for CONFIG_INET=n in inet_fib_lookup_dev:
/home/tgraf/dev/linu
From: Roopa Prabhu
seen with CONFIG_IPV6 disabled. Wrap the code
around IS_ENABLED(CONFIG_IPV6)
Reported-by: kbuild test robot
Signed-off-by: Roopa Prabhu
---
net/mpls/af_mpls.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 49f1b0e
41 matches
Mail list logo
