Re: VLAN filtering with DSA

2020-09-11 Thread Florian Fainelli
On 9/11/2020 9:30 AM, Vladimir Oltean wrote: On Fri, Sep 11, 2020 at 04:20:58PM +0300, Ido Schimmel wrote: On Thu, Sep 10, 2020 at 11:41:04AM -0700, Florian Fainelli wrote: +Ido, On 9/10/2020 8:07 AM, Vladimir Oltean wrote: Florian, can you please reiterate what is the problem with calling

Re: VLAN filtering with DSA

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 07:30:42PM +0300, Vladimir Oltean wrote: > Currently there are other places in the network stack that don't really > work with a network interface that has problems with an interface that > has "rx-vlan-filter: on" in ethtool -k. Wow, I should learn how to write. I meant:

Re: VLAN filtering with DSA

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 04:20:58PM +0300, Ido Schimmel wrote: > On Thu, Sep 10, 2020 at 11:41:04AM -0700, Florian Fainelli wrote: > > +Ido, > > > > On 9/10/2020 8:07 AM, Vladimir Oltean wrote: > > > Florian, can you please reiterate what is the problem with calling > > > vlan_vid_add() with a VLAN

Re: VLAN filtering with DSA

2020-09-11 Thread Ido Schimmel
On Thu, Sep 10, 2020 at 11:41:04AM -0700, Florian Fainelli wrote: > +Ido, > > On 9/10/2020 8:07 AM, Vladimir Oltean wrote: > > Florian, can you please reiterate what is the problem with calling > > vlan_vid_add() with a VLAN that is installed by the bridge? > > > > The effect of vlan_vid_add(), t

Re: VLAN filtering with DSA

2020-09-10 Thread Vladimir Oltean
On Thu, Sep 10, 2020 at 12:05:17PM -0700, Florian Fainelli wrote: > On 9/10/2020 12:01 PM, Vladimir Oltean wrote: > > On Thu, Sep 10, 2020 at 11:42:02AM -0700, Florian Fainelli wrote: > > > On 9/10/2020 8:07 AM, Vladimir Oltean wrote: > > > Yes, doing what you suggest would make perfect sense for a

Re: VLAN filtering with DSA

2020-09-10 Thread Florian Fainelli
On 9/10/2020 12:08 PM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 12:05:17PM -0700, Florian Fainelli wrote: On 9/10/2020 12:01 PM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 11:42:02AM -0700, Florian Fainelli wrote: On 9/10/2020 8:07 AM, Vladimir Oltean wrote: Yes, doing what you su

Re: VLAN filtering with DSA

2020-09-10 Thread Florian Fainelli
On 9/10/2020 12:01 PM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 11:42:02AM -0700, Florian Fainelli wrote: On 9/10/2020 8:07 AM, Vladimir Oltean wrote: Yes, doing what you suggest would make perfect sense for a DSA master that is capable of VLAN filtering, I did encounter that problem wi

Re: VLAN filtering with DSA

2020-09-10 Thread Vladimir Oltean
On Thu, Sep 10, 2020 at 11:42:02AM -0700, Florian Fainelli wrote: > On 9/10/2020 8:07 AM, Vladimir Oltean wrote: > Yes, doing what you suggest would make perfect sense for a DSA master that > is capable of VLAN filtering, I did encounter that problem with e1000 and > the dsa-loop.c mockup driver wh

Re: VLAN filtering with DSA

2020-09-10 Thread Florian Fainelli
+Ido, On 9/10/2020 8:07 AM, Vladimir Oltean wrote: Florian, can you please reiterate what is the problem with calling vlan_vid_add() with a VLAN that is installed by the bridge? The effect of vlan_vid_add(), to my knowledge, is that the network interface should add this VLAN to its filtering ta

Re: VLAN filtering with DSA

2020-09-10 Thread Florian Fainelli
On 9/10/2020 8:07 AM, Vladimir Oltean wrote: Hi, Problem background: Most DSA switch tags shift the EtherType to the right, causing the master to not parse the VLAN as VLAN. However, not all switches do that (example: tail tags), and if the DSA master has "rx-vlan-filter: on" in ethtool -k,

VLAN filtering with DSA

2020-09-10 Thread Vladimir Oltean
Hi, Problem background: Most DSA switch tags shift the EtherType to the right, causing the master to not parse the VLAN as VLAN. However, not all switches do that (example: tail tags), and if the DSA master has "rx-vlan-filter: on" in ethtool -k, then we have a problem. Therefore, I was thinking