Re: [PATCH net-next v2 1/2] virtio_net: introduce ability to get reply info from device

2024-05-07 Thread Heng Qi
On Wed, 8 May 2024 10:20:05 +0800, Jason Wang wrote: > On Tue, May 7, 2024 at 2:56 PM Heng Qi wrote: > > > > On Tue, 7 May 2024 14:24:19 +0800, Jason Wang wrote: > > > On Fri, Apr 26, 2024 at 2:54 PM Heng Qi wrote: > > > > > > > > From: Xuan Zhuo > > > > > > > > As the spec > > > > https://gi

Re: [PATCH net-next v2 1/2] virtio_net: introduce ability to get reply info from device

2024-05-07 Thread Jason Wang
On Tue, May 7, 2024 at 2:56 PM Heng Qi wrote: > > On Tue, 7 May 2024 14:24:19 +0800, Jason Wang wrote: > > On Fri, Apr 26, 2024 at 2:54 PM Heng Qi wrote: > > > > > > From: Xuan Zhuo > > > > > > As the spec > > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0

Re: [PATCH net-next v2 1/2] virtio_net: introduce ability to get reply info from device

2024-05-06 Thread Heng Qi
On Tue, 7 May 2024 14:24:19 +0800, Jason Wang wrote: > On Fri, Apr 26, 2024 at 2:54 PM Heng Qi wrote: > > > > From: Xuan Zhuo > > > > As the spec > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > > > Based on the description provided in the above s

Re: [PATCH net-next v2 1/2] virtio_net: introduce ability to get reply info from device

2024-05-06 Thread Jason Wang
On Fri, Apr 26, 2024 at 2:54 PM Heng Qi wrote: > > From: Xuan Zhuo > > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > Based on the description provided in the above specification, we have > enabled the virtio-net driver to support acqui

[PATCH net-next v2 1/2] virtio_net: introduce ability to get reply info from device

2024-04-25 Thread Heng Qi
From: Xuan Zhuo As the spec https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 Based on the description provided in the above specification, we have enabled the virtio-net driver to support acquiring some response information from the device via the CVQ (Co

[PATCH net-next v7 1/8] virtio_net: introduce ability to get reply info from device

2024-04-25 Thread Xuan Zhuo
As the spec https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 Based on the description provided in the above specification, we have enabled the virtio-net driver to support acquiring some response information from the device via the CVQ (Control Virtqueue).

Re: [PATCH net-next V2] icmp: ICMPV6: pass RFC 8335 reply messages to ping_rcv

2021-04-20 Thread Andreas Roeseler
On Tue, 2021-04-13 at 17:51 -0400, Willem de Bruijn wrote: > On Mon, Apr 12, 2021 at 5:25 PM Andreas Roeseler > wrote: > > > > The current icmp_rcv function drops all unknown ICMP types, > > including > > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Ec

Re: [PATCH net-next V2] icmp: ICMPV6: pass RFC 8335 reply messages to ping_rcv

2021-04-13 Thread Willem de Bruijn
On Mon, Apr 12, 2021 at 5:25 PM Andreas Roeseler wrote: > > The current icmp_rcv function drops all unknown ICMP types, including > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply messages, > we have > to pass these packets to the ping_rcv function, which

[PATCH net-next V2] icmp: ICMPV6: pass RFC 8335 reply messages to ping_rcv

2021-04-12 Thread Andreas Roeseler
The current icmp_rcv function drops all unknown ICMP types, including ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply messages, we have to pass these packets to the ping_rcv function, which does not do any other filtering and passes the packet to the designated socket. Pass

Re: [PATCH net-next] icmp: pass RFC 8335 reply messages to ping_rcv

2021-04-12 Thread Willem de Bruijn
> > including > > > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply > > > messages, we have > > > to pass these packets to the ping_rcv function, which does not do > > > any > > > other filtering and passes the packet to the des

Re: [PATCH net-next] icmp: pass RFC 8335 reply messages to ping_rcv

2021-04-12 Thread Andreas Roeseler
On Mon, 2021-04-12 at 15:28 -0400, Willem de Bruijn wrote: > On Mon, Apr 12, 2021 at 3:09 PM Andreas Roeseler > wrote: > > > > The current icmp_rcv function drops all unknown ICMP types, > > including > > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Ec

Re: [PATCH net-next] icmp: pass RFC 8335 reply messages to ping_rcv

2021-04-12 Thread Willem de Bruijn
On Mon, Apr 12, 2021 at 3:09 PM Andreas Roeseler wrote: > > The current icmp_rcv function drops all unknown ICMP types, including > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply messages, > we have > to pass these packets to the ping_rcv function, which

[PATCH net-next] icmp: pass RFC 8335 reply messages to ping_rcv

2021-04-12 Thread Andreas Roeseler
The current icmp_rcv function drops all unknown ICMP types, including ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply messages, we have to pass these packets to the ping_rcv function, which does not do any other filtering and passes the packet to the designated socket. Pass

Re: [PATCH net] openvswitch: fix send of uninitialized stack memory in ct limit reply

2021-04-05 Thread patchwork-bot+netdevbpf
ends up being sent to userspace. > > Fix that by using designated initializer that will clear all > non-specified fields. > > [...] Here is the summary with links: - [net] openvswitch: fix send of uninitialized stack memory in ct limit reply https://git.kernel.org/netdev/n

Re: [ovs-dev] [PATCH net] openvswitch: fix send of uninitialized stack memory in ct limit reply

2021-04-04 Thread Tonghao Zhang
itch/conntrack.c > > +++ b/net/openvswitch/conntrack.c > > @@ -2032,10 +2032,10 @@ static int ovs_ct_limit_del_zone_limit(struct > > nlattr *nla_zone_limit, > > static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info, > >

Re: [PATCH net] openvswitch: fix send of uninitialized stack memory in ct limit reply

2021-04-04 Thread Ilya Maximets
tr > *nla_zone_limit, > static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info, > struct sk_buff *reply) > { > - struct ovs_zone_limit zone_limit; > - > - zone_limit.zone_id = OVS_ZONE_LIMIT_DEFAULT

[PATCH net] openvswitch: fix send of uninitialized stack memory in ct limit reply

2021-04-04 Thread Ilya Maximets
285 100644 --- a/net/openvswitch/conntrack.c +++ b/net/openvswitch/conntrack.c @@ -2032,10 +2032,10 @@ static int ovs_ct_limit_del_zone_limit(struct nlattr *nla_zone_limit, static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info, struct sk_buff *repl

Re: [PATCH net 0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Mar 2021 16:35:31 +0100 you wrote: > Hi, > > The series fixes an issue were a shared ip_tunnel_info is modified when > PMTU triggers an ICMP reply in vxlan and geneve, making following > packets

Re: [PATCH net 0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply

2021-03-25 Thread Stefano Brivio
On Thu, 25 Mar 2021 16:35:31 +0100 Antoine Tenart wrote: > Hi, > > The series fixes an issue were a shared ip_tunnel_info is modified when > PMTU triggers an ICMP reply in vxlan and geneve, making following > packets in that flow to have a wrong destination address if the flow

[PATCH net 1/2] vxlan: do not modify the shared tunnel info when PMTU triggers an ICMP reply

2021-03-25 Thread Antoine Tenart
When the interface is part of a bridge or an Open vSwitch port and a packet exceed a PMTU estimate, an ICMP reply is sent to the sender. When using the external mode (collect metadata) the source and destination addresses are reversed, so that Open vSwitch can match the packet against an existing

[PATCH net 2/2] geneve: do not modify the shared tunnel info when PMTU triggers an ICMP reply

2021-03-25 Thread Antoine Tenart
When the interface is part of a bridge or an Open vSwitch port and a packet exceed a PMTU estimate, an ICMP reply is sent to the sender. When using the external mode (collect metadata) the source and destination addresses are reversed, so that Open vSwitch can match the packet against an existing

[PATCH net 0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply

2021-03-25 Thread Antoine Tenart
Hi, The series fixes an issue were a shared ip_tunnel_info is modified when PMTU triggers an ICMP reply in vxlan and geneve, making following packets in that flow to have a wrong destination address if the flow isn't updated. A detailled information is given in each of the two commits. Thi

URGENT REPLY

2021-02-25 Thread martin collins
I am Mr. Martin Collins Bank manager still waiting for your reply to my many unanswered emails to you about the transfer

Re: [PATCH net-next v2] net/sched: cls_flower: validate ct_state for invalid and reply flags

2021-02-23 Thread Jakub Kicinski
On Tue, 23 Feb 2021 09:05:47 -0300 Marcelo Ricardo Leitner wrote: > On Tue, Feb 23, 2021 at 03:11:55PM +0800, we...@ucloud.cn wrote: > > From: wenxu > > > > Add invalid and reply flags validate in the fl_validate_ct_state. > > This makes the checking

Re: [PATCH net-next v2] net/sched: cls_flower: validate ct_state for invalid and reply flags

2021-02-23 Thread Marcelo Ricardo Leitner
On Tue, Feb 23, 2021 at 03:11:55PM +0800, we...@ucloud.cn wrote: > From: wenxu > > Add invalid and reply flags validate in the fl_validate_ct_state. > This makes the checking complete if compared to ovs' > validate_ct_state(). > > Signed-off-by: wenxu Reviewed-by: Marcelo Ricardo Leitner

[PATCH net-next v2] net/sched: cls_flower: validate ct_state for invalid and reply flags

2021-02-22 Thread wenxu
From: wenxu Add invalid and reply flags validate in the fl_validate_ct_state. This makes the checking complete if compared to ovs' validate_ct_state(). Signed-off-by: wenxu --- net/sched/cls_flower.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/sched/cls_flowe

Re: [PATCH net-next] net/sched: cls_flower: validate ct_state for invalid and reply flags

2021-02-22 Thread Marcelo Ricardo Leitner
On Mon, Feb 22, 2021 at 02:09:50PM +0800, we...@ucloud.cn wrote: > From: wenxu > > Add invalid and reply flags validate in the fl_validate_ct_state. This makes the checking complete if compared to ovs' validate_ct_state(). ... > + if (state & TCA_FLOWER

Reply back

2021-02-21 Thread Adrien Saif
-- Hello, This is attorney Adrien Saif, the legal practitioner to Qatif Oil And Gas Group of Companies. Did you receive the proposal we sent to you via email days ago? Best Regards, Adrien Saif

[PATCH net-next] net/sched: cls_flower: validate ct_state for invalid and reply flags

2021-02-21 Thread wenxu
From: wenxu Add invalid and reply flags validate in the fl_validate_ct_state. Signed-off-by: wenxu --- net/sched/cls_flower.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 2409e52..18430db 100644 --- a/net/sched

[PATCH net-next 6/7] bnxt_en: Reply to firmware's echo request async message.

2021-02-14 Thread Michael Chan
This is a new async message that the firmware can send to check if it can communicate with the driver. This is an added error detection scheme that firmware can use if it suspects errors in the PCIe interface. When the driver receives this async message, it will reply back echoing some data in

Re: [PATCH iproute2/net-next] tc: flower: Add support for ct_state reply flag

2021-02-04 Thread David Ahern
On 2/2/21 5:24 AM, Paul Blakey wrote: > Matches on conntrack rpl ct_state. > > Example: > $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \ > ct_state +trk+est+rpl \ > action mirred egress redirect dev ens1f0_1 > $ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip

Re: [PATCH net-next 3/3] net/mlx5: CT: Add support for matching on ct_state reply flag

2021-02-03 Thread Paul Blakey
On Tue, 2 Feb 2021, Marcelo Ricardo Leitner wrote: > On Wed, Jan 27, 2021 at 04:32:47PM +0200, Paul Blakey wrote: > > Add support for matching on ct_state reply flag. > > Sorry for the late reply, missed the patchset here. (just noticed > because of the iproute2 patch, th

Re: [PATCH iproute2/net-next] tc: flower: Add support for ct_state reply flag

2021-02-02 Thread Paul Blakey
On Tue, 2 Feb 2021, Marcelo Ricardo Leitner wrote: > On Tue, Feb 02, 2021 at 02:24:42PM +0200, Paul Blakey wrote: > > Matches on conntrack rpl ct_state. > > > > Example: > > $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \ > > ct_state +trk+est+rpl \ > > action mirred

Re: [PATCH iproute2/net-next] tc: flower: Add support for ct_state reply flag

2021-02-02 Thread Marcelo Ricardo Leitner
On Tue, Feb 02, 2021 at 02:24:42PM +0200, Paul Blakey wrote: > Matches on conntrack rpl ct_state. > > Example: > $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \ > ct_state +trk+est+rpl \ > action mirred egress redirect dev ens1f0_1 > $ tc filter add dev ens1f0_1 ingress p

Re: [PATCH net-next 3/3] net/mlx5: CT: Add support for matching on ct_state reply flag

2021-02-02 Thread Marcelo Ricardo Leitner
On Wed, Jan 27, 2021 at 04:32:47PM +0200, Paul Blakey wrote: > Add support for matching on ct_state reply flag. Sorry for the late reply, missed the patchset here. (just noticed because of the iproute2 patch, thanks for the Cc in there) Only one question though. Is it safe to assume that t

[PATCH iproute2/net-next] tc: flower: Add support for ct_state reply flag

2021-02-02 Thread Paul Blakey
@@ -387,6 +387,8 @@ new - New connection. .TP est - Established connection. .TP +rpl - The packet is in the reply direction, meaning that it is in the opposite direction from the packet that initiated the connection. +.TP inv - The state is invalid. The packet couldn't be associated to a conne

Re: [PATCH stable v5.4 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 05:24:52PM +0530, Aviraj CJ wrote: > From: Hangbin Liu > > commit 2efdaaaf883a143061296467913c01aa1ff4b3ce upstream. > > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then

[PATCH stable v5.4 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2021-01-30 Thread Aviraj CJ
From: Hangbin Liu commit 2efdaaaf883a143061296467913c01aa1ff4b3ce upstream. Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code

Re: [PATCH net-next 0/3] net/sched: cls_flower: Add support for matching on ct_state reply flag

2021-01-29 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 16:32:44 +0200 you wrote: > This patchset adds software match support and offload of flower > match ct_state reply flag (+/-rpl). > > The first patch adds the definition for the flag

[Internal review][PATCH stable v5.4 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2021-01-29 Thread Aviraj CJ
From: Hangbin Liu commit 2efdaaaf883a143061296467913c01aa1ff4b3ce upstream. Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code

[PATCH net-next 1/3] net/sched: cls_flower: Add match on the ct_state reply flag

2021-01-27 Thread Paul Blakey
Add match on the ct_state reply flag. Example: $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \ ct_state +trk+est+rpl \ action mirred egress redirect dev ens1f0_1 $ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip flower \ ct_state +trk+est-rpl \ action

[PATCH net-next 3/3] net/mlx5: CT: Add support for matching on ct_state reply flag

2021-01-27 Thread Paul Blakey
Add support for matching on ct_state reply flag. Example: $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \ ct_state +trk+est+rpl \ action mirred egress redirect dev ens1f0_1 $ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip flower \ ct_state +trk+est-rpl

[PATCH net-next 0/3] net/sched: cls_flower: Add support for matching on ct_state reply flag

2021-01-27 Thread Paul Blakey
This patchset adds software match support and offload of flower match ct_state reply flag (+/-rpl). The first patch adds the definition for the flag and match to flower. Second patch gives the direction of the connection to the offloading drivers via ct_metadata flow offload action. The last

Please reply to me

2020-11-25 Thread Dailborh R.
I'm Dailborh R. from US. I picked interest in you and I would like to know more about you and establish relationship with you. i will wait for your response. thank you.

[PATCH net-next v4 07/15] net/smc: Refactor the netlink reply processing routine

2020-11-09 Thread Karsten Graul
From: Guvenc Gulce Refactor the netlink reply processing routine so that it provides sub functions for specific parts of the processing. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 218 +++-- 1 file changed, 133

[PATCH net-next v3 07/15] net/smc: Refactor the netlink reply processing routine

2020-11-07 Thread Karsten Graul
From: Guvenc Gulce Refactor the netlink reply processing routine so that it provides sub functions for specific parts of the processing. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 218 +++-- 1 file changed, 133

[PATCH net-next v2 07/15] net/smc: Refactor the netlink reply processing routine

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Refactor the netlink reply processing routine so that it provides sub functions for specific parts of the processing. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 218 +++-- 1 file changed, 133

[PATCH net-next 07/15] net/smc: Refactor the netlink reply processing routine

2020-11-02 Thread Karsten Graul
From: Guvenc Gulce Refactor the netlink reply processing routine so that it provides sub functions for specific parts of the processing. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 218 +++-- 1 file changed, 133

Re: [PATCHv6 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

2020-10-31 Thread Jakub Kicinski
On Tue, 27 Oct 2020 20:33:11 +0800 Hangbin Liu wrote: > When our Engineer run latest IPv6 Core Conformance test, test v6LC.1.3.6: > First Fragment Doesn’t Contain All Headers[1] failed. The test purpose is to > verify that the node(Linux for example) should properly process IPv6 packets > that don’

Re: [PATCHv5 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-30 Thread Georg Kohmann (geokohma)
On 30.10.2020 16:31, Willem de Bruijn wrote: > On Tue, Oct 27, 2020 at 5:57 AM Hangbin Liu wrote: >> On Tue, Oct 27, 2020 at 07:57:06AM +, Georg Kohmann (geokohma) wrote: + /* RFC 8200, Section 4.5 Fragment Header: +* If the first fragment does not include all headers through a

Re: [PATCHv5 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-30 Thread Willem de Bruijn
On Tue, Oct 27, 2020 at 5:57 AM Hangbin Liu wrote: > > On Tue, Oct 27, 2020 at 07:57:06AM +, Georg Kohmann (geokohma) wrote: > > > + /* RFC 8200, Section 4.5 Fragment Header: > > > +* If the first fragment does not include all headers through an > > > +* Upper-Layer header, then that

[PATCHv6 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-27 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCHv6 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

2020-10-27 Thread Hangbin Liu
definition IPv6: reply ICMP error if the first fragment don't include all headers include/uapi/linux/icmpv6.h | 1 + net/ipv6/icmp.c | 8 +++- net/ipv6/reassembly.c | 33 - 3 files changed, 40 insertions(+), 2 deletions(-) -- 2.25.4

Re: [PATCHv5 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-27 Thread Georg Kohmann (geokohma)
s (both 0) that might >> change in the future. > Thanks, I also didn't aware this scenario. > >> I suggest you only check that the offset is 0: >> frag_off & htons(IP6_OFFSET) > This will match all other fragment packets. RFC request we reply ICMP for the > first fragment packet, Do you mean > > if (!frag_off & htons(IP6_OFFSET) && offset > skb->len) Almost, add some parentheses: if (!(frag_off & htons(IP6_OFFSET)) && offset > skb->len) > > Thanks > Hangbin

Re: [PATCHv5 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-27 Thread Hangbin Liu
off == htons(ip6_mf) && offset > skb->len) { > > This do not catch atomic fragments (fragmented packet with only one > fragment). frag_off also contains two reserved bits (both 0) that might > change in the future. Thanks, I also didn't aware this scenario. > I sugge

Re: [PATCHv5 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-27 Thread Georg Kohmann (geokohma)
On 27.10.2020 03:28, Hangbin Liu wrote: > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then that fragment should be discarded and > an ICMP Parameter Problem, Code 3, message should be sent to

[PATCHv5 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-26 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCHv5 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

2020-10-26 Thread Hangbin Liu
definition IPv6: reply ICMP error if the first fragment don't include all headers include/uapi/linux/icmpv6.h | 1 + net/ipv6/icmp.c | 8 +++- net/ipv6/reassembly.c | 33 - 3 files changed, 40 insertions(+), 2 deletions(-) -- 2.25.4

Re: [PATCHv4 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-26 Thread Georg Kohmann (geokohma)
fines the same with NEXTHDR_NONE. So ipv6_skip_exthdr() will > return -1, and we will goto fail_hdr and send ICMP parameter error message. > > The question is if it's OK to reply a ICMP error for fragment + IPPROTO_NONE > packet? For pure IPPROTO_NONE message, we should drop si

Re: [PATCHv4 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-26 Thread Hangbin Liu
(nexthdr == IPPROTO_ICMPV6) > > + offset += sizeof(struct icmp6hdr); > > + else > > + offset += 1; > > Maybe also check the special case IPPROTO_NONE? IPPROTO_NONE defines the same with NEXTHDR_NONE. So ipv6_skip_exthdr() will return -1, and we will

Re: [PATCHv4 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-26 Thread Georg Kohmann (geokohma)
On 26.10.2020 08:29, Hangbin Liu wrote: > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then that fragment should be discarded and > an ICMP Parameter Problem, Code 3, message should be sent to

[PATCHv4 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

2020-10-26 Thread Hangbin Liu
definition IPv6: reply ICMP error if the first fragment don't include all headers include/uapi/linux/icmpv6.h | 1 + net/ipv6/icmp.c | 8 +++- net/ipv6/reassembly.c | 33 - 3 files changed, 40 insertions(+), 2 deletions(-) -- 2.25.4

[PATCHv4 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-26 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

Re: [PATCHv3 net 2/2] IPv6: reply ICMP error if the first fragment doesn't include all headers

2020-10-23 Thread Jakub Kicinski
On Fri, 23 Oct 2020 14:43:47 +0800 Hangbin Liu wrote: > diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c > index ec448b71bf9a..0bda77d7e6b8 100644 > --- a/net/ipv6/icmp.c > +++ b/net/ipv6/icmp.c > @@ -145,6 +145,7 @@ static bool is_ineligible(const struct sk_buff *skb) > int ptr = (u8 *)(ipv6_h

[PATCHv3 net 2/2] IPv6: reply ICMP error if the first fragment doesn't include all headers

2020-10-22 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCHv3 net 0/2] IPv6: reply ICMP error if fragment doesn't contain all headers

2020-10-22 Thread Hangbin Liu
definition IPv6: reply ICMP error if the first fragment don't include all headers include/uapi/linux/icmpv6.h | 1 + net/ipv6/icmp.c | 10 +- net/ipv6/reassembly.c | 33 - 3 files changed, 42 insertions(+), 2 deletions(-) -- 2.25.4

Re: [PATCHv2 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-22 Thread Willem de Bruijn
On Thu, Oct 22, 2020 at 5:12 AM Hangbin Liu wrote: > > Hi Willem, > > Thanks for the comments, see replies below. > > On Wed, Oct 21, 2020 at 10:02:55AM -0400, Willem de Bruijn wrote: > > > + is_frag = (ipv6_find_hdr(skb, &offs, NEXTHDR_FRAGMENT, NULL, > > > NULL) == NEXTHDR_FRAGMENT); > >

Re: [PATCHv2 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-22 Thread Hangbin Liu
Hi Willem, Thanks for the comments, see replies below. On Wed, Oct 21, 2020 at 10:02:55AM -0400, Willem de Bruijn wrote: > > + is_frag = (ipv6_find_hdr(skb, &offs, NEXTHDR_FRAGMENT, NULL, NULL) > > == NEXTHDR_FRAGMENT); > > + > > ipv6_skip_exthdr already walks all headers. Should we not a

Re: [PATCHv2 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-21 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 12:20 AM Hangbin Liu wrote: > > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then that fragment should be discarded and > an ICMP Parameter Problem, Code 3, message sho

[PATCHv2 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-20 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCHv2 net 0/2] IPv6: reply ICMP error with fragment doesn't contain all headers

2020-10-20 Thread Hangbin Liu
definition IPv6: reply ICMP error if the first fragment don't include all headers include/uapi/linux/icmpv6.h | 1 + net/ipv6/icmp.c | 13 - net/ipv6/reassembly.c | 18 +- 3 files changed, 30 insertions(+), 2 deletions(-) -- 2.25.4

[PATCH 1/6] ipvs: inspect reply packets from DR/TUN real servers

2020-10-11 Thread Pablo Neira Ayuso
From: "longguang.yue" Just like for MASQ, inspect the reply packets coming from DR/TUN real servers and alter the connection's state and timeout according to the protocol. It's ipvs's duty to do traffic statistic if packets get hit, no matter what mode it is. Sig

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-09 Thread Hangbin Liu
On Thu, Oct 08, 2020 at 11:47:00AM +0200, Eric Dumazet wrote: > > > On 10/8/20 10:30 AM, Hangbin Liu wrote: > >>> @@ -282,6 +285,21 @@ static struct sk_buff *ip6_rcv_core(struct sk_buff > >>> *skb, struct net_device *dev, > >>> } > >>> } > >>> > >>> + /* RFC 8200, Section 4.5 Fragm

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-08 Thread Eric Dumazet
On 10/8/20 10:30 AM, Hangbin Liu wrote: > Hi Eric, > > Thanks for the comments. I should add "RFC" in subject next time for the > uncertain fix patch. > > On Wed, Oct 07, 2020 at 11:35:41AM +0200, Eric Dumazet wrote: >> >> >> On 10/7/20 5:55 AM, Hangbin Liu wrote: >> >>> kfree_skb(

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-08 Thread Hangbin Liu
On Wed, Oct 07, 2020 at 07:58:07AM -0700, Jakub Kicinski wrote: > On Wed, 7 Oct 2020 11:55:02 +0800 Hangbin Liu wrote: > > Based on RFC 8200, Section 4.5 Fragment Header: > > > > - If the first fragment does not include all headers through an > > Upper-Layer header, then that fragment sho

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-08 Thread Hangbin Liu
Hi Eric, Thanks for the comments. I should add "RFC" in subject next time for the uncertain fix patch. On Wed, Oct 07, 2020 at 11:35:41AM +0200, Eric Dumazet wrote: > > > On 10/7/20 5:55 AM, Hangbin Liu wrote: > > > kfree_skb(skb); > > @@ -282,6 +285,21 @@ static struct sk_buff *ip

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 11:55:02 +0800 Hangbin Liu wrote: > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then that fragment should be discarded and > an ICMP Parameter Problem, Code 3, message sho

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-07 Thread Eric Dumazet
On 10/7/20 5:55 AM, Hangbin Liu wrote: > kfree_skb(skb); > @@ -282,6 +285,21 @@ static struct sk_buff *ip6_rcv_core(struct sk_buff *skb, > struct net_device *dev, > } > } > > + /* RFC 8200, Section 4.5 Fragment Header: > + * If the first fragment do

[PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-06 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCH net 0/2] IPv6: reply ICMP error with fragment doesn't contain all headers

2020-10-06 Thread Hangbin Liu
definition IPv6: reply ICMP error if the first fragment don't include all headers include/uapi/linux/icmpv6.h | 1 + net/ipv6/icmp.c | 13 - net/ipv6/ip6_input.c| 20 +++- 3 files changed, 32 insertions(+), 2 deletions(-) -- 2.25.4

REPLY

2020-09-22 Thread Marcus
My Greetings, I am a banker, the Chief Auditor in our bank. I have the ability to transfer unclaimed funds that belong to one of our late customer who died in a car crash along with his family and no one came to claim the funds, if left unclaimed the fund will be transferred to the state treasury i

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread David Miller
tunnel info request reached mainline in 5.9 merge window, we should > still be able to fix the reply message type without breaking backward > compatibility. > > Fixes: c7d759eb7b12 ("ethtool: add tunnel info interface") > Signed-off-by: Michal Kubecek Applied, thank you.

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread Andrew Lunn
> On the other hand, the enums are part of userspace API so I better take > a closer look to make sure we don't run into some trouble there. Hi Michal Yes, that is what i was thinking about. But i guess you can pass a tagged enum to a function expecting an int and the compiler will silently cast

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread Michal Kubecek
On Thu, Sep 17, 2020 at 03:41:51AM +0200, Andrew Lunn wrote: > On Thu, Sep 17, 2020 at 01:04:10AM +0200, Michal Kubecek wrote: > > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > > field in genetlink header) for replies to tunnel info netlink request, i.e. > > the same

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-16 Thread Andrew Lunn
On Thu, Sep 17, 2020 at 01:04:10AM +0200, Michal Kubecek wrote: > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > field in genetlink header) for replies to tunnel info netlink request, i.e. > the same value as the request have. This is a problem because we are using >

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-16 Thread Jakub Kicinski
request reached mainline in 5.9 merge window, we should > still be able to fix the reply message type without breaking backward > compatibility. > > Fixes: c7d759eb7b12 ("ethtool: add tunnel info interface") > Signed-off-by: Michal Kubecek Ouch, sorry & thanks! Reviewed-by: Jakub Kicinski

[PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-16 Thread Michal Kubecek
message types so that this ETHTOOL_MSG_TUNNEL_INFO_GET (28) collides with ETHTOOL_MSG_CABLE_TEST_TDR_NTF which is what message type 28 means for kernel to userspace messages. As the tunnel info request reached mainline in 5.9 merge window, we should still be able to fix the reply message type without

[PATCH 8/8] netfilter: conntrack: do not auto-delete clash entries on reply

2020-08-31 Thread Pablo Neira Ayuso
NAT_CLASH tuple. In that case the second skb will be sent, but no reply can be received since the reply that is processed first removes the NAT_CLASH tuple. Do not auto-delete, this gives a 1 second window for replies to be passed back to originator. Packets that are coming later (udp stream case

REPLY

2020-08-30 Thread Marcus
My Greetings, I am a banker, a Chief Auditor in our bank, I have the ability to transfer unclaimed funds that belong to one of our late customer died in a car crash along with his family and no one came to put claim the funds, if left unclaimed the fund will be transferred to the state treasury in

Re: [PATCH net v2 3/3] ethtool: Don't omit the netlink reply if no features were changed

2020-08-18 Thread Michal Kubecek
On Mon, Aug 17, 2020 at 04:34:07PM +0300, Maxim Mikityanskiy wrote: > The legacy ethtool userspace tool shows an error when no features could > be changed. It's useful to have a netlink reply to be able to show this > error when __netdev_update_features wasn't called, for examp

[PATCH net v2 3/3] ethtool: Don't omit the netlink reply if no features were changed

2020-08-17 Thread Maxim Mikityanskiy
The legacy ethtool userspace tool shows an error when no features could be changed. It's useful to have a netlink reply to be able to show this error when __netdev_update_features wasn't called, for example: 1. ethtool -k eth0 large-receive-offload: off 2. ethtool -K eth0 rx-fcs on

[PATCH net 3/3] ethtool: Don't omit the netlink reply if no features were changed

2020-08-14 Thread Maxim Mikityanskiy
The legacy ethtool userspace tool shows an error when no features could be changed. It's useful to have a netlink reply to be able to show this error when __netdev_update_features wasn't called, for example: 1. ethtool -k eth0 large-receive-offload: off 2. ethtool -K eth0 rx-fcs on

Re: [PATCHv2 net-next--in-reply-to=<20200707171515.110818-1-izabela.bakoll...@gmail.com>] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread Izabela Bakollari
I am reverting my last patch because of the malformatted subject. Thanks, Izabela On Tue, Aug 4, 2020 at 5:48 PM wrote: > > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument >

[PATCHv2 net-next--in-reply-to=<20200707171515.110818-1-izabela.bakoll...@gmail.com>] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread izabela . bakollari
From: Izabela Bakollari Dropwatch is a utility that monitors dropped frames by having userspace record them over the dropwatch protocol over a file. This augument allows live monitoring of dropped frames using tools like tcpdump. With this feature, dropwatch allows two additional commands (start

URGENT REPLY.

2020-06-22 Thread Karim Zakari
Good-Day Friend, Hope you are doing great Today. I have a proposed business deal worthy (US$16.5 Million Dollars) that will benefit both parties. This is legitimate' legal and your personality will not be compromised. Waiting for your response for more details, As you are willing to execute

[PATCH AUTOSEL 5.6 209/606] ethtool: count header size in reply size estimate

2020-06-08 Thread Sasha Levin
From: Michal Kubecek [ Upstream commit 7c87e32d2e380228ada79d20ac5b7674718ef097 ] As ethnl_request_ops::reply_size handlers do not include common header size into calculated/estimated reply size, it needs to be added in ethnl_default_doit() and ethnl_default_notify() before allocating the

Re: [PATCH net] ethtool: count header size in reply size estimate

2020-05-21 Thread David Miller
From: Michal Kubecek Date: Sun, 10 May 2020 21:04:09 +0200 > As ethnl_request_ops::reply_size handlers do not include common header > size into calculated/estimated reply size, it needs to be added in > ethnl_default_doit() and ethnl_default_notify() before allocating the > message.

[PATCH net] ethtool: count header size in reply size estimate

2020-05-21 Thread Michal Kubecek
As ethnl_request_ops::reply_size handlers do not include common header size into calculated/estimated reply size, it needs to be added in ethnl_default_doit() and ethnl_default_notify() before allocating the message. On the other hand, strset_reply_size() should not add common header size. Fixes

Reply Urgently!!

2020-05-20 Thread Mr Saeed Ahmed
Dear Friend, I want you to be honest and truthful with me that you will help me with all your effort and time for just seven to fourteen workings of your time Please kindly reply to my most confidential email if you are really interested in helping me please: saeedasutanah...@gmail.com

Business Proposal - Please Reply

2019-10-03 Thread Yuval
Hello My name is Yuval Rose. I have an urgent lucrative business opportunity for you worth over 15 Milli0n US D0llars. I got your details on the internet when I was searching for a reliable person that can handle this deal and I believe you can handle it. Waiting for your speedy reply for

  1   2   3   >