Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-26 Thread Madhuparna Bhowmik
On Mon, Aug 24, 2020 at 01:49:04PM -0700, Xie He wrote: > On Mon, Aug 24, 2020 at 7:13 AM Madhuparna Bhowmik > wrote: > > > > Sure, I had a look at it and since you are already working on fixing > > this driver, don't think there is a need for a patch to fix the > > particular race condition bug.

Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-24 Thread Xie He
On Mon, Aug 24, 2020 at 7:13 AM Madhuparna Bhowmik wrote: > > Sure, I had a look at it and since you are already working on fixing > this driver, don't think there is a need for a patch to fix the > particular race condition bug. This bug was found by the Linux driver > verification project and my

Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-24 Thread Madhuparna Bhowmik
On Sun, Aug 23, 2020 at 12:12:01PM -0700, Xie He wrote: > On Sun, Aug 23, 2020 at 8:28 AM Madhuparna Bhowmik > wrote: > > > > sl->xhead is modified in both x25_asy_change_mtu() and > > x25_asy_write_wakeup(). However, sl->lock is not held in > > x25_asy_write_wakeup(). So, I am not sure if it is i

Re: Regarding possible bug in net/wan/x25_asy.c

2020-08-23 Thread Xie He
On Sun, Aug 23, 2020 at 8:28 AM Madhuparna Bhowmik wrote: > > sl->xhead is modified in both x25_asy_change_mtu() and > x25_asy_write_wakeup(). However, sl->lock is not held in > x25_asy_write_wakeup(). So, I am not sure if it is indeed possible to > have a race between these two functions. If it i

Regarding possible bug in net/wan/x25_asy.c

2020-08-23 Thread Madhuparna Bhowmik
Hello, I have the following doubt: sl->xhead is modified in both x25_asy_change_mtu() and x25_asy_write_wakeup(). However, sl->lock is not held in x25_asy_write_wakeup(). So, I am not sure if it is indeed possible to have a race between these two functions. If it is possible that these two functi