Re: warnings in git-wireless

2007-06-06 Thread Dave Jones
On Wed, Jun 06, 2007 at 06:04:21PM -0700, Andrew Morton wrote: > There _should_ be some #ifdeffable thing which is being passed to cpp when > we run sparse (but I'm not sure what it is). #ifdef __CHECKER__ (See include/linux/compiler.h, this is how we implement __user & friends) Dave

Re: warnings in git-wireless

2007-06-06 Thread Andrew Morton
On Wed, 06 Jun 2007 15:33:46 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Wed, 06 Jun 2007 13:51:41 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > > > * make C=2 CF=-Wall will complain if you use ARRAY_SIZE on global data > */ > #define GLOBAL_

Re: warnings in git-wireless

2007-06-06 Thread James Ketrenos
Andrew Morton wrote: > On Wed, 06 Jun 2007 13:51:41 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > * make C=2 CF=-Wall will complain if you use ARRAY_SIZE on global data */ #define GLOBAL_ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) >>> This is identical to ARRAY_SIZE. >>> >>> An

Re: warnings in git-wireless

2007-06-06 Thread Randy Dunlap
On Wed, 6 Jun 2007 16:35:34 -0700 Andrew Morton wrote: > On Wed, 06 Jun 2007 13:51:41 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > > > > > >> * make C=2 CF=-Wall will complain if you use ARRAY_SIZE on global data > > >> */ > > >> #define GLOBAL_ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) >

Re: warnings in git-wireless

2007-06-06 Thread Andrew Morton
On Wed, 06 Jun 2007 13:51:41 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > > >> * make C=2 CF=-Wall will complain if you use ARRAY_SIZE on global data > >> */ > >> #define GLOBAL_ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > > > > This is identical to ARRAY_SIZE. > > > > And if there's some

Re: warnings in git-wireless

2007-06-06 Thread James Ketrenos
Andrew Morton wrote: > i386 allmodconfig isn't that hard, guys. > ... > drivers/net/wireless/mac80211/iwlwifi/iwl-4965.c:2050: warning: left shift > count >= width of type My mistake. I ran that and even fixed the warning at one point... anyway, I've committed a patch to our tree to fix the

Re: warnings in git-wireless

2007-06-06 Thread James Ketrenos
Christoph Hellwig wrote: > On Tue, Jun 05, 2007 at 01:12:03PM -0700, James Ketrenos wrote: >> Yes, we certainly don't want a driver to be "near mainline" that does >> things that the rest of the kernel and other drivers are doing. We should >> force them to stay out-of-tree until any and everyth

Re: warnings in git-wireless

2007-06-06 Thread Christoph Hellwig
On Tue, Jun 05, 2007 at 01:12:03PM -0700, James Ketrenos wrote: > Yes, we certainly don't want a driver to be "near mainline" that does > things that the rest of the kernel and other drivers are doing. We should > force them to stay out-of-tree until any and everything is resolved. > Heaven fo

Re: warnings in git-wireless

2007-06-05 Thread Andrew Morton
On Tue, 05 Jun 2007 13:12:03 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > John W. Linville wrote: > > On Tue, Jun 05, 2007 at 02:06:14AM -0700, Andrew Morton wrote: > > > >> Please, don't anybody dare think about thinking about letting this anywhere > >> near mainline until it has had a thor

Re: warnings in git-wireless

2007-06-05 Thread James Ketrenos
John W. Linville wrote: On Tue, Jun 05, 2007 at 02:06:14AM -0700, Andrew Morton wrote: Please, don't anybody dare think about thinking about letting this anywhere near mainline until it has had a thorough review. Or at least, a little bit of review. Don't worry -- I assure you that everyone

Re: warnings in git-wireless

2007-06-05 Thread John W. Linville
On Tue, Jun 05, 2007 at 02:06:14AM -0700, Andrew Morton wrote: > Please, don't anybody dare think about thinking about letting this anywhere > near mainline until it has had a thorough review. Or at least, a little bit > of review. Don't worry -- I assure you that everyone is aware of the issues