Re: suspicius csum initialization in vmxnet3_rx_csum

2018-06-05 Thread Ronak Doshi
On Tue, 5 Jun 2018, Paolo Abeni wrote: > Hi, > > I'm sorry for the long delay in my answer, I've been travelling. > > On Fri, 2018-06-01 at 11:10 -0700, Ronak Doshi wrote: > > On Thu, 31 May 2018, Neil Horman wrote: > > > What packet types will rcd.csum be set for? > > > Neil > > > > I look

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-06-05 Thread Paolo Abeni
Hi, I'm sorry for the long delay in my answer, I've been travelling. On Fri, 2018-06-01 at 11:10 -0700, Ronak Doshi wrote: > On Thu, 31 May 2018, Neil Horman wrote: > > What packet types will rcd.csum be set for? > > Neil > > I looked thorugh the emulation code and found that rcd.csum is not se

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-06-01 Thread Neil Horman
On Fri, Jun 01, 2018 at 11:10:01AM -0700, Ronak Doshi wrote: > > > On Thu, 31 May 2018, Neil Horman wrote: > > > On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote: > > > > > > On Wed, 30 May 2018, Paolo Abeni wrote: > > > > > > > Hi, > > > > > > > > On Thu, 2018-05-24 at 21:48 +

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-06-01 Thread Ronak Doshi
On Thu, 31 May 2018, Neil Horman wrote: > On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote: > > > > On Wed, 30 May 2018, Paolo Abeni wrote: > > > > > Hi, > > > > > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > > > > Yes, that code is not correct, we should fix that co

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-05-31 Thread Neil Horman
On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote: > > On Wed, 30 May 2018, Paolo Abeni wrote: > > > Hi, > > > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > > > Yes, that code is not correct, we should fix that code > > > > Did you have any chance to address the issue and

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-05-31 Thread Ronak Doshi
On Wed, 30 May 2018, Paolo Abeni wrote: > Hi, > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > > Yes, that code is not correct, we should fix that code > > Did you have any chance to address the issue and/or to give a more in- > deepth look to the change proposed in my initial emai

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-05-30 Thread Paolo Abeni
Hi, On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > Yes, that code is not correct, we should fix that code Did you have any chance to address the issue and/or to give a more in- deepth look to the change proposed in my initial email? Thanks, Paolo