Re: skb_can_coalesce() merges tcp frags with XFS-related slab objects

2019-02-20 Thread Eric Dumazet
On 02/20/2019 08:19 AM, Vasily Averin wrote: > Thank you for explanation, > though this happen in real life and triggers BUG_ON only if receiving side is > located on the same host. > Is it probably makes sense to add WARN_ON into skb_can_coalesce to detect > such cases? Yes, but please do

Re: skb_can_coalesce() merges tcp frags with XFS-related slab objects

2019-02-20 Thread Vasily Averin
On 2/20/19 6:53 PM, Eric Dumazet wrote: > On 02/20/2019 05:34 AM, Vasily Averin wrote: >> Dear David, >> >> currently do_tcp_sendpages() calls skb_can_coalesce() to merge proper tcp >> fragments. >> If these fragments are slab objects and the data is not transferred out of >> the local host >> th

Re: skb_can_coalesce() merges tcp frags with XFS-related slab objects

2019-02-20 Thread Eric Dumazet
On 02/20/2019 05:34 AM, Vasily Averin wrote: > Dear David, > > currently do_tcp_sendpages() calls skb_can_coalesce() to merge proper tcp > fragments. > If these fragments are slab objects and the data is not transferred out of > the local host > then tcp_recvmsg() can crash host on BUG_ON (se