Re: skb->truesize assertion checking for TCP

2006-04-25 Thread Jesse Brandeburg
On 4/19/06, David S. Miller <[EMAIL PROTECTED]> wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Thu, 20 Apr 2006 15:04:06 +1000 > > > On Wed, Apr 19, 2006 at 09:55:13PM -0700, David S. Miller wrote: > > > +static inline void skb_truesize_check(struct sk_buff *skb) > > > +{ > > > + if (unlik

Re: skb->truesize assertion checking for TCP

2006-04-19 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 20 Apr 2006 15:04:06 +1000 > On Wed, Apr 19, 2006 at 09:55:13PM -0700, David S. Miller wrote: > > +static inline void skb_truesize_check(struct sk_buff *skb) > > +{ > > + if (unlikely((int)skb->truesize < sizeof(struct sk_buff))) > > + sk

Re: skb->truesize assertion checking for TCP

2006-04-19 Thread Herbert Xu
Hi David: On Wed, Apr 19, 2006 at 09:55:13PM -0700, David S. Miller wrote: > > Herbert what do you think of this? > > I know it might be better to check this right where we > make the manipulations, but this catch-all trap at the > end points seems to make sense and will catch other kinds > of e