Re: question about bonding mode 4

2021-01-30 Thread moyufeng
On 2021/1/30 3:11, Jay Vosburgh wrote: > moyufeng wrote: > >> Ping... >> Any comments? Thanks! >> >> On 2021/1/15 10:02, moyufeng wrote: >>> Hi Team, >>> >>> I have a question about bonding. During testing bonding mode 4 >>> scenarios, I find that there is a very low probability that >>> the p

Re: question about bonding mode 4

2021-01-29 Thread Jay Vosburgh
moyufeng wrote: >Ping... >Any comments? Thanks! > >On 2021/1/15 10:02, moyufeng wrote: >> Hi Team, >> >> I have a question about bonding. During testing bonding mode 4 >> scenarios, I find that there is a very low probability that >> the pointer is null. The following information is displayed: >

Re: question about bonding mode 4

2021-01-22 Thread moyufeng
Ping... Any comments? Thanks! On 2021/1/15 10:02, moyufeng wrote: > Hi Team, > > I have a question about bonding. During testing bonding mode 4 > scenarios, I find that there is a very low probability that > the pointer is null. The following information is displayed: > > [99359.795934] bond0: (

Re: [QUESTION] build errors and warnings when make M=samples/bpf

2021-01-11 Thread Yonghong Song
On 1/11/21 12:17 AM, Tiezhu Yang wrote: Hi all, I found the following build errors and warnings when make M=samples/bpf on the Loongson 3A3000 platform which belongs to MIPS arch. Are theseknown issues? Should I submit patches to fix them? (1) fatal error: 'asm/rwonce.h' file not found Th

Re: question about i2c_transfer() function (regarding mdio-i2c on RollBall SFPs)

2021-01-08 Thread Wolfram Sang
> I thought as much, but maybe there is some driver which can offload > whole i2c_transfer to HW, and has to pass the addresses of the buffers > to the HW, and the HW can have problems if the buffers overlap > somewhere... Well, sure, you can never know what crazy HW is out there :) But that shou

Re: question about i2c_transfer() function (regarding mdio-i2c on RollBall SFPs)

2021-01-07 Thread Marek Behun
On Thu, 7 Jan 2021 22:02:48 +0100 Wolfram Sang wrote: > > My question is whether this is allowed, whether the msgs array passed > > to the i2c_transfer() function can have multiple msgs pointing to the > > same buffer (the one into which the original page is first stored > > with first i2c_msg an

Re: question about i2c_transfer() function (regarding mdio-i2c on RollBall SFPs)

2021-01-07 Thread Wolfram Sang
> My question is whether this is allowed, whether the msgs array passed > to the i2c_transfer() function can have multiple msgs pointing to the > same buffer (the one into which the original page is first stored > with first i2c_msg and then restored from it in the last i2c_msg). Sending the mess

Re: [QUESTION] Enable the wireless module on Pinebook Pro

2020-09-30 Thread Jian-Hong Pan
I forgot to mail to Dan Johansen as well. Jian-Hong Pan 於 2020年9月30日 週三 下午4:15寫道: > > Hi, > > According to the preloaded system Manjaro ARM on Pinebook Pro [1], I > found the firmware files in ap6256-firmware package [2] enable the > wireless module, including WiFi and Bluetooth. > If we want to

Re: Question about dev_validate_header used in af_packet.c

2020-09-08 Thread Willem de Bruijn
On Tue, Sep 8, 2020 at 6:23 PM Xie He wrote: > > On Tue, Sep 8, 2020 at 4:53 AM Willem de Bruijn > wrote: > > > > On Tue, Sep 8, 2020 at 1:04 PM Xie He wrote: > > > > > > I was recently looking at some drivers, and I felt that if af_packet.c > > > could help me filter out the invalid RAW frames,

Re: Question about dev_validate_header used in af_packet.c

2020-09-08 Thread Xie He
On Tue, Sep 8, 2020 at 4:53 AM Willem de Bruijn wrote: > > On Tue, Sep 8, 2020 at 1:04 PM Xie He wrote: > > > > I was recently looking at some drivers, and I felt that if af_packet.c > > could help me filter out the invalid RAW frames, I didn't need to > > check the validity of the frames myself

Re: Question about dev_validate_header used in af_packet.c

2020-09-08 Thread Willem de Bruijn
On Tue, Sep 8, 2020 at 1:04 PM Xie He wrote: > > On Tue, Sep 8, 2020 at 1:41 AM Willem de Bruijn > wrote: > > > > The intent is to bypass such validation to be able to test device > > drivers. Note that removing that may cause someone's test to start > > failing. > > > > > So there's no point in

Re: Question about dev_validate_header used in af_packet.c

2020-09-08 Thread Xie He
On Tue, Sep 8, 2020 at 1:41 AM Willem de Bruijn wrote: > > The intent is to bypass such validation to be able to test device > drivers. Note that removing that may cause someone's test to start > failing. > > > So there's no point in > > keeping the ability to test this, either. > > I don't disag

Re: Question about dev_validate_header used in af_packet.c

2020-09-08 Thread Willem de Bruijn
On Mon, Sep 7, 2020 at 11:17 PM Xie He wrote: > > On Mon, Sep 7, 2020 at 2:06 AM Willem de Bruijn > wrote: > > > > The CAP_SYS_RAWIO exception indeed was requested to be able to > > purposely test devices against bad inputs. The gmane link > > unfortunately no longer works, but this was the discu

Re: Question about dev_validate_header used in af_packet.c

2020-09-07 Thread Xie He
On Mon, Sep 7, 2020 at 2:06 AM Willem de Bruijn wrote: > > The CAP_SYS_RAWIO exception indeed was requested to be able to > purposely test devices against bad inputs. The gmane link > unfortunately no longer works, but this was the discussion thread: > https://www.mail-archive.com/netdev@vger.kern

Re: Question about dev_validate_header used in af_packet.c

2020-09-07 Thread Willem de Bruijn
On Sun, Sep 6, 2020 at 1:21 AM Xie He wrote: > > On Sat, Sep 5, 2020 at 3:24 PM Xie He wrote: > > > > Hi Willem, > > > > I have a question about the function dev_validate_header used in > > af_packet.c. Can you help me? Thanks! > > > > I see when the length of the data is smaller than hard_header

Re: Question about dev_validate_header used in af_packet.c

2020-09-05 Thread Xie He
On Sat, Sep 5, 2020 at 3:24 PM Xie He wrote: > > Hi Willem, > > I have a question about the function dev_validate_header used in > af_packet.c. Can you help me? Thanks! > > I see when the length of the data is smaller than hard_header_len, and > when the user is "capable" enough, the function will

Re: [Question] Oops when using connector in linux-4.19

2020-09-05 Thread Cong Wang
On Sat, Sep 5, 2020 at 12:28 AM Yang Yingliang wrote: > > Hi, > > I got some crashes when using connector module in linux-4.19: Can you test a reasonably recent kernel? > The invalid address[0x0003004c] is the value of nlmsghdr from cn > netlink, nlmsg_type is 3 and nlmsg_len is 0x4c.

Re: Question about TC filter

2020-08-17 Thread satish dhote
Sorry for responding late. I got engaged with other work. I didn't replace ingress with To do more experiments, I will have to recompile everything from fresh as I lost that setup where I was experimenting with tc utility. But if we can get inputs from Daniel's about this change, it will hel

Re: Question about TC filter

2020-08-06 Thread Cong Wang
On Thu, Aug 6, 2020 at 10:21 AM satish dhote wrote: > > Hi Cong, > > I tried adding below patch i.e. "return cl == 0 ? q->block : NULL;" > but after this I'm not able to see any output using "tc filter show... " > command. Looks like the filter is not getting configured. What exact command did yo

Re: Question about TC filter

2020-08-06 Thread satish dhote
Hi Cong, I tried adding below patch i.e. "return cl == 0 ? q->block : NULL;" but after this I'm not able to see any output using "tc filter show... " command. Looks like the filter is not getting configured. If this is a bug, then do I need to file a new ticket for this? Thanks Satish On Thu, A

Re: Question about TC filter

2020-08-05 Thread Cong Wang
Hello, On Tue, Aug 4, 2020 at 10:39 PM satish dhote wrote: > > Hi Team, > > I have a question regarding tc filter behavior. I tried to look > for the answer over the web and netdev FAQ but didn't get the > answer. Hence I'm looking for your help. > > I added ingress qdisc for interface enp0s25 an

Re: Question about TC filter

2020-08-05 Thread Jakub Kicinski
On Wed, 5 Aug 2020 11:08:08 +0530 satish dhote wrote: > Hi Team, > > I have a question regarding tc filter behavior. I tried to look > for the answer over the web and netdev FAQ but didn't get the > answer. Hence I'm looking for your help. > > I added ingress qdisc for interface enp0s25 and then

Re: Question about TC filter

2020-08-05 Thread satish dhote
Hi Jakub, Thanks for your response. Below are the OS and Kernel version I'm using. OS: Ubuntu 20.04.1 LTS Kernel Version: 5.4.0-42-generic Thanks Satish On Wed, Aug 5, 2020 at 10:15 PM Jakub Kicinski wrote: > > On Wed, 5 Aug 2020 11:08:08 +0530 satish dhote wrote: > > Hi Team, > > > > I have a

Re: Question Print Formatting iproute2

2020-07-27 Thread Briana Oursler
On Mon, 2020-07-27 at 16:47 -0700, Stephen Hemminger wrote: > On Sun, 26 Jul 2020 21:46:16 -0700 > Briana Oursler wrote: > > > I have a patch I've written to address a format specifier change > > that > > breaks some tests in tc-testing, but I wanted to ask about the > > change > > and for some g

Re: Question Print Formatting iproute2

2020-07-27 Thread Briana Oursler
On Mon, 2020-07-27 at 21:31 +0200, Petr Machata wrote: > Briana Oursler writes: > > > I git bisected and found d0e450438571("tc: q_red: Add support for > > qevents "mark" and "early_drop"), the commit that introduced the > > formatting change causing the break. > > > > - print_string(PRINT

Re: Question Print Formatting iproute2

2020-07-27 Thread Stephen Hemminger
On Sun, 26 Jul 2020 21:46:16 -0700 Briana Oursler wrote: > I have a patch I've written to address a format specifier change that > breaks some tests in tc-testing, but I wanted to ask about the change > and for some guidance with respect to how formatters are approached in > iproute2. > > On a

Re: Question Print Formatting iproute2

2020-07-27 Thread Stephen Hemminger
On Mon, 27 Jul 2020 21:31:36 +0200 Petr Machata wrote: > Briana Oursler writes: > > > I git bisected and found d0e450438571("tc: q_red: Add support for > > qevents "mark" and "early_drop"), the commit that introduced the > > formatting change causing the break. > > > > - print_string(PRIN

Re: Question Print Formatting iproute2

2020-07-27 Thread Petr Machata
Briana Oursler writes: > I git bisected and found d0e450438571("tc: q_red: Add support for > qevents "mark" and "early_drop"), the commit that introduced the > formatting change causing the break. > > - print_string(PRINT_FP, NULL, "max %s ", sprint_size(qopt->qth_max, > b3)); > +

Re: question about using UDP GSO in Linux kernel 4.19

2020-07-26 Thread Willem de Bruijn
On Sun, Jul 26, 2020 at 2:18 PM Han wrote: > > On Sun, Jul 26, 2020 at 6:42 AM Willem de Bruijn > wrote: > > > > On Sat, Jul 25, 2020 at 7:08 PM Han wrote: > > > > > > My apologies if this is not the right place to ask this question. > > > > > > I'm trying to use UDP GSO to improve the throughpu

Re: question about using UDP GSO in Linux kernel 4.19

2020-07-26 Thread Han
On Sun, Jul 26, 2020 at 6:42 AM Willem de Bruijn wrote: > > On Sat, Jul 25, 2020 at 7:08 PM Han wrote: > > > > My apologies if this is not the right place to ask this question. > > > > I'm trying to use UDP GSO to improve the throughput. My testing shows > > that UDP GSO works with the local serv

Re: question about using UDP GSO in Linux kernel 4.19

2020-07-26 Thread Willem de Bruijn
On Sat, Jul 25, 2020 at 7:08 PM Han wrote: > > My apologies if this is not the right place to ask this question. > > I'm trying to use UDP GSO to improve the throughput. My testing shows > that UDP GSO works with the local server (i.e. loopback interface) but > fails with a remote server (in WLAN,

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-20 Thread Daniel Mack
On 6/20/20 4:35 PM, Andrew Lunn wrote: >> So yes, we can read the code here, but I'm wondering which packet types >> would then get this flag set, and which won't. Because in case of >> IGMP/MLD, the packets are in fact forwarded, but the meaning of the flag >> in skb is to prevent the skb from bei

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-20 Thread Andrew Lunn
> So yes, we can read the code here, but I'm wondering which packet types > would then get this flag set, and which won't. Because in case of > IGMP/MLD, the packets are in fact forwarded, but the meaning of the flag > in skb is to prevent the skb from being forwarded further, which seems > wrong i

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Daniel Mack
On 6/20/20 12:36 AM, Andrew Lunn wrote: >> I've run into the same issue. To resolve it, In my case, in the same file, >> I've had to send all IGMP control traffic to the CPU: >> skb->offload_fwd_mark = 1; >> switch (ih->type) { >> case IGMP_HOST_MEMBERSHIP_REPORT: >>

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Daniel Mack
Hi Andrew, Thanks a lot for the quick reply! On 6/19/20 11:58 PM, Andrew Lunn wrote: > On Fri, Jun 19, 2020 at 11:31:04PM +0200, Daniel Mack wrote: >> When an IGMP query enters the switch, it is redirected to the CPU port >> as all 'external' ports are configured for IGMP/MLP snooping by the >>

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Andrew Lunn
> I've run into the same issue. To resolve it, In my case, in the same file, > I've had to send all IGMP control traffic to the CPU: > skb->offload_fwd_mark = 1; > switch (ih->type) { > case IGMP_HOST_MEMBERSHIP_REPORT: > case IGMPV2_HOST_MEMBERSHIP_REPORT:

RE: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Jason Cobham
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Andrew Lunn > Sent: Friday, June 19, 2020 2:58 PM > To: Daniel Mack > Cc: netdev@vger.kernel.org; Ido Schimmel; Jiri Pirko; Ivan Vecera; Florian > F

Re: Question on DSA switches, IGMP forwarding and switchdev

2020-06-19 Thread Andrew Lunn
On Fri, Jun 19, 2020 at 11:31:04PM +0200, Daniel Mack wrote: > Hi, > > I'm working on a custom board featuring a Marvell mv88e6085 Ethernet > switch controlled by the Linux DSA driver, and I'm facing an issue with > IGMP packet flows. > > Consider two Ethernet stations, each connected to the swit

Re: [question] net: phy: rtl8211f: link speed shows 1000Mb/s but actual link speed in phy is 100Mb/s

2020-05-12 Thread Yonglong Liu
On 2020/5/13 9:59, Andrew Lunn wrote: > On Wed, May 13, 2020 at 09:34:13AM +0800, Yonglong Liu wrote: >> Hi, Andrew: >> Thanks for your reply! >> >> On 2020/5/12 22:00, Andrew Lunn wrote: >>> On Tue, May 12, 2020 at 08:48:21PM +0800, Yonglong Liu wrote: I use two devices, both support 100

Re: [question] net: phy: rtl8211f: link speed shows 1000Mb/s but actual link speed in phy is 100Mb/s

2020-05-12 Thread Andrew Lunn
On Wed, May 13, 2020 at 09:34:13AM +0800, Yonglong Liu wrote: > Hi, Andrew: > Thanks for your reply! > > On 2020/5/12 22:00, Andrew Lunn wrote: > > On Tue, May 12, 2020 at 08:48:21PM +0800, Yonglong Liu wrote: > >> I use two devices, both support 1000M speed, they are directly connected > >>

Re: [question] net: phy: rtl8211f: link speed shows 1000Mb/s but actual link speed in phy is 100Mb/s

2020-05-12 Thread Yonglong Liu
Hi, Andrew: Thanks for your reply! On 2020/5/12 22:00, Andrew Lunn wrote: > On Tue, May 12, 2020 at 08:48:21PM +0800, Yonglong Liu wrote: >> I use two devices, both support 1000M speed, they are directly connected >> with a network cable. Two devices enable autoneg, and then do the followi

Re: [question] net: phy: rtl8211f: link speed shows 1000Mb/s but actual link speed in phy is 100Mb/s

2020-05-12 Thread Andrew Lunn
On Tue, May 12, 2020 at 08:48:21PM +0800, Yonglong Liu wrote: > I use two devices, both support 1000M speed, they are directly connected > with a network cable. Two devices enable autoneg, and then do the following > test repeatedly: > ifconfig eth5 down > ifconfig eth5 up > sleep

Re: [question] About triggering a region snapshot through the devlink cmd

2019-09-29 Thread Yunsheng Lin
On 2019/9/27 16:13, Jiri Pirko wrote: > Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsh...@huawei.com wrote: >> Hi, Jiri & Alex >> >>It seems that a region' snapshot is only created through the >> driver when some error is detected, for example: >> mlx4_crdump_collect_fw_health() -> devlink_regi

Re: [question] About triggering a region snapshot through the devlink cmd

2019-09-27 Thread Jiri Pirko
Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsh...@huawei.com wrote: >Hi, Jiri & Alex > >It seems that a region' snapshot is only created through the >driver when some error is detected, for example: >mlx4_crdump_collect_fw_health() -> devlink_region_snapshot_create() > >We want to trigger a

Re: Question on LACP Bypass feature

2019-09-26 Thread Jay Vosburgh
Madhavi Joshi wrote: >  We have a question regarding LACP Bypass feature . It appears that by >default, this feature is enabled in the kernel (we are on 4.1.1274 version >kernel). >Having said that, we do not see any sysctl or directory on the lines of >/sys/class/net//bonding/lacp_bypass. > 

Re: Question on LACP Bypass feature

2019-09-26 Thread Madhavi Joshi
Hello,     We have a question regarding LACP Bypass feature . It appears that by default, this feature is enabled in the kernel (we are on 4.1.1274 version kernel). Having said that, we do not see any sysctl or directory on the lines of /sys/class/net//bonding/lacp_bypass.   Really appreciate y

Re: Question on xen-netfront code to fix a potential ring buffer corruption

2019-08-26 Thread Juergen Gross
On 18.08.19 10:31, Dongli Zhang wrote: Hi, Would you please help confirm why the condition at line 908 is ">="? In my opinion, we would only hit "skb_shinfo(skb)->nr_frag == MAX_SKB_FRAGS" at line 908. 890 static RING_IDX xennet_fill_frags(struct netfront_queue *queue, 891

RE: Question about linux kernel commit: "net/ipv6: move metrics from dst to rt6_info"

2019-07-11 Thread Jan Szewczyk
etdev@vger.kernel.org; Wei Wang ; Martin KaFai Lau ; Eric Dumazet Subject: Re: Question about linux kernel commit: "net/ipv6: move metrics from dst to rt6_info" On 7/10/19 1:09 PM, Stefano Brivio wrote: > Jan, > > On Wed, 10 Jul 2019 12:59:41 + > Jan Szewczyk wrote: >

Re: Question about linux kernel commit: "net/ipv6: move metrics from dst to rt6_info"

2019-07-10 Thread David Ahern
On 7/10/19 1:09 PM, Stefano Brivio wrote: > Jan, > > On Wed, 10 Jul 2019 12:59:41 + > Jan Szewczyk wrote: > >> Hi! >> I digged up a little further and maybe it's not a problem with MTU >> itself. I checked every entry I get from RTM_GETROUTE netlink message >> and after triggering "too big p

Re: Question about linux kernel commit: "net/ipv6: move metrics from dst to rt6_info"

2019-07-10 Thread Stefano Brivio
Jan, On Wed, 10 Jul 2019 12:59:41 + Jan Szewczyk wrote: > Hi! > I digged up a little further and maybe it's not a problem with MTU > itself. I checked every entry I get from RTM_GETROUTE netlink message > and after triggering "too big packet" by pinging ipv6address I get > exactly the same m

RE: Question about linux kernel commit: "net/ipv6: move metrics from dst to rt6_info"

2019-07-10 Thread Jan Szewczyk
ould try to reproduce it locally on some virtual box and check if it behaves the same. Thanks for the tip about the testing tools, I'll try to use them. BR, Jan Szewczyk -Original Message- From: David Ahern Sent: Wednesday, July 10, 2019 14:28 To: Jan Szewczyk ; da...@davemloft.ne

Re: Question about linux kernel commit: "net/ipv6: move metrics from dst to rt6_info"

2019-07-10 Thread David Ahern
[ adding netdev so others can chime in ] On 7/10/19 2:28 AM, Jan Szewczyk wrote: > Hi guys! > > We can see different behavior of one of our commands that supposed to > show pmtu information. > > It’s using netlink message RTM_GETROUTE to get the information and in > Linux kernel version 4.12 aft

Re: Question about nf_conntrack_proto for IPsec

2019-07-10 Thread Florian Westphal
Naruto Nguyen wrote: > Could you please elaborate more on how generic tracker tracks ESP connection? All protocols that do not have a more specific l4 tracker are tracked based on l3 protocol + l4 proto number. IOW, any ESP packet sent between the same endpoint addresses is seen as matching a si

Re: Question about nf_conntrack_proto for IPsec

2019-07-09 Thread Naruto Nguyen
Hi Florian, Thanks a lot for your reply. Could you please elaborate more on how generic tracker tracks ESP connection? Brs, Bao On Wed, 26 Jun 2019 at 18:13, Florian Westphal wrote: > > Naruto Nguyen wrote: > > In linux/latest/source/net/netfilter/ folder, I only see we have > > nf_conntrack_

Re: Question about nf_conntrack_proto for IPsec

2019-06-26 Thread Florian Westphal
Naruto Nguyen wrote: > In linux/latest/source/net/netfilter/ folder, I only see we have > nf_conntrack_proto_tcp.c, nf_conntrack_proto_udp.c and some other > conntrack implementations for other protocols but I do not see > nf_conntrack_proto for IPsec, so does it mean connection tracking > cannot

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-23 Thread Stefano Garzarella
On Wed, May 22, 2019 at 11:44:26AM +0800, Jason Wang wrote: > > On 2019/5/21 下午9:56, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 03:49:20PM +0200, Stefano Garzarella wrote: > > > On Tue, May 21, 2019 at 06:05:31AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, May 21, 2019 at 11:44:07A

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-21 Thread Jason Wang
On 2019/5/21 下午9:56, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 03:49:20PM +0200, Stefano Garzarella wrote: On Tue, May 21, 2019 at 06:05:31AM -0400, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 11:44:07AM +0200, Stefano Garzarella wrote: Hi Micheal, Jason, as suggested by Stefan

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-21 Thread Stefano Garzarella
On Tue, May 21, 2019 at 09:56:42AM -0400, Michael S. Tsirkin wrote: > On Tue, May 21, 2019 at 03:49:20PM +0200, Stefano Garzarella wrote: > > On Tue, May 21, 2019 at 06:05:31AM -0400, Michael S. Tsirkin wrote: > > > On Tue, May 21, 2019 at 11:44:07AM +0200, Stefano Garzarella wrote: > > > > Hi Mich

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-21 Thread Michael S. Tsirkin
On Tue, May 21, 2019 at 03:49:20PM +0200, Stefano Garzarella wrote: > On Tue, May 21, 2019 at 06:05:31AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 11:44:07AM +0200, Stefano Garzarella wrote: > > > Hi Micheal, Jason, > > > as suggested by Stefan, I'm checking if we have some races

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-21 Thread Stefano Garzarella
On Tue, May 21, 2019 at 06:05:31AM -0400, Michael S. Tsirkin wrote: > On Tue, May 21, 2019 at 11:44:07AM +0200, Stefano Garzarella wrote: > > Hi Micheal, Jason, > > as suggested by Stefan, I'm checking if we have some races in the > > virtio-vsock driver. We found some races in the .probe() and .re

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-21 Thread Michael S. Tsirkin
On Tue, May 21, 2019 at 11:44:07AM +0200, Stefano Garzarella wrote: > Hi Micheal, Jason, > as suggested by Stefan, I'm checking if we have some races in the > virtio-vsock driver. We found some races in the .probe() and .remove() > with the upper layer (socket) and I'll fix it. > > Now my attentio

Re: Question about seccomp / bpf

2019-05-09 Thread Kees Cook
On Thu, May 9, 2019 at 4:30 PM Alexei Starovoitov wrote: > I'm not sure how that can work. seccomp's prctl accepts a list of insns. > There is no handle. > kernel can keep a hashtable of all progs ever loaded and do a search > in it before loading another one, but that's an ugly hack. > Another al

Re: Question about seccomp / bpf

2019-05-09 Thread Eric Dumazet
On Thu, May 9, 2019 at 4:30 PM Alexei Starovoitov wrote: > > On Thu, May 09, 2019 at 01:49:25PM +0200, Daniel Borkmann wrote: > > On 05/09/2019 12:58 PM, Eric Dumazet wrote: > > > On Thu, May 9, 2019 at 3:52 AM Eric Dumazet wrote: > > >> On Wed, May 8, 2019 at 9:47 PM Alexei Starovoitov > > >> w

Re: Question about seccomp / bpf

2019-05-09 Thread Alexei Starovoitov
On Thu, May 09, 2019 at 04:50:12PM -0700, Eric Dumazet wrote: > On Thu, May 9, 2019 at 4:30 PM Alexei Starovoitov > wrote: > > > > On Thu, May 09, 2019 at 01:49:25PM +0200, Daniel Borkmann wrote: > > > On 05/09/2019 12:58 PM, Eric Dumazet wrote: > > > > On Thu, May 9, 2019 at 3:52 AM Eric Dumazet

Re: Question about seccomp / bpf

2019-05-09 Thread Alexei Starovoitov
On Thu, May 09, 2019 at 01:49:25PM +0200, Daniel Borkmann wrote: > On 05/09/2019 12:58 PM, Eric Dumazet wrote: > > On Thu, May 9, 2019 at 3:52 AM Eric Dumazet wrote: > >> On Wed, May 8, 2019 at 9:47 PM Alexei Starovoitov > >> wrote: > >>> On Wed, May 08, 2019 at 04:17:29PM -0700, Eric Dumazet wro

Re: Question about seccomp / bpf

2019-05-09 Thread Daniel Borkmann
On 05/09/2019 12:58 PM, Eric Dumazet wrote: > On Thu, May 9, 2019 at 3:52 AM Eric Dumazet wrote: >> On Wed, May 8, 2019 at 9:47 PM Alexei Starovoitov >> wrote: >>> On Wed, May 08, 2019 at 04:17:29PM -0700, Eric Dumazet wrote: On Wed, May 8, 2019 at 4:09 PM Alexei Starovoitov wrote: >>>

Re: Question about seccomp / bpf

2019-05-09 Thread Eric Dumazet
On Thu, May 9, 2019 at 3:52 AM Eric Dumazet wrote: > > On Wed, May 8, 2019 at 9:47 PM Alexei Starovoitov > wrote: > > > > On Wed, May 08, 2019 at 04:17:29PM -0700, Eric Dumazet wrote: > > > On Wed, May 8, 2019 at 4:09 PM Alexei Starovoitov > > > wrote: > > > > > > > > On Wed, May 08, 2019 at 02:

Re: Question about seccomp / bpf

2019-05-09 Thread Eric Dumazet
On Wed, May 8, 2019 at 9:47 PM Alexei Starovoitov wrote: > > On Wed, May 08, 2019 at 04:17:29PM -0700, Eric Dumazet wrote: > > On Wed, May 8, 2019 at 4:09 PM Alexei Starovoitov > > wrote: > > > > > > On Wed, May 08, 2019 at 02:21:52PM -0700, Eric Dumazet wrote: > > > > Hi Alexei and Daniel > > >

Re: Question about seccomp / bpf

2019-05-08 Thread Alexei Starovoitov
On Wed, May 08, 2019 at 04:17:29PM -0700, Eric Dumazet wrote: > On Wed, May 8, 2019 at 4:09 PM Alexei Starovoitov > wrote: > > > > On Wed, May 08, 2019 at 02:21:52PM -0700, Eric Dumazet wrote: > > > Hi Alexei and Daniel > > > > > > I have a question about seccomp. > > > > > > It seems that after t

Re: Question about seccomp / bpf

2019-05-08 Thread Eric Dumazet
On Wed, May 8, 2019 at 4:09 PM Alexei Starovoitov wrote: > > On Wed, May 08, 2019 at 02:21:52PM -0700, Eric Dumazet wrote: > > Hi Alexei and Daniel > > > > I have a question about seccomp. > > > > It seems that after this patch, seccomp no longer needs a helper > > (seccomp_bpf_load()) > > > > htt

Re: Question about seccomp / bpf

2019-05-08 Thread Alexei Starovoitov
On Wed, May 08, 2019 at 02:21:52PM -0700, Eric Dumazet wrote: > Hi Alexei and Daniel > > I have a question about seccomp. > > It seems that after this patch, seccomp no longer needs a helper > (seccomp_bpf_load()) > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=

Re: Question re. skb_orphan for TPROXY

2019-05-02 Thread Eric Dumazet
On 4/16/19 8:00 AM, Florian Westphal wrote: > Lorenz Bauer wrote: >> Apologies for contacting you out of the blue. I'm currently trying to >> understand how TPROXY works under the hood. As part of this endeavour, >> I've stumbled upon the commit attached to this email. >> >> From the commit mes

Re: Question re. skb_orphan for TPROXY

2019-04-18 Thread Lorenz Bauer
Hello Florian, Thank you, that makes sense. I guess that technically early demux also relies on the skb_orphan call to function? I think that's what confused me. Best Lorenz On Tue, 16 Apr 2019 at 17:00, Florian Westphal wrote: > > Lorenz Bauer wrote: > > Apologies for contacting you out of th

Re: Question re. skb_orphan for TPROXY

2019-04-16 Thread Florian Westphal
Lorenz Bauer wrote: > Apologies for contacting you out of the blue. I'm currently trying to > understand how TPROXY works under the hood. As part of this endeavour, > I've stumbled upon the commit attached to this email. > > From the commit message I infer that somewhere, TPROXY relies on a > che

Re: question about memory leak in ip_mc_del1_src

2019-03-05 Thread David Miller
From: maowenan Date: Tue, 5 Mar 2019 11:33:03 +0800 > > > On 2019/3/5 2:16, David Miller wrote: >> From: maowenan >> Date: Mon, 4 Mar 2019 20:47:42 +0800 >> >>> pmc->tomb = psf; >>> rv = 1; //if it does not kfree(psf), will it >>> lead to memor

Re: question about memory leak in ip_mc_del1_src

2019-03-04 Thread maowenan
On 2019/3/5 2:16, David Miller wrote: > From: maowenan > Date: Mon, 4 Mar 2019 20:47:42 +0800 > >> pmc->tomb = psf; >> rv = 1; //if it does not kfree(psf), will it >> lead to memory leak after this line? > > pmc->tomb points to psf, why shoul

Re: question about memory leak in ip_mc_del1_src

2019-03-04 Thread David Miller
From: maowenan Date: Mon, 4 Mar 2019 20:47:42 +0800 > pmc->tomb = psf; > rv = 1; //if it does not kfree(psf), will it > lead to memory leak after this line? pmc->tomb points to psf, why should we free it?

RE: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy

2019-03-03 Thread liweihang
> -Original Message- > From: Michal Vokáč [mailto:michal.vo...@ysoft.com] > Sent: Friday, March 01, 2019 8:58 PM > To: liweihang > Cc: netdev@vger.kernel.org; da...@davemloft.net; linyunsheng > ; Zhuangyuzeng (Yisen) > ; Salil Mehta ; > lipeng (Y) ; shenjian (K)

RE: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy

2019-03-01 Thread Salil Mehta
(+) LinuxArm > From: Michal Vokáč [mailto:michal.vo...@ysoft.com] > Sent: Friday, March 1, 2019 12:58 PM > To: liweihang > Cc: netdev@vger.kernel.org; da...@davemloft.net; linyunsheng > ; Zhuangyuzeng (Yisen) > ; Salil Mehta ; lipeng > (Y) ; shenjian (K) > Subject: Re

Re: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy

2019-03-01 Thread Michal Vokáč
On 01. 03. 19 12:26, liweihang wrote: Hi all, We encountered a problem that if there are two devices in kernel v5.0 with marvell phy 88E1510 connect with each other directly, one with autoneg on and the other off. The one who has disabled auto-negotiation will failed on setting speed and duplex

Re: Question on ptr_ring linux header

2019-02-28 Thread fei phung
Hi Michael , I have solved all the data race issue , it seems. The data race culprit is the ring index which I have removed in the latest datarace-free code. The diff can be found at https://www.diffchecker.com/w0Pxp2mF I plan to study the internal implementation of ptr_ring c coding in the comi

Re: Question on ptr_ring linux header

2019-02-14 Thread fei phung
Hi Michael, > If I had to guess I'd say the way you play with indices is probably racy > so you are producing an invalid index. You are probably right. I am suspecting item_recv_push_index and item_send_push_index in https://gist.github.com/promach/7716ee8addcaa33fda140d74d1ad94d6#file-riffa_dri

Re: Question on ptr_ring linux header

2019-02-01 Thread Michael S. Tsirkin
On Fri, Feb 01, 2019 at 04:12:46PM +0800, fei phung wrote: > > I am not sure what does assignment of pointers mean in this context. > > ptr_ring is designed for a single producer and a single consumer. For > > why it works see explanation about data dependencies in > > Documentation/memory-barrier

Re: Question on ptr_ring linux header

2019-02-01 Thread fei phung
> I am not sure what does assignment of pointers mean in this context. > ptr_ring is designed for a single producer and a single consumer. For > why it works see explanation about data dependencies in > Documentation/memory-barriers.txt. You will have to be more specific > about the data race tha

Re: Question on ptr_ring linux header

2019-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2019 at 01:16:31PM +0800, fei phung wrote: > Hi, > > /* > * Filename: circ_ring.c > * Version: 1.0 > * Description: A circular buffer using API from > * https://github.com/torvalds/linux/blob/master/include/linux/ptr_ring.h > */ > > ptr_ring's void** queue is just giving data

Re: Question on ptr_ring linux header

2019-01-30 Thread fei phung
Hi, /* * Filename: circ_ring.c * Version: 1.0 * Description: A circular buffer using API from * https://github.com/torvalds/linux/blob/master/include/linux/ptr_ring.h */ ptr_ring's void** queue is just giving data race problem, running consume() together with [assignment of pointers+produce(

Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-24 Thread Yunsheng Lin
On 2019/1/24 6:41, Russell King - ARM Linux admin wrote: > On Sat, Jan 05, 2019 at 11:28:19AM +0800, Yunsheng Lin wrote: >> On 2018/12/17 22:36, Russell King - ARM Linux wrote: >>> I'll try to do further diagnosis over Christmas in case I've missed >>> something, but I suspect it may be one of thos

Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-23 Thread Russell King - ARM Linux admin
On Sat, Jan 05, 2019 at 11:28:19AM +0800, Yunsheng Lin wrote: > On 2018/12/17 22:36, Russell King - ARM Linux wrote: > > I'll try to do further diagnosis over Christmas in case I've missed > > something, but I suspect it may be one of those "weird behaviour" issues > > where the safest action is to

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-17 Thread shenjian (K)
在 2019/1/17 20:41, Andrew Lunn 写道: > On Thu, Jan 17, 2019 at 10:58:07AM +0800, shenjian (K) wrote: >> >> >> 在 2019/1/17 0:04, Andrew Lunn 写道: Thanks, Andrew. But we are using acpi mode, is there any ohter way to poke values into registers ? >>> >>> You can register a PHY fix

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-17 Thread Andrew Lunn
On Thu, Jan 17, 2019 at 10:58:07AM +0800, shenjian (K) wrote: > > > 在 2019/1/17 0:04, Andrew Lunn 写道: > >> Thanks, Andrew. > >> > >> But we are using acpi mode, is there any ohter way to poke values into > >> registers ? > > > > You can register a PHY fixup. > > > > phy_register_fixup_for_uid(

Re: Question on ptr_ring linux header

2019-01-16 Thread fei phung
Hi, I am having data race from threadsanitizer report. Could you see if there is still data race in the following code using ptr_ring API ? /* * Filename: circ_ring.c * Version: 1.0 * Description: A circular buffer using API from * https://github.com/torvalds/linux/blob/master/include/linu

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-16 Thread shenjian (K)
在 2019/1/15 17:08, Wang, Dongsheng 写道: > On 2019/1/15 14:41, shenjian (K) wrote: >> >> 在 2019/1/15 11:39, Andrew Lunn 写道: >>> On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote: Hi, all We encounted a problem when using the marvel 88e151x phy driver, the link(LED[0])/

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-16 Thread shenjian (K)
在 2019/1/17 0:04, Andrew Lunn 写道: >> Thanks, Andrew. >> >> But we are using acpi mode, is there any ohter way to poke values into >> registers ? > > You can register a PHY fixup. > > phy_register_fixup_for_uid(), mach-orion5x/dns323-setup.c > > Andrew > > . > Thanks Andrew! I have t

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-16 Thread Andrew Lunn
> Thanks, Andrew. > > But we are using acpi mode, is there any ohter way to poke values into > registers ? You can register a PHY fixup. phy_register_fixup_for_uid(), mach-orion5x/dns323-setup.c Andrew

Re: Question on ptr_ring linux header

2019-01-16 Thread Michael S. Tsirkin
On Wed, Jan 16, 2019 at 06:48:41AM +, Cheng Fei Phung wrote: > Hi, > > > https://gist.github.com/promach/65e9331d55a43a2815239430a28e29c6#file-circ_ring-c-L62 > > racy if there are multiple consumers. > > just call ptr_ring_consume_any. > > If I modify pop_circ_queue() below to directly use p

Re: Question on ptr_ring linux header

2019-01-15 Thread fei phung
Hi, > https://gist.github.com/promach/65e9331d55a43a2815239430a28e29c6#file-circ_ring-c-L62 > racy if there are multiple consumers. > just call ptr_ring_consume_any. If I modify pop_circ_queue() below to directly use ptr_ring_consume_any() without ptr_ring_empty_any() , I am afraid I am running i

Re: Question on ptr_ring linux header

2019-01-15 Thread Michael S. Tsirkin
On Wed, Jan 16, 2019 at 01:10:31AM +0800, fei phung wrote: > Hi, > > inline int pop_circ_queue(struct ptr_ring * buffer, struct item * item_pop) > { > if (!ptr_ring_empty_any(buffer)) // if (not empty) > { > DEBUG_MSG(KERN_INFO "Before pop, head = %u , tail = > %u\n

Re: Question on ptr_ring linux header

2019-01-15 Thread fei phung
Hi, inline int pop_circ_queue(struct ptr_ring * buffer, struct item * item_pop) { if (!ptr_ring_empty_any(buffer)) // if (not empty) { DEBUG_MSG(KERN_INFO "Before pop, head = %u , tail = %u\n", buffer->consumer_head, buffer->consumer_tail); /* extra

Re: Question on ptr_ring linux header

2019-01-15 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 12:33:28PM +0800, fei phung wrote: > Hi netdev mailing list and Michael, > > I am having problem getting proper ptr_ring operation where one > ptr_ring entry (val1=2 for item_recv_pop) is missing from the void ** > queue > > Did I initialize the ring pointers (ptr_ring_ini

Re: Question about default m88e1510 LED configuration of marvell phy

2019-01-15 Thread Wang, Dongsheng
On 2019/1/15 14:41, shenjian (K) wrote: > > 在 2019/1/15 11:39, Andrew Lunn 写道: >> On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote: >>> Hi, all >>> We encounted a problem when using the marvel 88e151x phy driver, the >>> link(LED[0])/ack(LED[1]) leds worked abnormally since we updat

  1   2   3   4   >