Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 11:16 AM, Hannes Frederic Sowa wrote: On Fri, May 22, 2015, at 18:24, Mark Salyzyn wrote: On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the unix_strea

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Fri, May 22, 2015, at 18:24, Mark Salyzyn wrote: > On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: > > I still wonder if we need to actually recheck the condition and not > > simply break out of unix_stream_data_wait: > > > > We return to the unix_stream_recvmsg loop and recheck the > > sk_r

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the unix_stream_recvmsg loop and recheck the sk_receive_queue. At this point sk_receive_queue is not really protected wi

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Fr, 2015-05-22 at 07:51 -0700, Mark Salyzyn wrote: > On 05/22/2015 02:50 AM, Hannes Frederic Sowa wrote: > > On Do, 2015-05-21 at 09:25 -0700, Mark Salyzyn wrote: > >> got a rare NULL pointer dereference in clear_bit > >> > >> Signed-off-by: Mark Salyzyn > >> --- > >> net/unix/af_unix.c | 5 +

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 02:50 AM, Hannes Frederic Sowa wrote: On Do, 2015-05-21 at 09:25 -0700, Mark Salyzyn wrote: got a rare NULL pointer dereference in clear_bit Signed-off-by: Mark Salyzyn --- net/unix/af_unix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/unix/af_unix.c b/net/uni

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Do, 2015-05-21 at 09:25 -0700, Mark Salyzyn wrote: > got a rare NULL pointer dereference in clear_bit > > Signed-off-by: Mark Salyzyn > --- > net/unix/af_unix.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c > index 5266ea7..37a8925 1006