Re: macb napi strange behavior

2015-06-26 Thread Francois Romieu
Nicolae Rosia : [...] > I gave it a shot. Can you please take a look? > I don't know how to deal with multiple queues since Zynq 7000 has one > queue per interface. macb_interrupt knows the queue. macb_poll doesn't. Either you store it somewhere or you go for per queue napi struct. -- Ueimor --

Re: macb napi strange behavior

2015-06-26 Thread Nicolae Rosia
Hi, I gave it a shot. Can you please take a look? I don't know how to deal with multiple queues since Zynq 7000 has one queue per interface. I get a performance improvement of over 110 Mbps in IP forwarding (680 Mbps vs 570 Mbps) and a massive reduction of interrupts. Patch below. From: Nicolae

Re: macb napi strange behavior

2015-06-22 Thread Nicolae Rosia
On Sat, Jun 20, 2015 at 7:43 PM, Francois Romieu wrote: > Florian Fainelli : > [...] >> Typically, NAPI is used at the receive side of the Ethernet NIC/driver >> to lower the hard/soft interrupt context switch, although there is >> nothing that prevent you to implement a similar scheme for the >>

Re: macb napi strange behavior

2015-06-20 Thread Francois Romieu
Florian Fainelli : [...] > Typically, NAPI is used at the receive side of the Ethernet NIC/driver > to lower the hard/soft interrupt context switch, although there is > nothing that prevent you to implement a similar scheme for the > transmit side. Usually, for transmit you will be submitting one

Re: macb napi strange behavior

2015-06-17 Thread Florian Fainelli
2015-06-17 12:00 GMT-07:00 Nicolae Rosia : > Hi, > > On Wed, Jun 17, 2015 at 9:54 PM, Jaeden Amero wrote: >> On 06/17/2015 11:09 AM, Nicolae Rosia wrote: >> The times we've seen tons of interrupts on Ethernet with interrupts >> routed through the PL was when the FPGA was unprogrammed (or in the >>

Re: macb napi strange behavior

2015-06-17 Thread Nicolae Rosia
Hi, On Wed, Jun 17, 2015 at 9:54 PM, Jaeden Amero wrote: > On 06/17/2015 11:09 AM, Nicolae Rosia wrote: > The times we've seen tons of interrupts on Ethernet with interrupts > routed through the PL was when the FPGA was unprogrammed (or in the > process of being reprogrammed), or was configured w

Re: macb napi strange behavior

2015-06-17 Thread Jaeden Amero
On 06/17/2015 11:09 AM, Nicolae Rosia wrote: > I'm trying to determine why I have a huge number of IRQs for only a > macb interface and the other one works just fine (low IRQ activity). I > have activated IP forward and I'm just forwarding packets from eth0 to > eth1. > The platform is Zynq7, Linux