Re: iwlwifi: mvm: add reorder buffer per queue

2016-05-16 Thread Dave Taht
I can't even describe how much I hate the concept of the reorder buffer in general. Ordering is the endpoints problem. Someday, after we get fq_codeled, short queues again, I'll be able to show why. On Mon, May 16, 2016 at 4:41 AM, Luca Coelho wrote: > On Fri, 2016-05-13 at 11:54 +0300, Dan Carp

Re: iwlwifi: mvm: add reorder buffer per queue

2016-05-16 Thread Luca Coelho
On Fri, 2016-05-13 at 11:54 +0300, Dan Carpenter wrote: > Hello Sara Sharon, > > The patch b915c10174fb: "iwlwifi: mvm: add reorder buffer per queue" > from Mar 23, 2016, leads to the following static checker warnings: > > drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:912 > iwl_mvm_rx_mpdu_

re: iwlwifi: mvm: add reorder buffer per queue

2016-05-13 Thread Dan Carpenter
Hello Sara Sharon, The patch b915c10174fb: "iwlwifi: mvm: add reorder buffer per queue" from Mar 23, 2016, leads to the following static checker warnings: drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:912 iwl_mvm_rx_mpdu_mq() error: potential NULL dereference 'sta'. drive